public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Chee, Tien Fong" <tienfong.chee@altera.com>
To: Tom Rini <trini@konsulko.com>, u-boot@lists.denx.de
Cc: Marek Vasut <marex@denx.de>,
	Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>,
	Tien Fong Chee <tien.fong.chee@altera.com>,
	Lim Siew Chin <elly.siew.chin.lim@intel.com>,
	Chin-Liang See <chin.liang.see@intel.com>,
	Dinh Nguyen <dinh.nguyen@intel.com>
Subject: Re: [PATCH] socfpga: Remove incorrect CONFIG_SPL_LDSCRIPT settings
Date: Tue, 10 Feb 2026 12:00:59 +0800	[thread overview]
Message-ID: <c7f23e3c-d445-4c3c-bd36-593c8a5e85fc@altera.com> (raw)
In-Reply-To: <20260205221645.3749285-1-trini@konsulko.com>


On 6/2/2026 6:16 am, Tom Rini wrote:
> [CAUTION: This email is from outside your organization. Unless you trust the sender, do not click on links or open attachments as it may be a fraudulent email attempting to steal your information and/or compromise your computer.]
>
> These platforms set CONFIG_SPL_LDSCRIPT to a file that doesn't exist,
> and in turn were using the default of arch/arm/cpu/armv8/u-boot-spl.lds
> instead.
>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> Cc: Marek Vasut <marex@denx.de>
> Cc: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
> Cc: Tien Fong Chee <tien.fong.chee@altera.com>
> Cc: Lim Siew Chin <elly.siew.chin.lim@intel.com>
> Cc: Chin-Liang See <chin.liang.see@intel.com>
> Cc: Dinh Nguyen <dinh.nguyen@intel.com>
> ---
>   configs/socfpga_agilex7m_defconfig      | 1 -
>   configs/socfpga_n5x_atf_defconfig       | 1 -
>   configs/socfpga_n5x_vab_defconfig       | 1 -
>   configs/socfpga_stratix10_atf_defconfig | 1 -
>   4 files changed, 4 deletions(-)
>
> diff --git a/configs/socfpga_agilex7m_defconfig b/configs/socfpga_agilex7m_defconfig
> index 0a8c58234b95..d3ecca436efd 100644
> --- a/configs/socfpga_agilex7m_defconfig
> +++ b/configs/socfpga_agilex7m_defconfig
> @@ -1,7 +1,6 @@
>   #include <configs/socfpga_agilex_defconfig>
>
>   CONFIG_NR_DRAM_BANKS=1
> -CONFIG_SPL_LDSCRIPT="arch/arm/mach-socfpga/u-boot-spl-soc64.lds"
>   # CONFIG_TARGET_SOCFPGA_AGILEX_SOCDK is not set
>   # CONFIG_IDENT_STRING is not set
>   CONFIG_SPL_BSS_START_ADDR=0x1ff00000
> diff --git a/configs/socfpga_n5x_atf_defconfig b/configs/socfpga_n5x_atf_defconfig
> index 1ef20ba97a84..bb8f1eb7264e 100644
> --- a/configs/socfpga_n5x_atf_defconfig
> +++ b/configs/socfpga_n5x_atf_defconfig
> @@ -4,7 +4,6 @@ CONFIG_ARCH_SOCFPGA=y
>   CONFIG_TEXT_BASE=0x200000
>   CONFIG_SYS_MALLOC_LEN=0x500000
>   CONFIG_NR_DRAM_BANKS=2
> -CONFIG_SPL_LDSCRIPT="arch/arm/mach-socfpga/u-boot-spl-soc64.lds"
>   CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
>   CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x300000
>   CONFIG_SF_DEFAULT_MODE=0x2003
> diff --git a/configs/socfpga_n5x_vab_defconfig b/configs/socfpga_n5x_vab_defconfig
> index a4798e2f953d..78fe42e107c7 100644
> --- a/configs/socfpga_n5x_vab_defconfig
> +++ b/configs/socfpga_n5x_vab_defconfig
> @@ -4,7 +4,6 @@ CONFIG_ARCH_SOCFPGA=y
>   CONFIG_TEXT_BASE=0x200000
>   CONFIG_SYS_MALLOC_LEN=0x500000
>   CONFIG_NR_DRAM_BANKS=2
> -CONFIG_SPL_LDSCRIPT="arch/arm/mach-socfpga/u-boot-spl-soc64.lds"
>   CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
>   CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x300000
>   CONFIG_SF_DEFAULT_MODE=0x2003
> diff --git a/configs/socfpga_stratix10_atf_defconfig b/configs/socfpga_stratix10_atf_defconfig
> index 63ea467baefe..206343885d96 100644
> --- a/configs/socfpga_stratix10_atf_defconfig
> +++ b/configs/socfpga_stratix10_atf_defconfig
> @@ -4,7 +4,6 @@ CONFIG_ARCH_SOCFPGA=y
>   CONFIG_TEXT_BASE=0x200000
>   CONFIG_SYS_MALLOC_LEN=0x500000
>   CONFIG_NR_DRAM_BANKS=2
> -CONFIG_SPL_LDSCRIPT="arch/arm/mach-socfpga/u-boot-spl-soc64.lds"
>   CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
>   CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x300000
>   CONFIG_SF_DEFAULT_MODE=0x2003
> --
> 2.43.0


Reviewed-by: Tien Fong Chee <tien.fong.chee@altera.com>

Best regards,
Tien Fong


      reply	other threads:[~2026-02-10  4:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-05 22:16 [PATCH] socfpga: Remove incorrect CONFIG_SPL_LDSCRIPT settings Tom Rini
2026-02-10  4:00 ` Chee, Tien Fong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c7f23e3c-d445-4c3c-bd36-593c8a5e85fc@altera.com \
    --to=tienfong.chee@altera.com \
    --cc=chin.liang.see@intel.com \
    --cc=dinh.nguyen@intel.com \
    --cc=elly.siew.chin.lim@intel.com \
    --cc=marex@denx.de \
    --cc=simon.k.r.goldschmidt@gmail.com \
    --cc=tien.fong.chee@altera.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox