From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3BE4FC636D6 for ; Mon, 6 Feb 2023 12:23:06 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E420E85BCB; Mon, 6 Feb 2023 13:23:03 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="xSsHXzP7"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4086D85BA9; Mon, 6 Feb 2023 13:23:01 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on20627.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe5a::627]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 232B2859D7; Mon, 6 Feb 2023 13:22:58 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=michal.simek@amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X9Zvkh0yDdHVx6RYs+MJagMil2uaYZNzb6f2u132fOOwT1XA1BN+V+SlvD1WvfE+azXymSDXVq52WnynDSjdITnfR/UUCaDEeA/WzQcpvxbuqfaDKeoOa3FWfMm981GhZRImCpt38XkyiMWT3Lg3DwKSZQluKZOzXp4sDjHxD9vr+bJddQehNqkpWhE9PJ4duVhPvKMQEUlW7iVErew18sSRNgrfHJcYrPflucD/qu5DhN0+irobjfWvCrHJjOI4hqM1Pq9Fo9LdvunPOPudNma+XPFlNYYQRkLeKsTY9IbQy37RsNiC01xVpcqt0hGtMOTBGg/siogwSjTuW8cuyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hyIxZ7l5VqcQvErkPcgQv9CO4U7+MFBLMIbzNTNdgjw=; b=OkDqLERmtEd6AGcf+1ut/aL45iQWVU0w6iH3jwTlhnzrHoA9xVGeBClUsXeUTxpRfqTEOEuHZjItHqI2mdE5v8Uz05OgSzVe5bbaalsbgyf8eDZKiWMLweTEnkK1jMLxOnNWYZdRJaZq7sqJOaF7Vhhw6Kkg3uUsK4wUgFkJpJ5l1zYWVGR5QMXkCmcuT0zV7WsaQnLYcYBg4BOpN1fq+HdGatX3qo0Zsz2ux55AhU/ywkqb3IPUMdyIaO3ckJAPiz7jw2+ipB6inKcQlNkPiVHSbDJ/Ea9nqYE1k5PzOIy+WTdI9L5i2qexnn9rjnahwVayEiITSO7kYLnF3/MFkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=chromium.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hyIxZ7l5VqcQvErkPcgQv9CO4U7+MFBLMIbzNTNdgjw=; b=xSsHXzP7tYAzyKfeUJm/7L+HRunXRAga+wKhj5bIUzlvkGAdEepJtqHVFU+XsyPxL4q8+1EF+BenEEtYvz9UyAICXXs+NRel4BzsLsPJUPCp5ArwhjiOb8P5n8iB4XOC8XdsCQiSz5TaVWzFlCaEMHRYjwAVBscKIUnWtZxrw/U= Received: from DS7PR03CA0151.namprd03.prod.outlook.com (2603:10b6:5:3b2::6) by SN7PR12MB7323.namprd12.prod.outlook.com (2603:10b6:806:29a::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Mon, 6 Feb 2023 12:22:53 +0000 Received: from DM6NAM11FT035.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3b2:cafe::39) by DS7PR03CA0151.outlook.office365.com (2603:10b6:5:3b2::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34 via Frontend Transport; Mon, 6 Feb 2023 12:22:53 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT035.mail.protection.outlook.com (10.13.172.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6064.34 via Frontend Transport; Mon, 6 Feb 2023 12:22:53 +0000 Received: from [10.254.241.50] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 6 Feb 2023 06:22:51 -0600 Message-ID: Date: Mon, 6 Feb 2023 13:22:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v3 6/8] dm: treewide: Complete migration to new driver model schema Content-Language: en-US To: Simon Glass , CC: U-Boot Custodians , Tom Rini References: <20230201225428.2001161-1-sjg@chromium.org> <20230201225428.2001161-7-sjg@chromium.org> From: Michal Simek In-Reply-To: <20230201225428.2001161-7-sjg@chromium.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT035:EE_|SN7PR12MB7323:EE_ X-MS-Office365-Filtering-Correlation-Id: 1fd81ca8-26bb-49e5-2269-08db083cdeeb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1R2KlXBLFBpd5iWFTCVmHD+TQWzkkpgkuORPZfCuUD9njBrhun2Mfr7sOTyqYMjNOWETk3sXrnx0Rwq4WqBxpt0r/NKHedcjnRMldrtd7moBjTjcj3PH47K83h5iSJMsIN2gpzH3gTN0XZAJaFmEAYAd/4N7rTHQ4DM/koP7DDJk9tz8w/ObBOA/JgM2Yc6sIu/1TcLk5u3/0redIUM4wTM9Hz6YQUAkwys1EdtvWDFcS1yQ9cgPnKt10/YaAv+BMHnDPwpN8PbxqsP/swLM6I1HbtjS93fSRjny5pMpX04wXLMewynR6nSdg1IWz+VpP13Bq08Vi8zGpHTCI1t+CknUPOvQsFbTdU+nGiq25Wx4jBdUHujKs7n4TEzG40dxL9W+YS1bEN1IatZIBRgrmYdvo1X4XfDQe1t5u1ebHgTX2nkVb1vWYdQHY0Hb8kJ4d9gZi4wkv2kOnhZyy4v3VIq+0W8v7bgCoUGP4agg8yrGg2W/ia1Du/6OMUMUx/2Je5JmPx8c2YM/jQzR8r4UbpmB0fBowEQtqOl3Ehp8PoryEemVjoH+X/xHK9ku/yxKR3xgtg5CSBSo7MpHfR5s13J27Zhop9/0MYHc6BDBiDWX5+0LPLuyf82x75t7NyoXwrYAupce3COWYhgSnOppDyNxmQNQDriU7RD+HMukZ+Vh2ucBPAaadSl0OMY42KfHXxFmW+qT4uJAYuqkwqjbsyDDm0ha5QjAgxyqcvUrGBrMFi9Z7k1BfpcZUSjr/AfkChDBoUBGFWQSuJXogGJciQ== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230025)(4636009)(346002)(136003)(376002)(39860400002)(396003)(451199018)(46966006)(40470700004)(36840700001)(31686004)(36756003)(70206006)(110136005)(54906003)(82310400005)(5660300002)(41300700001)(4326008)(16576012)(8936002)(316002)(70586007)(86362001)(36860700001)(356005)(31696002)(82740400003)(81166007)(53546011)(16526019)(26005)(186003)(6666004)(426003)(44832011)(47076005)(40460700003)(40480700001)(8676002)(478600001)(2906002)(83380400001)(2616005)(336012)(36900700001)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 12:22:53.3287 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1fd81ca8-26bb-49e5-2269-08db083cdeeb X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT035.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7323 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Simon, On 2/1/23 23:54, Simon Glass wrote: > Update various build and test components to use the new schema. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > drivers/core/ofnode.c | 10 +++++----- > drivers/video/video-uclass.c | 4 ++-- > dts/Kconfig | 2 +- > include/dm/device.h | 2 +- > include/dm/ofnode.h | 10 +++++----- > scripts/Makefile.lib | 12 ++++++------ > test/dm/test-fdt.c | 2 +- > test/py/tests/test_ofplatdata.py | 8 ++++---- > tools/binman/binman.rst | 3 +-- > tools/dtoc/test_fdt.py | 8 ++++---- > 10 files changed, 30 insertions(+), 31 deletions(-) > > diff --git a/drivers/core/ofnode.c b/drivers/core/ofnode.c > index 4d56b1a7675..5249a60639b 100644 > --- a/drivers/core/ofnode.c > +++ b/drivers/core/ofnode.c > @@ -1265,22 +1265,22 @@ bool ofnode_pre_reloc(ofnode node) > { > #if defined(CONFIG_SPL_BUILD) || defined(CONFIG_TPL_BUILD) > /* for SPL and TPL the remaining nodes after the fdtgrep 1st pass > - * had property dm-pre-reloc or u-boot,dm-spl/tpl. > + * had property bootph-all or bootph-pre-sram/bootph-pre-ram. > * They are removed in final dtb (fdtgrep 2nd pass) > */ > return true; > #else > - if (ofnode_read_bool(node, "u-boot,dm-pre-reloc")) > + if (ofnode_read_bool(node, "bootph-all")) > return true; > - if (ofnode_read_bool(node, "u-boot,dm-pre-proper")) > + if (ofnode_read_bool(node, "bootph-some-ram")) > return true; > > /* > * In regular builds individual spl and tpl handling both > * count as handled pre-relocation for later second init. > */ > - if (ofnode_read_bool(node, "u-boot,dm-spl") || > - ofnode_read_bool(node, "u-boot,dm-tpl")) > + if (ofnode_read_bool(node, "bootph-pre-ram") || > + ofnode_read_bool(node, "bootph-pre-sram")) > return true; Please correct me if I am wrong but this change will likely break all boards which didn't migrate to this at this stage. And because targeting early stages people will be without console. I think we should have transition period for 1-2 releases to give people enough time to migrate. It means print big warning that they have to migrate their DTS. Thanks, Michal