From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lokesh Vutla Date: Tue, 6 Jun 2017 07:51:15 +0530 Subject: [U-Boot] [PATCH v2] arm: omap: Unify get_device_type() function In-Reply-To: <20170605134612.GG10782@bill-the-cat> References: <20170602150000.679-1-semen.protsenko@linaro.org> <20170605134612.GG10782@bill-the-cat> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Monday 05 June 2017 07:16 PM, Tom Rini wrote: > On Mon, Jun 05, 2017 at 04:00:35PM +0530, Lokesh Vutla wrote: >> >> >> On Friday 02 June 2017 08:30 PM, Sam Protsenko wrote: >>> Refactor OMAP3/4/5 code so that we have only one get_device_type() >>> function for all platforms. >>> >>> Details: >>> - Add ctrl variable for AM33xx and OMAP3 platforms (like it's done for >>> OMAP4/5), so we can obtain status register in common way >>> - For now ctrl structure for AM33xx/OMAP3 contains only status register >>> address >>> - Run hw_data_init() in order to assign ctrl to proper structure >>> - Remove DEVICE_MASK and DEVICE_GP definitions as they are not used >>> (DEVICE_TYPE_MASK and GP_DEVICE are used instead) >>> - Guard structs in omap_common.h with #ifndefs, because otherwise >>> including omap_common.h in am33xx board files breaks compilation >>> >>> Buildman script was run for all OMAP boards. Result output: >>> arm: (for 38/616 boards) >>> all +352.5 >>> bss -1.4 >>> data +3.5 >>> rodata +300.0 >>> spl/u-boot-spl:all +284.7 >>> spl/u-boot-spl:data +2.2 >>> spl/u-boot-spl:rodata +252.0 >>> spl/u-boot-spl:text +30.5 >>> text +50.4 >>> (no errors to report) >>> >>> Tested on AM57x EVM and BeagleBoard xM. >>> >>> Signed-off-by: Sam Protsenko >> >> Reviewed-by: Lokesh Vutla >> >> Will you be able to test on BeagleBoneBlack as well? > > I tested v1 of this on am335x-gp-evm. I don't have BBB in my automatic This is fine. I just want to make sure am335x is not broken :) Thanks and regards, Lokesh > lab due to how it's powered, and that I only have 1 of those USB hubs I > can control power on each port on. :( >