From: Sean Anderson <seanga2@gmail.com>
To: Simon Glass <sjg@chromium.org>, Tom Rini <trini@konsulko.com>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
Stephen Warren <swarren@nvidia.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Tom Warren <twarren@nvidia.com>
Subject: Re: [PATCH 07/25] tegra: Change #ifdef for nop
Date: Sat, 7 Oct 2023 19:21:13 -0400 [thread overview]
Message-ID: <cad8dcca-eaa5-872b-db9a-86f5438b120c@gmail.com> (raw)
In-Reply-To: <CAPnjgZ3ieXXhidSeqzMuPBCgy9UrvOt5zSMO671t1KG9zWAGxQ@mail.gmail.com>
On 10/7/23 19:10, Simon Glass wrote:
> Hi Tom.
>
> On Sun, 24 Sept 2023 at 18:43, Tom Rini <trini@konsulko.com> wrote:
>>
>> On Sun, Sep 24, 2023 at 02:39:25PM -0600, Simon Glass wrote:
>>
>>> This code is normally compiled for Tegra, but sandbox can also compile
>>> it. We should not use UNIT_TEST as a synonym for SANDBOX, since it is
>>> possible to disable UNIT_TEST for sandbox.
>>>
>>> Correct the condition.
>>>
>>> Signed-off-by: Simon Glass <sjg@chromium.org>
>>> ---
>>>
>>> include/k210/pll.h | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/include/k210/pll.h b/include/k210/pll.h
>>> index fd16a89cb203..6dd60b2eb4fc 100644
>>> --- a/include/k210/pll.h
>>> +++ b/include/k210/pll.h
>>> @@ -13,7 +13,7 @@ struct k210_pll_config {
>>> u8 od;
>>> };
>>>
>>> -#ifdef CONFIG_UNIT_TEST
>>> +#ifdef CONFIG_SANDBOX
>>> TEST_STATIC int k210_pll_calc_config(u32 rate, u32 rate_in,
>>> struct k210_pll_config *best);
>>> #ifndef nop
>>
>> Tegra? Do you mean sifive? That's where CLK_K210 stuff is... but it
>
> Oh yes, I got confused.
>
>> also seems wrong, you can run unit test on real hardware, and this is a
>> test that could (should?) be run on that platform.
>
> Only if it enables UNIT_TEST. You cannot run unit tests without that.
> The current tests are designed for sandbox.
FWIW I have run this test on actual hardware. My intent here was to allow
unit tests to access functions which would otherwise be declared static.
--Sean
next prev parent reply other threads:[~2023-10-07 23:30 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-24 20:39 [PATCH 00/25] Tidy up use of CONFIG_CMDLINE Simon Glass
2023-09-24 20:39 ` [PATCH 01/25] buildman: Use oldconfig when adjusting the config Simon Glass
2023-09-24 20:39 ` [PATCH 02/25] bootstd: Correct dependencies on CMDLINE Simon Glass
2023-09-24 20:39 ` [PATCH 03/25] autoboot: " Simon Glass
2023-09-25 0:39 ` Tom Rini
2023-10-04 2:11 ` Simon Glass
2023-10-05 14:49 ` Tom Rini
2023-09-24 20:39 ` [PATCH 04/25] cmd: Add a few more " Simon Glass
2023-09-24 20:39 ` [PATCH 05/25] treewide: Correct use of long help Simon Glass
2023-09-24 23:26 ` Tom Rini
2023-10-05 1:23 ` Simon Glass
2023-10-05 14:53 ` Tom Rini
2023-10-06 1:41 ` Simon Glass
2023-10-06 2:16 ` Tom Rini
2023-10-06 13:03 ` Simon Glass
2023-10-06 16:55 ` Tom Rini
2023-10-06 22:42 ` Simon Glass
2023-10-07 1:00 ` Tom Rini
2023-10-07 15:37 ` Simon Glass
2023-10-07 17:25 ` Tom Rini
2023-10-07 20:18 ` Simon Glass
2023-09-24 20:39 ` [PATCH 06/25] test: Make UNIT_TEST depend on CMDLINE Simon Glass
2023-09-24 20:39 ` [PATCH 07/25] tegra: Change #ifdef for nop Simon Glass
2023-09-25 0:43 ` Tom Rini
2023-10-07 23:10 ` Simon Glass
2023-10-07 23:21 ` Sean Anderson [this message]
2023-10-09 15:32 ` Simon Glass
2023-10-09 23:40 ` Sean Anderson
2023-10-10 14:42 ` Simon Glass
2023-10-11 0:03 ` Sean Anderson
2023-09-24 20:39 ` [PATCH 08/25] fastboot: Avoid depending on CMDLINE Simon Glass
2023-09-24 22:59 ` Tom Rini
2023-10-07 23:10 ` Simon Glass
2023-09-24 20:39 ` [PATCH 09/25] cli: Always build cli_getch Simon Glass
2023-09-24 20:39 ` [PATCH 10/25] cmd: Use an #ifdef around run_commandf() Simon Glass
2023-09-24 20:39 ` [PATCH 11/25] Move bootmenu_conv_key() into its own file Simon Glass
2023-09-24 20:39 ` [PATCH 12/25] armffa: Correct command help condition Simon Glass
2023-09-24 20:39 ` [PATCH 13/25] pxe: Depend on CMDLINE Simon Glass
2023-09-24 20:39 ` [PATCH 14/25] env: Split out non-command code into a new file Simon Glass
2023-09-24 20:39 ` [PATCH 15/25] console: Move SYS_PBSIZE into common/ Simon Glass
2023-09-24 20:39 ` [PATCH 16/25] bootm: Allow building when cleanup functions are missing Simon Glass
2023-09-24 20:39 ` [PATCH 17/25] fdt: Move working_fdt into fdt_support Simon Glass
2023-09-24 20:39 ` [PATCH 18/25] net: Depend on CONFIG_CMDLINE Simon Glass
2023-10-06 20:44 ` Ramon Fried
2023-09-24 20:39 ` [PATCH 19/25] log: Allow use without CONFIG_CMDLINE Simon Glass
2023-09-24 20:39 ` [PATCH 20/25] video: " Simon Glass
2023-09-24 20:39 ` [PATCH 21/25] video: Dont require the font command Simon Glass
2023-09-24 20:39 ` [PATCH 22/25] efi: Depend on CMDLINE for efi_loader Simon Glass
2023-09-24 20:39 ` [PATCH 23/25] cmd: Make all commands depend on CMDLINE Simon Glass
2023-09-24 20:39 ` [PATCH 24/25] sandbox: Avoid requiring cmdline Simon Glass
2023-09-24 20:39 ` [PATCH 25/25] sandbox: Add a test for disabling CONFIG_CMDLINE Simon Glass
2023-09-25 0:37 ` [PATCH 00/25] Tidy up use of CONFIG_CMDLINE Tom Rini
2023-10-10 14:57 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cad8dcca-eaa5-872b-db9a-86f5438b120c@gmail.com \
--to=seanga2@gmail.com \
--cc=sjg@chromium.org \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
--cc=trini@konsulko.com \
--cc=twarren@nvidia.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox