From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 037C0C43334 for ; Fri, 10 Jun 2022 16:47:35 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1C0178431E; Fri, 10 Jun 2022 18:47:33 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="R7tq4FNk"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D1F8F84286; Fri, 10 Jun 2022 18:47:31 +0200 (CEST) Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 08D12843F2 for ; Fri, 10 Jun 2022 18:47:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=alpernebiyasak@gmail.com Received: by mail-ed1-x52e.google.com with SMTP id d14so10493127eda.12 for ; Fri, 10 Jun 2022 09:47:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:from:subject:to:cc :references:content-language:in-reply-to:content-transfer-encoding; bh=tCUfa8pQgtmc6mfryvF5jwgzCGk1QBOuTRrrh/4QP8A=; b=R7tq4FNkZHkZlnVx4GeOpWOccCgOQPssPPKCgOukI5I+Kcfg57CZajw7uXyeZ+8p5v w0NodRSvRa2QjM0r/DBaK0m0fcak+sfx1IVqR+pPQ+4fXD4V1cHeK9o0c9mwkhF3Crpw a5Zi+Ury9UVbkdnEbr9pCRjmyAC2hnUkgKDCWFgjoyeKMnavwxQ7cjwpk11/gYxnUtaF un34SKdYK7Yu/vFpYT6kSTDLIQdjViq4vLl3bIEVHXffgqzZnZtC7YKOzD8VIVzvF9PC pRs4Fp0tozF8zEPFiO6gwZirXm98k6Kup4puDw1ujb0qMu6A7P0BtIfrFR1tL5SePrLB x01Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:from :subject:to:cc:references:content-language:in-reply-to :content-transfer-encoding; bh=tCUfa8pQgtmc6mfryvF5jwgzCGk1QBOuTRrrh/4QP8A=; b=uB69KI6hf4opUux++XBKpzw/dykmzo7S4nYU3WgNBWIdolCdag2a/WdPeuUhSP/tu6 4wCFPigdOTqhjGcsByPPeCcPbUyX7chpOJDt2R1MhgAQU+LoOPYX+opo49Y10npfA5kl +j5ZVSSOYeKV27JlQlMXwuRnOcHJiB8KZQXjvm0ZGtLens15NqFGvifUCEAuWkWyfFVB 2aJDOmONWhDfNkGGDrzF2Hb9tm0yVxCS/6y8nn6xBMnskuApWTBIU7diCqa/gnyRD5sb 32Mq6ERLSnFYVZzHNFAP8jcRbx+DkVN4SYlufYKbuGi6vTq0U+usM2KU9z+jSp3O3S8L GH0w== X-Gm-Message-State: AOAM532KSYMx861MA1o3uDIUxOpdUnR3MojBDeFPJyAnftKJkoq5bJHD i7dVBlmgyUP9Ybk97YdigA4= X-Google-Smtp-Source: ABdhPJwB1a6wVMzsPwhicXwNcbuG68hqzL65nhrs2yfJz+nJlaqM5drWeAsWEsWOTZrkqs9uZeg9UQ== X-Received: by 2002:a05:6402:528a:b0:42d:e116:fab8 with SMTP id en10-20020a056402528a00b0042de116fab8mr50904414edb.134.1654879648442; Fri, 10 Jun 2022 09:47:28 -0700 (PDT) Received: from [192.168.0.74] ([178.233.178.185]) by smtp.gmail.com with ESMTPSA id h15-20020a170906110f00b006fe98c7c7a9sm12337111eja.85.2022.06.10.09.47.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jun 2022 09:47:27 -0700 (PDT) Message-ID: Date: Fri, 10 Jun 2022 19:47:16 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 From: Alper Nebi Yasak Subject: Re: [PATCH 7/8] binman_sym: guard with CONFIG_IS_ENABLED(BINMAN_SYMBOLS) To: "Peng Fan (OSS)" Cc: u-boot@lists.denx.de, Peng Fan , Tim Harvey , sbabic@denx.de, festevam@gmail.com, trini@konsulko.com, Simon Glass References: <20220603071715.15212-1-peng.fan@oss.nxp.com> <20220603071715.15212-8-peng.fan@oss.nxp.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 04/06/2022 14:50, Alper Nebi Yasak wrote: > On 03/06/2022 10:17, Peng Fan (OSS) wrote: >> From: Peng Fan >> >> There is case that CONFIG_BINMAN is defined, but >> CONFIG_SPL_BINMAN_SYMBOLS is not defined. In that case, there will be >> build failure. So use CONFIG_SPL_BINMAN_SYMBOLS to guard the macros, and >> define CONFIG_SPL_BINMAN_SYMBOLS in binman syms test. >> >> Tested-by: Tim Harvey #imx8m[m,n,p]-venice >> Signed-off-by: Peng Fan >> --- >> include/binman_sym.h | 2 +- >> tools/binman/test/Makefile | 2 +- >> tools/binman/test/generated/autoconf.h | 3 +++ >> tools/binman/test/u_boot_binman_syms.c | 2 +- >> tools/binman/test/u_boot_binman_syms_size.c | 2 +- >> 5 files changed, 7 insertions(+), 4 deletions(-) >> create mode 100644 tools/binman/test/generated/autoconf.h > > Reviewed-by: Alper Nebi Yasak Looks like I have misunderstood things here a bit. CONFIG_BINMAN enables you to declare and use symbols. CONFIG_SPL/TPL_BINMAN_SYMBOLS declares certain symbols ('u_boot_any'). The name is a bit misleading, as if it enables support for using symbols, and that confused me. I have sent a patch [1] that fixes the build error mentioned here, which should be used instead of this patch. Please: - Rebase on top of that series [1] - Maybe drop config changes in 1/8 and 2/8 (they're now unnecessary) - Disable CONFIG_SPL/TPL/VPL_BINMAN_SYMBOLS for i.MX8M boards - Change the if statement to if (IS_ENABLED(CONFIG_BINMAN)) in patch 5/8 - Drop this patch 7/8 Sorry for the confusion. [1] spl: binman: Fix use of undeclared u_boot_any symbols https://lore.kernel.org/u-boot/20220610105806.27177-2-alpernebiyasak@gmail.com/