public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Dalon L Westergreen <dalon.westergreen@linux.intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: socfpga: Build sfp image only for Gen5 and Arria10 devices
Date: Wed, 20 Mar 2019 12:05:04 -0700	[thread overview]
Message-ID: <cb460112d07270ea112729cc035a4eee7c5de435.camel@linux.intel.com> (raw)
In-Reply-To: <13089c2b-2b6f-c832-aac7-99de36426949@denx.de>

On Wed, 2019-03-20 at 18:09 +0100, Marek Vasut wrote:
> On 3/20/19 4:40 PM, Dalon Westergreen wrote:
> > From: Dalon Westergreen <dalon.westergreen@intel.com>
> > 
> > The sfp file is only valid for Gen5 (Cyclone5 & Arria5) and Arria10
> > devices.  The file should only be built for these devices.
> > 
> > Signed-off-by: Dalon Westergreen <dalon.westergreen@intel.com>
> > ---
> >  Kconfig              | 3 ++-
> >  scripts/Makefile.spl | 6 +++++-
> >  2 files changed, 7 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Kconfig b/Kconfig
> > index 512c7beb89..305b265ed7 100644
> > --- a/Kconfig
> > +++ b/Kconfig
> > @@ -226,7 +226,8 @@ config BUILD_ROM
> >  
> >  config BUILD_TARGET
> >  	string "Build target special images"
> > -	default "u-boot-with-spl.sfp" if ARCH_SOCFPGA
> > +	default "u-boot-with-spl.sfp" if TARGET_SOCFPGA_ARRIA10
> > +	default "u-boot-with-spl.sfp" if TARGET_SOCFPGA_GEN5
> >  	default "u-boot-spl.kwb" if ARCH_MVEBU && SPL
> >  	default "u-boot-elf.srec" if RCAR_GEN3
> >  	default "u-boot.itb" if SPL_LOAD_FIT && ARCH_SUNXI
> > diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl
> > index 9d5921606e..592c5dfe57 100644
> > --- a/scripts/Makefile.spl
> > +++ b/scripts/Makefile.spl
> > @@ -212,7 +212,11 @@ ifdef CONFIG_SAMSUNG
> >  ALL-y	+= $(obj)/$(BOARD)-spl.bin
> >  endif
> >  
> > -ifdef CONFIG_ARCH_SOCFPGA
> > +ifdef CONFIG_TARGET_SOCFPGA_ARRIA10
> 
> ifneq ($(CONFIG_TARGET_SOCFPGA_GEN5)$(CONFIG_TARGET_SOCFPGA_ARRIA10),)
> ALL-y ...
> endif
> 
> Then you don't need to duplicate the entry.

sure thing.
> 
> > +ALL-y	+= $(obj)/$(SPL_BIN).sfp
> > +endif
> > +
> > +ifdef CONFIG_TARGET_SOCFPGA_GEN5
> >  ALL-y	+= $(obj)/$(SPL_BIN).sfp
> >  endif
> >  
> > 
> 
> 

      reply	other threads:[~2019-03-20 19:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-20 15:40 [U-Boot] [PATCH] ARM: socfpga: Build sfp image only for Gen5 and Arria10 devices Dalon Westergreen
2019-03-20 17:09 ` Marek Vasut
2019-03-20 19:05   ` Dalon L Westergreen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb460112d07270ea112729cc035a4eee7c5de435.camel@linux.intel.com \
    --to=dalon.westergreen@linux.intel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox