From: Jaehoon Chung <jh80.chung@gmail.com>
To: Simon Glass <sjg@chromium.org>, Jaehoon Chung <jh80.chung@samsung.com>
Cc: Alper Nebi Yasak <alpernebiyasak@gmail.com>,
U-Boot Mailing List <u-boot@lists.denx.de>,
Jack Mitchell <ml@embed.me.uk>,
Kever Yang <kever.yang@rock-chips.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Yifeng Zhao <yifeng.zhao@rock-chips.com>,
Samuel Dionne-Riel <samuel@dionne-riel.com>,
Aswath Govindraju <a-govindraju@ti.com>,
Philipp Tomsich <philipp.tomsich@vrull.eu>,
Ashok Reddy Soma <ashok.reddy.soma@xilinx.com>,
Stephen Carlson <stcarlso@linux.microsoft.com>,
Michal Simek <michal.simek@xilinx.com>,
Faiz Abbas <faiz_abbas@ti.com>,
Jagan Teki <jagan@amarulasolutions.com>,
Peng Fan <peng.fan@nxp.com>,
Peter Robinson <pbrobinson@gmail.com>
Subject: Re: [PATCH v4 4/4] rockchip: sdhci: Add HS400 Enhanced Strobe support for RK3568
Date: Thu, 3 Mar 2022 17:29:53 +0900 [thread overview]
Message-ID: <cc017f16-fa64-10e7-5d90-ffe3d856f457@gmail.com> (raw)
In-Reply-To: <CAPnjgZ1t1x94vO08cgJ_f7bC_HLNmWd668972NDe9U5LRx3vRA@mail.gmail.com>
Hi Simon,
On 2/27/22 03:36, Simon Glass wrote:
> Hi Jaehoon,
>
> On Tue, 8 Feb 2022 at 16:42, Jaehoon Chung <jh80.chung@samsung.com> wrote:
>> On 1/29/22 07:42, Alper Nebi Yasak wrote:
>>> On RK3568, a register bit must be set to enable Enhanced Strobe.
>>> However, it appears that the address of this register may differ from
>>> vendor to vendor and should be read from the underlying MMC IP. Let the
>>> Rockchip SDHCI driver read this address and set the relevant bit when
>>> Enhanced Strobe configuration is requested.
>>>
>>> Additionally, a bit signifying that the connected hardware is an eMMC
>>> chip must be set to enable Data Strobe for HS400 and HS400ES modes. Also
>>> make the driver set this bit as appropriate.
>>>
>>> This is partly ported from Linux's Synopsys DWC MSHC driver which
>>> happens to be the underlying IP. (drivers/mmc/host/sdhci-of-dwcmshc.c in
>>> Linux tree).
>>>
>>> Signed-off-by: Alper Nebi Yasak <alpernebiyasak@gmail.com>
>> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
>>
>> As you mentioned, if someone test this on RK3568 board, it will be more better.
> That does not seem to have happened, but it will likely happen when it
> is applied.
Agreed. I will apply this on u-boot-mmc.
Best Regards,
Jaehoon Chung
>
> Regards,
> Simon
prev parent reply other threads:[~2022-03-03 8:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 22:42 [PATCH v4 0/4] rockchip: sdhci: Fix reinit and add HS400 Enhanced Strobe support Alper Nebi Yasak
2022-01-28 22:42 ` [PATCH v4 1/4] mmc: sdhci: Add " Alper Nebi Yasak
2022-01-28 22:42 ` [PATCH v4 2/4] rockchip: sdhci: Fix RK3399 eMMC PHY power cycling Alper Nebi Yasak
2022-02-26 18:36 ` Simon Glass
2022-03-14 18:14 ` Tom Rini
2022-01-28 22:42 ` [PATCH v4 3/4] rockchip: sdhci: Add HS400 Enhanced Strobe support for RK3399 Alper Nebi Yasak
2022-02-08 23:39 ` Jaehoon Chung
2022-01-28 22:42 ` [PATCH v4 4/4] rockchip: sdhci: Add HS400 Enhanced Strobe support for RK3568 Alper Nebi Yasak
2022-02-08 23:43 ` Jaehoon Chung
2022-02-26 18:36 ` Simon Glass
2022-03-03 8:29 ` Jaehoon Chung [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc017f16-fa64-10e7-5d90-ffe3d856f457@gmail.com \
--to=jh80.chung@gmail.com \
--cc=a-govindraju@ti.com \
--cc=alpernebiyasak@gmail.com \
--cc=ashok.reddy.soma@xilinx.com \
--cc=faiz_abbas@ti.com \
--cc=jagan@amarulasolutions.com \
--cc=jh80.chung@samsung.com \
--cc=kever.yang@rock-chips.com \
--cc=michal.simek@xilinx.com \
--cc=ml@embed.me.uk \
--cc=pbrobinson@gmail.com \
--cc=peng.fan@nxp.com \
--cc=philipp.tomsich@vrull.eu \
--cc=samuel@dionne-riel.com \
--cc=sjg@chromium.org \
--cc=stcarlso@linux.microsoft.com \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
--cc=yifeng.zhao@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox