From: Kever Yang <kever.yang@rock-chips.com>
To: Jonas Karlman <jonas@kwiboo.se>, Simon Glass <sjg@chromium.org>,
Philipp Tomsich <philipp.tomsich@vrull.eu>,
Tom Rini <trini@konsulko.com>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH 02/11] rockchip: Remove partitions env variable for RK356x
Date: Tue, 8 Apr 2025 11:18:59 +0800 [thread overview]
Message-ID: <cc536f72-c95e-42ae-8d48-bf9dabbf3a80@rock-chips.com> (raw)
In-Reply-To: <20250406002447.1555596-3-jonas@kwiboo.se>
On 2025/4/6 08:24, Jonas Karlman wrote:
> The partitions env variable is using an outdated partition layout that
> is typically expected to be used with older vendor miniloader blobs.
>
> Rockchip devices will run fine using any partition layout if the first
> 16 MiB of MMC storage is ignored/skipped.
>
> Remove the partitions env variable to stop encourage users a continued
> use of this outdated partition layout on RK356x devices.
>
> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
Thanks,
- Kever
> ---
> include/configs/rk3568_common.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/configs/rk3568_common.h b/include/configs/rk3568_common.h
> index 09b7b71c6afd..a68ca381db57 100644
> --- a/include/configs/rk3568_common.h
> +++ b/include/configs/rk3568_common.h
> @@ -29,7 +29,6 @@
>
> #define CFG_EXTRA_ENV_SETTINGS \
> "fdtfile=" CONFIG_DEFAULT_FDT_FILE "\0" \
> - "partitions=" PARTS_DEFAULT \
> ENV_MEM_LAYOUT_SETTINGS \
> ROCKCHIP_DEVICE_SETTINGS \
> "boot_targets=" BOOT_TARGETS "\0"
next prev parent reply other threads:[~2025-04-08 3:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-06 0:24 [PATCH 00/11] rockchip: Small cleanups for RK356x and RK3588 Jonas Karlman
2025-04-06 0:24 ` [PATCH 01/11] rockchip: rk3588: Use hptimer reg names in rockchip_stimer_init Jonas Karlman
2025-04-08 3:17 ` Kever Yang
2025-04-06 0:24 ` [PATCH 02/11] rockchip: Remove partitions env variable for RK356x Jonas Karlman
2025-04-08 3:18 ` Kever Yang [this message]
2025-04-06 0:24 ` [PATCH 03/11] rockchip: Remove partitions env variable for RK3588 Jonas Karlman
2025-04-08 3:19 ` Kever Yang
2025-04-06 0:24 ` [PATCH 04/11] rockchip: Ensure device settings is defined before rk3568_common.h Jonas Karlman
2025-04-08 3:19 ` Kever Yang
2025-04-06 0:24 ` [PATCH 05/11] rockchip: Ensure device settings is defined before rk3588_common.h Jonas Karlman
2025-04-08 3:19 ` Kever Yang
2025-04-06 0:24 ` [PATCH 06/11] rockchip: Use rk3568_common.h by default for RK356x boards Jonas Karlman
2025-04-08 3:19 ` Kever Yang
2025-04-06 0:24 ` [PATCH 07/11] rockchip: Use rk3588_common.h by default for RK3588 boards Jonas Karlman
2025-04-08 3:19 ` Kever Yang
2025-04-06 0:24 ` [PATCH 08/11] rockchip: rk3568: Drop BOARD_LATE_INIT from target config Jonas Karlman
2025-04-08 3:19 ` Kever Yang
2025-04-06 0:24 ` [PATCH 09/11] rockchip: rk3588: " Jonas Karlman
2025-04-08 3:20 ` Kever Yang
2025-04-06 0:24 ` [PATCH 10/11] rockchip: Enable meminfo and rng commands for Generic RK3566/RK3568 Jonas Karlman
2025-04-08 3:20 ` Kever Yang
2025-04-06 0:24 ` [PATCH 11/11] rockchip: Enable meminfo and rng commands for Generic RK3588 Jonas Karlman
2025-04-08 3:20 ` Kever Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc536f72-c95e-42ae-8d48-bf9dabbf3a80@rock-chips.com \
--to=kever.yang@rock-chips.com \
--cc=jonas@kwiboo.se \
--cc=philipp.tomsich@vrull.eu \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox