From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0C18C6FA8A for ; Thu, 15 Sep 2022 14:38:53 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 85130847FF; Thu, 15 Sep 2022 16:38:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="sqg5rK9t"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A4F9784822; Thu, 15 Sep 2022 16:38:49 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2052.outbound.protection.outlook.com [40.107.220.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A04C88437C for ; Thu, 15 Sep 2022 16:38:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=michal.simek@amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AWh4mapFfD8Z03bwvh10aQ2xcqxFCH6HcbMhhRoRgtmVakYs4EUg57y9GITxaFLxlwjyq7Jd3197LmmTWibnhSz3yGISzxx/gbmDiPVl0FWQ57n1fNwQAoAsBC6sKNHPZ0zUY0mCqzljnWqY7j0ecw3X35TdOR6/on8RbUce+BYmGca3ezH3Ly6D1CKKvAKbHHmKY00rNyITlsw5p8UYWW27Bkn4rd8A0wLOz95TIT3N1Al1lHFqsWvtVM6sHYfAkf2QezY770QJBLMx6EEoE7yGADOuH5gEhQ4fql4fctemuS+P+s3YqD1yrptkksPAYE3z6JFOhNjAyVh5HdJlrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XbeHOXncV/25UCNBrjeocjVFpt36kqGKJ/y7A+yIggQ=; b=fVPGdIaRFektLPS6dLd6jQHVyqQtrWaNwlFqKUqlncHinNbdLyyshuMZNFfDS8xjzuVvkp1HiQlL30ErthYk+zCIP8BoReQdLVwMmmlrf9KFSonKGMyJcPZneriKKS50CYcCepTB2TpZfPPCm2Wz92XoD49sMJONRytA5tgkthkTYuMwpWYJheFV2ZMFaMuWYGVQejRLfDXMAbWdBJEJ90XBZRN0eKxL5IRH5T1YrFkJzFhtEyKTK/xLtR3Wyu7iF3xTjMJxIQtyeZ4Ei52kBN4LTYBF0nTTUlF+Iy2r5rl0XvfoCjPS7jiXP0m0BxsSQ62HuIRqEJL8Zx9RFzrcYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=quicinc.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XbeHOXncV/25UCNBrjeocjVFpt36kqGKJ/y7A+yIggQ=; b=sqg5rK9t6i04vjJTWkz7vpw6SQGuPNtQz9pVdgMrB+xZTOjZYD3nng7600BGnBRMm0+Mw/ARGh48td0hurhhE1arr+1xHDjA0Sr4Xq5CPUuFBEZaq+ot7mTmZ6uNzhDNC4eoIPLTF0xrwkOgXPrbP2bVdN6lwN8fEgvSQg1XBdg= Received: from MW4PR03CA0157.namprd03.prod.outlook.com (2603:10b6:303:8d::12) by SJ0PR12MB6926.namprd12.prod.outlook.com (2603:10b6:a03:485::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Thu, 15 Sep 2022 14:38:40 +0000 Received: from CO1NAM11FT111.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8d:cafe::65) by MW4PR03CA0157.outlook.office365.com (2603:10b6:303:8d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.16 via Frontend Transport; Thu, 15 Sep 2022 14:38:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT111.mail.protection.outlook.com (10.13.174.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5632.12 via Frontend Transport; Thu, 15 Sep 2022 14:38:40 +0000 Received: from [10.254.241.52] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 15 Sep 2022 09:38:34 -0500 Message-ID: Date: Thu, 15 Sep 2022 16:38:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v4 0/6] cmd/fru: move FRU handling support to common region Content-Language: en-US To: Jae Hyun Yoo , Ovidiu Panait , Simon Glass , Mario Six , Masahisa Kojima , =?UTF-8?Q?Pali_Roh=c3=a1r?= , Heinrich Schuchardt , Ashok Reddy Soma , Thomas Huth , Huang Jianan , Chris Morgan , Roland Gaudig , Patrick Delaunay , Alexandru Gagniuc CC: Jamie Iles , Graeme Gregory , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , References: <20220825164245.1606958-1-quic_jaehyoo@quicinc.com> From: Michal Simek In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT111:EE_|SJ0PR12MB6926:EE_ X-MS-Office365-Filtering-Correlation-Id: 8d0996be-4770-477d-dbad-08da9727fb55 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: e6wb3JuC3rim6lg05kQpACX2d09j0kTsOjiTI8GyNH5WGKu6v2N1kIIwZTdJbTihdP6hxS14dpXpC0OkWZFciQu6WCEnkXZ8ZDVYNfN8PXp+8/Jr+bZVlmcKNLtbWdcXlmSwpf81uq9GPjxOo1f2FZrm+vPQcMoJ3a3GiHdHKcSLTy+E96qywB8Y7szXN0JnApj6+LKEjuvNyUwEYZxINPRZKStcFIa/x4O92ZvFK2BmSX44wjHyFXY8prcKs+BodTc/N0FKt2VypqM7egIidkJKrqfKkQngetMJSiOAoV1hGhg4Por5XEyyYk9M1DWdLt5RWOXfGTv2xviGcUa8qIebQG3gjChQ6Sune/NBRkgPc4xX52qMJBfkf0EVs4qnSi6+qLnElz+g4eA475K5xx60xB4r+atgB7S/peOEvm0rJVpnWlm0OHn6/w+xq3/9dtDTztnvFYCC9ng64ZVvqyhaOXLiVSpKItrMs7qJgTCOYY8nHJtrJ9o1lfgyXwuuEcipWwcD7ttU23lirgjjcYL/4wu0F0v9qNpvv767nwgum9WLO/2Y2XWcMl4s4rxweMHDNKYBSZM1kqqejImlfTCVcADOgffTqH9TTNjjC/eDFMSYhje+ChPijOOem8+UUcrgsxB0bBlZlXwU4kvCWb7ZIR8UcDQEtWtCSNszXY1N1NNTPT9W0s3RQwEL2yAW3NNwyGmoC24QLzRmOejm+1wGhr01HjRqXmvxu8MT24TMJ4KkAVHXs2pw6WX7733cHbF2cH6/DaluzI13feE0/VMAllCVsFl4WsHTlzg8TEKmu6uISFOCllMAzH4IzoXHQWKGCzL3yvVfVbGIbtGSdvrq7PCwxNTN4PyqzyXY2GA= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230022)(4636009)(396003)(39860400002)(136003)(346002)(376002)(451199015)(40470700004)(36840700001)(36756003)(8936002)(16576012)(316002)(5660300002)(31686004)(86362001)(70206006)(2616005)(31696002)(478600001)(8676002)(70586007)(82740400003)(4326008)(356005)(2906002)(6666004)(921005)(7416002)(82310400005)(26005)(32650700002)(81166007)(54906003)(36860700001)(40460700003)(110136005)(44832011)(426003)(53546011)(186003)(336012)(41300700001)(83380400001)(16526019)(40480700001)(43740500002)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2022 14:38:40.0698 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8d0996be-4770-477d-dbad-08da9727fb55 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT111.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6926 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 9/15/22 16:01, Jae Hyun Yoo wrote: > Gentle ping for this series. > > On 8/25/2022 9:42 AM, Jae Hyun Yoo wrote: >> Hello, >> >> The FRU handling was added as a Xilinx board dependent support but it >> is also useful for other boards, so this commit moves the FRU handling >> support to the common region so that it can be enabled by CONFIG_CMD_FRU. >> >> To provide manufacturer specific custom info fields and multi-records >> parsing, it refactors the FRU handling logic using linked list so that each >> board support can utilize them in their own custom way. This series adds >> 'Product Info' parsing support, usage document and unit test script too. >> >> Please review! >> >> Thanks, >> Jae >> >> Graeme Gregory (1): >>    cmd: fru: move FRU handling support to common region >> >> Jae Hyun Yoo (5): >>    xilinx: common: refactor FRU handling support >>    cmd: fru: fix a sandbox segfault issue >>    cmd: fru: add product info area parsing support >>    doc: fru: add documentation for the fru command and APIs >>    test: cmd: fru: add unit test for the fru command >> >>   board/xilinx/Kconfig               |   8 - >>   board/xilinx/common/Makefile       |   3 - >>   board/xilinx/common/board.c        |  68 ++- >>   board/xilinx/common/fru.h          | 108 ----- >>   board/xilinx/common/fru_ops.c      | 415 ----------------- >>   cmd/Kconfig                        |   8 + >>   cmd/Makefile                       |   1 + >>   {board/xilinx/common => cmd}/fru.c |  54 ++- >>   doc/usage/cmd/fru.rst              | 144 ++++++ >>   doc/usage/index.rst                |   1 + >>   include/fru.h                      | 328 +++++++++++++ >>   include/test/suites.h              |   1 + >>   lib/Makefile                       |   1 + >>   lib/fru_ops.c                      | 724 +++++++++++++++++++++++++++++ >>   test/cmd/Makefile                  |   1 + >>   test/cmd/fru.c                     |  84 ++++ >>   test/cmd_ut.c                      |   6 + >>   17 files changed, 1398 insertions(+), 557 deletions(-) >>   delete mode 100644 board/xilinx/common/fru.h >>   delete mode 100644 board/xilinx/common/fru_ops.c >>   rename {board/xilinx/common => cmd}/fru.c (50%) >>   create mode 100644 doc/usage/cmd/fru.rst >>   create mode 100644 include/fru.h >>   create mode 100644 lib/fru_ops.c >>   create mode 100644 test/cmd/fru.c >> Will look soon. Was busy with other stuff. Sorry for delay. M