Re: [PATCH V5 04/13] drivers: video: Makefile: Rule to compile necessary video driver files

Devarsh Thakkar
2023-04-03T10:51:51Z

Hi Nikhil,

On 03/04/23 13:44, Nikhil M Jain wrote:
> To enable video driver at SPL, need to compile video-uclass,
> vidconsole-uclass, backlight-uclass, panel-uclass, simple-panel, add
> rules to compile them at SPL only. To support splash_display at SPL,
> need to compile video-bmp, add rule to compile at SPL stage.
>
> Signed-off-by: Nikhil M Jain <n-jain1@ti.com>
Reviewed-by: Devarsh Thakkar <devarsht@ti.com>

Regards
Devarsh

> ---
> V5:
> - Use $(SPL_TPL_) to check for stage specific configs and compile at
> specific stages.
> - Removed ifdef CONFIG_SPL_BUILD
>
> V4:
> - No change
>
> V3:
> - Rule to compile backlight, console and panel files
> - Not added Reiewed-by tag due to changes
>
> V2:
> - No change
>
> drivers/video/Makefile | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/video/Makefile b/drivers/video/Makefile
> index cb3f373645..bb139f550c 100644
> --- a/drivers/video/Makefile
> +++ b/drivers/video/Makefile
> @@ -4,12 +4,12 @@
> # Wolfgang Denk, DENX Software Engineering, wd@denx.de.
>
> ifdef CONFIG_DM
> -obj-$(CONFIG_BACKLIGHT) += backlight-uclass.o
> +obj-$(CONFIG_$(SPL_TPL_)BACKLIGHT) += backlight-uclass.o
> obj-$(CONFIG_BACKLIGHT_GPIO) += backlight_gpio.o
> obj-$(CONFIG_BACKLIGHT_PWM) += pwm_backlight.o
> -obj-$(CONFIG_CONSOLE_NORMAL) += console_normal.o
> +obj-$(CONFIG_$(SPL_TPL)CONSOLE_NORMAL) += console_normal.o
> obj-$(CONFIG_CONSOLE_ROTATION) += console_rotate.o
> -ifdef CONFIG_CONSOLE_NORMAL
> +ifdef CONFIG_$(SPL_TPL_)CONSOLE_NORMAL
> obj-y += console_core.o
> else ifdef CONFIG_CONSOLE_ROTATION
> obj-y += console_core.o
> @@ -18,9 +18,9 @@ obj-$(CONFIG_CONSOLE_ROTATION) += console_core.o
> obj-$(CONFIG_CONSOLE_TRUETYPE) += console_truetype.o fonts/
> obj-$(CONFIG_DISPLAY) += display-uclass.o
> obj-$(CONFIG_VIDEO_MIPI_DSI) += dsi-host-uclass.o
> -obj-$(CONFIG_VIDEO) += video-uclass.o vidconsole-uclass.o
> -obj-$(CONFIG_VIDEO) += video_bmp.o
> -obj-$(CONFIG_PANEL) += panel-uclass.o
> +obj-$(CONFIG_$(SPL_TPL_)VIDEO) += video-uclass.o vidconsole-uclass.o
> +obj-$(CONFIG_$(SPL_TPL_)VIDEO) += video_bmp.o
> +obj-$(CONFIG_$(SPL_TPL_)PANEL) += panel-uclass.o
> obj-$(CONFIG_PANEL_HX8238D) += hx8238d.o
> obj-$(CONFIG_SIMPLE_PANEL) += simple_panel.o
>