U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@amd.com>
To: Varadarajan Narayanan <quic_varada@quicinc.com>,
	caleb.connolly@linaro.org, neil.armstrong@linaro.org,
	sumit.garg@kernel.org, trini@konsulko.com,
	joe.hershberger@ni.com, marek.vasut+renesas@mailbox.org,
	cniedermaier@dh-electronics.com, xypron.glpk@gmx.de,
	sjg@chromium.org, u-boot-qcom@groups.io, u-boot@lists.denx.de
Subject: Re: [PATCH v1 3/3] configs: qcs9100: Enable env in UFS
Date: Mon, 7 Apr 2025 08:26:04 +0200	[thread overview]
Message-ID: <cdf0abbf-38ce-4452-a58d-54da7549de73@amd.com> (raw)
In-Reply-To: <20250401080015.1470999-4-quic_varada@quicinc.com>



On 4/1/25 10:00, Varadarajan Narayanan wrote:
> Enable CONFIG_ENV_IS_IN_UFS to store environment variables in UFS.
> Set env variables partition name as 'ubootenv'.
> 
> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
> ---
>   configs/qcs9100_defconfig | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/configs/qcs9100_defconfig b/configs/qcs9100_defconfig
> index 10ff4d25398..d56f08f0ad0 100644
> --- a/configs/qcs9100_defconfig
> +++ b/configs/qcs9100_defconfig
> @@ -14,5 +14,9 @@ CONFIG_DEBUG_UART_CLOCK=14745600
>   # Address where U-Boot will be loaded
>   CONFIG_TEXT_BASE=0xaf000000
>   CONFIG_REMAKE_ELF=y
> +CONFIG_ENV_IS_IN_UFS=y
> +CONFIG_SYS_UFS_ENV_PART="ubootenv"
>   
>   CONFIG_DEFAULT_DEVICE_TREE="qcom/qcs9100-ride-r3"
> +# CONFIG_ENV_IS_DEFAULT is not set
> +# CONFIG_ENV_IS_NOWHERE is not set


That newline in the middle is weird.
You should start to use
make savedefconfig
cp defconfig configs/qcs9100_defconfig

to have it aligned with Kconfig layout.

M

  reply	other threads:[~2025-04-07  6:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-01  8:00 [PATCH v1 0/3] Enable env in UFS Varadarajan Narayanan
2025-04-01  8:00 ` [PATCH v1 1/3] scsi: Implement get_blk() function Varadarajan Narayanan
2025-04-01 16:29   ` Heinrich Schuchardt
2025-04-02 15:56     ` Varadarajan Narayanan
2025-04-01  8:00 ` [PATCH v1 2/3] env: Add support for storing env variables in UFS Varadarajan Narayanan
2025-04-01  8:00 ` [PATCH v1 3/3] configs: qcs9100: Enable env " Varadarajan Narayanan
2025-04-07  6:26   ` Michal Simek [this message]
2025-04-01 14:10 ` [PATCH v1 0/3] " Tom Rini
2025-04-01 14:37   ` neil.armstrong
2025-05-06  7:29     ` Varadarajan Narayanan
2025-05-06 13:32       ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cdf0abbf-38ce-4452-a58d-54da7549de73@amd.com \
    --to=michal.simek@amd.com \
    --cc=caleb.connolly@linaro.org \
    --cc=cniedermaier@dh-electronics.com \
    --cc=joe.hershberger@ni.com \
    --cc=marek.vasut+renesas@mailbox.org \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_varada@quicinc.com \
    --cc=sjg@chromium.org \
    --cc=sumit.garg@kernel.org \
    --cc=trini@konsulko.com \
    --cc=u-boot-qcom@groups.io \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox