From: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
To: Masahisa Kojima <masahisa.kojima@linaro.org>
Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>, u-boot@lists.denx.de
Subject: Re: [PATCH v2 1/2] eficonfig: carve out efi_get_next_variable_name_int calls
Date: Mon, 19 Dec 2022 21:08:38 +0000 [thread overview]
Message-ID: <ce22a451-e039-2558-a7fd-75fda12960ae@canonical.com> (raw)
In-Reply-To: <20221219023314.23959-2-masahisa.kojima@linaro.org>
On 12/19/22 02:33, Masahisa Kojima wrote:
> To retrieve the EFI variable name by efi_get_next_variable_name_int(),
> the sequence of alloc -> efi_get_next_variable_name_int ->
> realloc -> efi_get_next_variable_name_int is required.
> In current code, this sequence repeatedly appears in
> the several functions. It should be curved out a common function.
>
> This commit also fixes the missing free() of var_name16
> in eficonfig_delete_invalid_boot_option().
>
> Signed-off-by: Masahisa Kojima <masahisa.kojima@linaro.org>
Reviewed-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
next prev parent reply other threads:[~2022-12-19 21:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 2:33 [PATCH v2 0/2] fix eficonfig GetNextVariableName calls handling Masahisa Kojima
2022-12-19 2:33 ` [PATCH v2 1/2] eficonfig: carve out efi_get_next_variable_name_int calls Masahisa Kojima
2022-12-19 21:08 ` Heinrich Schuchardt [this message]
2022-12-20 6:44 ` Ilias Apalodimas
2022-12-19 2:33 ` [PATCH v2 2/2] eficonfig: avoid SetVariable between GetNextVariableName calls Masahisa Kojima
2022-12-19 21:18 ` Heinrich Schuchardt
2022-12-20 6:45 ` Ilias Apalodimas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce22a451-e039-2558-a7fd-75fda12960ae@canonical.com \
--to=heinrich.schuchardt@canonical.com \
--cc=ilias.apalodimas@linaro.org \
--cc=masahisa.kojima@linaro.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox