From: Etienne CARRIERE - foss <etienne.carriere@foss.st.com>
To: AKASHI Takahiro <takahiro.akashi@linaro.org>,
"trini@konsulko.com" <trini@konsulko.com>,
"sjg@chromium.org" <sjg@chromium.org>
Cc: Etienne CARRIERE <etienne.carriere@st.com>,
"u-boot@lists.denx.de" <u-boot@lists.denx.de>
Subject: Re: [PATCH v5 01/16] scmi: refactor the code to hide a channel from devices
Date: Thu, 5 Oct 2023 07:07:04 +0000 [thread overview]
Message-ID: <ce9ab6f7e46248dbbb5cde4340e3d74e@foss.st.com> (raw)
In-Reply-To: <20230926065750.734440-2-takahiro.akashi@linaro.org>
> From: U-Boot <u-boot-bounces@lists.denx.de> on behalf of AKASHI Takahiro <takahiro.akashi@linaro.org>
> Sent: Tuesday, September 26, 2023 8:57 AM
>
> The commit 85dc58289238 ("firmware: scmi: prepare uclass to pass channel
> reference") added an explicit parameter, channel, but it seems to make
> the code complex.
>
> Hiding this parameter will allow for adding a generic (protocol-agnostic)
> helper function, i.e. for PROTOCOL_VERSION, in a later patch.
>
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> ---
> v5
> * correct the size for per_child_auto
> v4
> * revive scmi_bind_protocols which was accidentally removed
> * remove .per_child_auto from the driver declaration as it is not needed
> v3
> * fix an issue on ST board (reported by Etienne)
> by taking care of cases where probed devices are children of
> SCMI protocol device (i.e. clock devices under CCF)
> See find_scmi_protocol_device().
> * move "per_device_plato_auto" to a succeeding right patch
> v2
> * new patch
> ---
> drivers/clk/clk_scmi.c | 27 ++----
> drivers/firmware/scmi/scmi_agent-uclass.c | 105 ++++++++++++++++------
> drivers/power/regulator/scmi_regulator.c | 26 ++----
> drivers/reset/reset-scmi.c | 19 +---
> include/scmi_agent.h | 15 ++--
> 5 files changed, 104 insertions(+), 88 deletions(-)
>
Reviewed-by: Etienne Carriere <etienne.carriere@foss.st.com>
next prev parent reply other threads:[~2023-10-05 7:07 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 6:57 [PATCH v5 00/16] firmware: scmi: add SCMI base protocol support AKASHI Takahiro
2023-09-26 6:57 ` [PATCH v5 01/16] scmi: refactor the code to hide a channel from devices AKASHI Takahiro
2023-10-05 7:07 ` Etienne CARRIERE - foss [this message]
2023-09-26 6:57 ` [PATCH v5 02/16] firmware: scmi: use a protocol's own channel if assigned AKASHI Takahiro
2023-10-05 7:07 ` Etienne CARRIERE - foss
2023-09-26 6:57 ` [PATCH v5 03/16] firmware: scmi: support dummy channels for sandbox agent AKASHI Takahiro
2023-10-02 1:17 ` Simon Glass
2023-10-05 7:08 ` Etienne CARRIERE - foss
2023-09-26 6:57 ` [PATCH v5 04/16] test: dm: add protocol-specific channel test AKASHI Takahiro
2023-10-02 1:17 ` Simon Glass
2023-10-05 7:08 ` Etienne CARRIERE - foss
2023-09-26 6:57 ` [PATCH v5 05/16] firmware: scmi: implement SCMI base protocol AKASHI Takahiro
2023-10-05 7:06 ` Etienne CARRIERE - foss
2023-10-05 9:58 ` AKASHI Takahiro
2023-09-26 6:57 ` [PATCH v5 06/16] firmware: scmi: move scmi_bind_protocols() backward AKASHI Takahiro
2023-09-26 6:57 ` [PATCH v5 07/16] firmware: scmi: framework for installing additional protocols AKASHI Takahiro
2023-09-26 6:57 ` [PATCH v5 08/16] firmware: scmi: fake base protocol commands on sandbox AKASHI Takahiro
2023-09-26 6:57 ` [PATCH v5 09/16] test: dm: simplify SCMI unit test " AKASHI Takahiro
2023-09-26 6:57 ` [PATCH v5 10/16] firmware: scmi: install base protocol to SCMI agent AKASHI Takahiro
2023-09-26 6:57 ` [PATCH v5 11/16] firmware: scmi: add a check against availability of protocols AKASHI Takahiro
2023-10-02 1:17 ` Simon Glass
2023-09-26 6:57 ` [PATCH v5 12/16] sandbox: remove SCMI base node definition from test.dts AKASHI Takahiro
2023-09-26 6:57 ` [PATCH v5 13/16] test: dm: add SCMI base protocol test AKASHI Takahiro
2023-10-02 1:17 ` Simon Glass
2023-09-26 6:57 ` [PATCH v5 14/16] cmd: add scmi command for SCMI firmware AKASHI Takahiro
2023-10-24 8:27 ` Michal Simek
2023-10-24 22:24 ` Tom Rini
2023-10-25 1:14 ` AKASHI Takahiro
2023-09-26 6:57 ` [PATCH v5 15/16] doc: cmd: add documentation for scmi AKASHI Takahiro
2023-10-10 14:19 ` Tom Rini
2023-10-11 1:22 ` AKASHI Takahiro
2023-09-26 6:57 ` [PATCH v5 16/16] test: dm: add scmi command test AKASHI Takahiro
2023-10-10 14:19 ` [PATCH v5 00/16] firmware: scmi: add SCMI base protocol support Tom Rini
2023-10-11 1:36 ` AKASHI Takahiro
2023-10-11 2:11 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce9ab6f7e46248dbbb5cde4340e3d74e@foss.st.com \
--to=etienne.carriere@foss.st.com \
--cc=etienne.carriere@st.com \
--cc=sjg@chromium.org \
--cc=takahiro.akashi@linaro.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox