public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 07/12] usb: eth: r8152_fw: fix indentation
Date: Wed, 16 Nov 2016 12:20:04 +0100	[thread overview]
Message-ID: <cee335fb-01ac-37db-a2a4-9404e4604f41@denx.de> (raw)
In-Reply-To: <1479257416-29389-8-git-send-email-andre.przywara@arm.com>

On 11/16/2016 01:50 AM, Andre Przywara wrote:
> Apparently the indentation is wrong here, fix this to avoid compiler
> warnings and puzzled readers.
> 
> Pointed out by GCC 6.2's -Wmisleading-indentation warning.
> 
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>

Reviewed-by: Marek Vasut <marex@denx.de>

> ---
>  drivers/usb/eth/r8152_fw.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/usb/eth/r8152_fw.c b/drivers/usb/eth/r8152_fw.c
> index b6c8228..81c3754 100644
> --- a/drivers/usb/eth/r8152_fw.c
> +++ b/drivers/usb/eth/r8152_fw.c
> @@ -871,10 +871,10 @@ void r8153_firmware(struct r8152 *tp)
>  	} else if (tp->version == RTL_VER_04) {
>  		r8153_pre_ram_code(tp, 0x7001);
>  
> -	for (i = 0; i < ARRAY_SIZE(r8153_ram_code_bc); i += 2)
> -		ocp_write_word(tp, MCU_TYPE_PLA,
> -			       r8153_ram_code_bc[i],
> -			       r8153_ram_code_bc[i+1]);
> +		for (i = 0; i < ARRAY_SIZE(r8153_ram_code_bc); i += 2)
> +			ocp_write_word(tp, MCU_TYPE_PLA,
> +				       r8153_ram_code_bc[i],
> +				       r8153_ram_code_bc[i+1]);
>  
>  		r8153_post_ram_code(tp);
>  
> 


-- 
Best regards,
Marek Vasut

  reply	other threads:[~2016-11-16 11:20 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-16  0:50 [U-Boot] [PATCH 00/12] Fix GCC 6.2 compiler warnings Andre Przywara
2016-11-16  0:50 ` [U-Boot] [PATCH 01/12] ls2080aqds: eth: add missing braces Andre Przywara
2016-11-16 18:00   ` york sun
2016-11-16  0:50 ` [U-Boot] [PATCH 02/12] mtd: cfi_flash: fix indentation Andre Przywara
2016-11-16 11:26   ` Stefan Roese
2016-11-16 18:01   ` york sun
2016-12-04 23:00   ` [U-Boot] [U-Boot,02/12] " Tom Rini
2016-11-16  0:50 ` [U-Boot] [PATCH 03/12] net: e1000: " Andre Przywara
2016-11-29 19:00   ` Joe Hershberger
2016-12-04 23:01   ` [U-Boot] [U-Boot,03/12] " Tom Rini
2016-11-16  0:50 ` [U-Boot] [PATCH 04/12] net: ldpaa_eth: add missing braces Andre Przywara
2016-11-16 18:02   ` york sun
2016-11-16  0:50 ` [U-Boot] [PATCH 05/12] net: rtl8169: remove unneeded definition Andre Przywara
2016-11-29 19:01   ` Joe Hershberger
2016-12-04 23:01   ` [U-Boot] [U-Boot, " Tom Rini
2016-11-16  0:50 ` [U-Boot] [PATCH 06/12] marvell: comphy_a3700: fix bitmask Andre Przywara
2016-11-16 11:32   ` Stefan Roese
2016-11-16 12:08     ` Kostya Porotchkin
2016-12-04 23:02   ` [U-Boot] [U-Boot,06/12] " Tom Rini
2016-11-16  0:50 ` [U-Boot] [PATCH 07/12] usb: eth: r8152_fw: fix indentation Andre Przywara
2016-11-16 11:20   ` Marek Vasut [this message]
2016-11-29 19:48   ` Joe Hershberger
2016-12-04 23:03   ` [U-Boot] [U-Boot,07/12] " Tom Rini
2016-11-16  0:50 ` [U-Boot] [PATCH 08/12] davinci: da8xxevm: " Andre Przywara
2016-12-04 23:04   ` [U-Boot] [U-Boot,08/12] " Tom Rini
2016-11-16  0:50 ` [U-Boot] [PATCH 09/12] phy: micrel: add missing braces Andre Przywara
2016-11-16 11:20   ` Marek Vasut
2016-11-16  0:50 ` [U-Boot] [PATCH 10/12] cmd: tpm_test: fix indentation Andre Przywara
2016-11-17 19:50   ` Simon Glass
2016-11-16  0:50 ` [U-Boot] [PATCH 11/12] Xilinx ZynqMP: fix minimum SDHCI frequency Andre Przywara
2016-11-16  6:34   ` Michal Simek
2016-11-16  6:37     ` Michal Simek
2016-11-16  8:14       ` André Przywara
2016-11-16  8:26         ` Michal Simek
2016-11-16  0:50 ` [U-Boot] [PATCH 12/12] usb: gadget: remove unused shortname variable Andre Przywara
2016-11-16 11:20   ` Marek Vasut
2016-11-16 11:49   ` Lukasz Majewski
2016-12-04 23:05   ` [U-Boot] [U-Boot, " Tom Rini
2016-12-04 23:06   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cee335fb-01ac-37db-a2a4-9404e4604f41@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox