public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Sean Anderson <seanga2@gmail.com>
To: Kuan Lim Lee <kuanlim.lee@starfivetech.com>, u-boot@lists.denx.de
Cc: cheehong.ang@starfivetech.com, weiliang.lim@starfivetech.com
Subject: Re: [PATCH] spl: mmc: Resolve emmc not load image after switched hw partition
Date: Wed, 18 Oct 2023 01:27:25 -0400	[thread overview]
Message-ID: <cf37d9b4-e896-5109-ae03-b8ddfbf8d913@gmail.com> (raw)
In-Reply-To: <20231003041720.893-1-kuanlim.lee@starfivetech.com>

On 10/3/23 00:16, Kuan Lim Lee wrote:
> When selecting MMCSD_MODE_EMMCBOOT as boot_mode, emmc do not load U-boot
> proper image after switched hardware partition.
> 
> Signed-off-by: Kuan Lim Lee <kuanlim.lee@starfivetech.com>
> Reviewed-by: Chee Hong Ang <cheehong.ang@starfivetech.com>
> Reviewed-by: Wei Liang Lim <weiliang.lim@starfivetech.com>
> ---
>   common/spl/spl_mmc.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/common/spl/spl_mmc.c b/common/spl/spl_mmc.c
> index 20f687e138..dc8a45222b 100644
> --- a/common/spl/spl_mmc.c
> +++ b/common/spl/spl_mmc.c
> @@ -447,6 +447,9 @@ int spl_mmc_load(struct spl_image_info *spl_image,
>   #endif
>   			return err;
>   		}
> +		err = mmc_load_image_raw_sector(spl_image, bootdev, mmc, 0);
> +		if (!err)
> +			return err;
>   		/* Fall through */
>   	case MMCSD_MODE_RAW:
>   		debug("spl: mmc boot mode: raw\n");

So why doesn't the mmc_load_image_raw_sector below (line 475 or so) work?

--Sean

  parent reply	other threads:[~2023-10-18  5:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20231031050430epcas1p2ce44601cc5a47f0a768ebbfd837798a6@epcas1p2.samsung.com>
2023-10-03  4:16 ` [PATCH] spl: mmc: Resolve emmc not load image after switched hw partition Kuan Lim Lee
2023-10-10  8:14   ` KuanLim.Lee
2023-10-17  4:53   ` KuanLim.Lee
2023-10-18  4:51     ` Lothar Waßmann
2023-10-18  5:27   ` Sean Anderson [this message]
2023-10-18  6:20     ` KuanLim.Lee
2023-10-18  7:17       ` KuanLim.Lee
2023-10-31  5:04   ` Jaehoon Chung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cf37d9b4-e896-5109-ae03-b8ddfbf8d913@gmail.com \
    --to=seanga2@gmail.com \
    --cc=cheehong.ang@starfivetech.com \
    --cc=kuanlim.lee@starfivetech.com \
    --cc=u-boot@lists.denx.de \
    --cc=weiliang.lim@starfivetech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox