Re: [PATCH v3] arm: dts: rockpro64: Add RockPro64 smbios

[Dragan Simic <dsimic@manjaro.org>]

On 2023-11-13 11:01, Shantur Rathore wrote:
> Add smbios information for Pine64 RockPro64 board and enable in
> config
> 
> Signed-off-by: Shantur Rathore <i@shantur.com>
> ---
>  Changes v3: Enable SYSINFO and SYSINFO_SMBIOS in defconfig
> 
>  arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 22 ++++++++++++++++++++++
>  configs/rockpro64-rk3399_defconfig        |  2 ++
>  2 files changed, 24 insertions(+)
> 
> diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> index 732727d9b0..a4453e76f6 100644
> --- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> +++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> @@ -9,6 +9,28 @@
>  	chosen {
>  		u-boot,spl-boot-order = "same-as-spl", &spi_flash, &sdmmc, &sdhci;
>  	};
> +
> +        smbios {
> +                compatible = "u-boot,sysinfo-smbios";
> +                smbios {
> +                        system {
> +                                manufacturer = "PINE64";
> +                                product = "RockPro64";
> +                        };
> +
> +                        baseboard {
> +                                manufacturer = "PINE64";
> +                                product = "RockPro64";
> +                        };
> +
> +                        chassis {
> +                                manufacturer = "PINE64";
> +                                product = "RockPro64";
> +                        };
> +                };
> +        };
> +
> +
>  };

Perhaps it would be better to use "Pine64" instead of "PINE64", because 
"Pine64" is already used in multiple places. Also, it might be better to 
use "ROCKPro64" instead of "RockPro64", because that's actually the 
official name of the board, but I'm also perfectly fine with 
"RockPro64".

>  &sdhci {
> diff --git a/configs/rockpro64-rk3399_defconfig
> b/configs/rockpro64-rk3399_defconfig
> index 4cd6b76665..affb6137e0 100644
> --- a/configs/rockpro64-rk3399_defconfig
> +++ b/configs/rockpro64-rk3399_defconfig
> @@ -90,6 +90,8 @@ CONFIG_BAUDRATE=1500000
>  CONFIG_DEBUG_UART_SHIFT=2
>  CONFIG_SYS_NS16550_MEM32=y
>  CONFIG_ROCKCHIP_SPI=y
> +CONFIG_SYSINFO=y
> +CONFIG_SYSINFO_SMBIOS=y
>  CONFIG_SYSRESET=y
>  CONFIG_USB=y
>  CONFIG_USB_XHCI_HCD=y