U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Quentin Schulz <quentin.schulz@cherry.de>
To: Lukasz Czechowski <lukasz.czechowski@thaumatec.com>,
	u-boot@lists.denx.de
Cc: Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH v3 2/5] usb: onboard-hub: Use devm API do automatically free the reset GPIO
Date: Tue, 24 Jun 2025 17:30:51 +0200	[thread overview]
Message-ID: <cfe20b86-4e97-4a4e-a69c-2b38ef8878e8@cherry.de> (raw)
In-Reply-To: <20250610-usb_onboard_hub_cypress_hx3-v3-2-53f03dbc3017@thaumatec.com>

Hi Lukasz,

On 6/10/25 10:02 AM, Lukasz Czechowski wrote:
> The reset GPIO is obtained during driver probing by the function
> devm_gpiod_get_optional, which means the GPIO will be automatically
> freed when the device is removed. Because of this, explicit call
> to free the reset GPIO in hub remove function is not needed.
> To support the Managed device resources, the DEVRES config must
> be enabled, otherwise the devres functions fall back to non-managed
> variants. Set the necessary dependency to DEVRES in Kconfig.
> 
> Signed-off-by: Lukasz Czechowski <lukasz.czechowski@thaumatec.com>

Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>

Thanks!
Quentin

  reply	other threads:[~2025-06-24 15:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-10  8:02 [PATCH v3 0/5] Extend usb_onboard_hub driver to support Cypress HX3 hub family Lukasz Czechowski
2025-06-10  8:02 ` [PATCH v3 1/5] usb: onboard-hub: Use the ofnode to check if the peer-hub was probed Lukasz Czechowski
2025-06-10  8:02 ` [PATCH v3 2/5] usb: onboard-hub: Use devm API do automatically free the reset GPIO Lukasz Czechowski
2025-06-24 15:30   ` Quentin Schulz [this message]
2025-06-10  8:02 ` [PATCH v3 3/5] usb: onboard-hub: Set the reset gpio pin before freeing Lukasz Czechowski
2025-06-10  8:02 ` [PATCH v3 4/5] usb: onboard-hub: Add support for multiple power supplies Lukasz Czechowski
2025-06-24 15:42   ` Quentin Schulz
2025-06-10  8:02 ` [PATCH v3 5/5] usb: onboard-hub: Add support for Cypress HX3 family Lukasz Czechowski
2025-06-25 10:08 ` [PATCH v3 0/5] Extend usb_onboard_hub driver to support Cypress HX3 hub family Quentin Schulz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cfe20b86-4e97-4a4e-a69c-2b38ef8878e8@cherry.de \
    --to=quentin.schulz@cherry.de \
    --cc=lukasz.czechowski@thaumatec.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox