public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Peter Tyser <ptyser@xes-inc.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/2] net: Additional IP fragmentation check
Date: Mon,  1 Dec 2008 12:08:50 -0600	[thread overview]
Message-ID: <cover.1228149741.git.ptyser@xes-inc.com> (raw)

It looks like U-Boot ignores fragmented IP packets with
non-zero "fragment offset" fields, but doesn't ignore the
initial fragmented IP packet which has a "fragment offset"
field value of 0.

An additional check was added to catch the initial
fragmented packet which should have the "more fragments"
bit set in its flags field.

The bug initially resulted in TFTP transfers which
appeared to work, but in reality failed as some
fragmented packets were received, others were not.
With these patches applied a TFTP download from a
server with a low MTU results in a timeout as U-Boot
drops all incominig fragmented TFTP data packets.


I quickly tried the "Add simple IP/UDP fragmentation
support" patch in the net/testing repository, but
it did not work out of the box.  It looks like U-Boot
was assembling the fragmented packets correctly based on
a memory display of &NetFragBuf, but the assembled
packet was not making its way up the stack FWIW.

Peter Tyser (2):
  net: Define IP flag field values
  net: Add additional IP fragmentation check

 include/net.h |    6 ++++++
 net/net.c     |    8 +++++---
 2 files changed, 11 insertions(+), 3 deletions(-)

             reply	other threads:[~2008-12-01 18:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-01 18:08 Peter Tyser [this message]
2008-12-01 18:08 ` [U-Boot] [PATCH 1/2] net: Define IP flag field values Peter Tyser
2008-12-01 18:08   ` [U-Boot] [PATCH 2/2] net: Add additional IP fragmentation check Peter Tyser
2008-12-05  7:08 ` [U-Boot] [PATCH v2 0/2] net: Additional " Ben Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1228149741.git.ptyser@xes-inc.com \
    --to=ptyser@xes-inc.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox