[U-Boot] [PATCH v4 6/6] MX31: Add NAND SPL boot support to i.MX31 PDK board.

Jean-Christophe PLAGNIOL-VILLARD
2009-07-02T20:45:23Z

On 07:48 Wed 01 Jul , Magnus Lilja wrote:
> Hi
>
> 2009/6/30 Scott Wood <scottwood@freescale.com>:
> > Jean-Christophe PLAGNIOL-VILLARD wrote:
> >>>>>
> >>>>> +ifeq ($(debug),1)
> >>>>> +PLATFORM_CPPFLAGS += -DDEBUG
> >>>>> +endif
> >>>>
> >>>> I do not think it's board specific
> >>>
> >>> And what does that comment mean? Should I remove this, move it to
> >>> another file or what?
> >>>
> >> Personnaly I'll active it manually in the file not via a CPPFLAGS
> >> as it will result to active all bebug
> >>
> >> Scott what do you think?
> >
> > I don't think we should do anything differently from the rest of U-Boot
> > here.
>
> Well, that's not easy since the rest of U-boot does it in different
> ways, i.e. some boards have the debug stuff and some don't. As an
> example all boards in nand_spl/board/{amcc,samsung}/* have that while
> the rest don't have it.
so we need a common rule
IMHO define it manually in each file you want to debug make more sense

Scoot for you?

Best Regards,
J.