[U-Boot] [PATCH v3 8/8] arm/km: update mgcoge3un board support

Wolfgang Denk
2011-05-13T18:34:36Z

Dear Holger Brunck,

In message <4DCD3C43.7030901@keymile.com> you wrote:
>
> >> From: Holger Brunck <holger.brunck@keymile.com>
> >
> > This line should be removed or moved to cc/ack/test list, it will appear in commit log
>
> this is only the indication that the patch is not from Valentin and is common
> practice or am I wrong? Patch 5/8 in the serie does exactly the same.

Thisis correct, and git-am handles this nicely.

> >> - if (i2c_read(0x10, 2, 1, &buf, 1) != 0) {
> >> + if (i2c_read(BOCO, REG_CTRL_H, 1, &buf, 1) != 0) {
> >> printf("%s: Error reading Boco\n", __func__);
> >> return -1;
> >> }
> >> - if ((buf & 0x40) == 0x40)
> >> + if ((buf & MASK_RBX_PGY_PRESENT) == MASK_RBX_PGY_PRESENT)
> >
> > You can #if here instead of as done above, it will help to reduce code size and will be more readable.
> > I am sorry if I missed this in the earlier post.
> >
>
> hm, #if is evaluated during compile time and buf is a variable determined
> runtime. What do you mean exactly?

I think this was a misunderstanding. The code looks OK with me.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A Stanford research group advertised for participants in a study of
obsessive-compulsive disorder. They were looking for therapy clients
who had been diagnosed with this disorder. The response was grati-
fying; they got 3,000 responses about three days after the ad came
out. All from the same person.