public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Agner <stefan@agner.ch>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 0/3] ubs: tegra: two fixes and cleanup
Date: Sat, 22 Feb 2014 21:53:20 +0100	[thread overview]
Message-ID: <cover.1393101695.git.stefan@agner.ch> (raw)

Only patch 1 is an actual issue while the second patch is
something I stumbled upon, and the third is more about
housekeeping.

I descieded to ifdef the driver, I think that this is easier to
read and does not mix register access style. The function
ehci_get_port_speed however don't get a pointer to the usb_ctlr
struct and thouse has to work around that. I don't changed the
register access style there because of this reason.

The third patch is optional and implements Stephen's suggestion
to merge the USB headers. I'm not sure wheater Tegra124 would
also profit from this merge, if yes, I think then its definitely
worth doing it.

---
Changes since v3:
- Minor cleanup in USB header file

Changes since v2:
- Split into multiple patches
- Using ifdef to account for differences between Tegra20/Tegra30
- Merging of the header files

Changes since v1:
- Take differences between USBD and other USB ports into account
  port_sc1

---
Stefan Agner (3):
  usb: tegra: fix USB2 powerdown for Tegra30 and later
  usb: tegra: fix PHY configuration
  usb: tegra: combine header file

 arch/arm/include/asm/arch-tegra/usb.h    | 211 ++++++++++++++++++++++++++++++-
 arch/arm/include/asm/arch-tegra114/usb.h | 156 -----------------------
 arch/arm/include/asm/arch-tegra20/usb.h  | 155 -----------------------
 arch/arm/include/asm/arch-tegra30/usb.h  | 168 ------------------------
 board/nvidia/common/board.c              |   1 -
 drivers/usb/host/ehci-tegra.c            |  28 +++-
 6 files changed, 234 insertions(+), 485 deletions(-)
 delete mode 100644 arch/arm/include/asm/arch-tegra114/usb.h
 delete mode 100644 arch/arm/include/asm/arch-tegra20/usb.h
 delete mode 100644 arch/arm/include/asm/arch-tegra30/usb.h

-- 
1.8.5.4

             reply	other threads:[~2014-02-22 20:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-22 20:53 Stefan Agner [this message]
2014-02-22 20:53 ` [U-Boot] [PATCH v4 1/3] usb: tegra: fix USB2 powerdown for Tegra30 and later Stefan Agner
2014-02-22 20:53 ` [U-Boot] [PATCH v4 2/3] usb: tegra: fix PHY configuration Stefan Agner
2014-02-22 20:53 ` [U-Boot] [PATCH v4 3/3] usb: tegra: combine header file Stefan Agner
2014-02-24 18:43   ` Stephen Warren
2014-03-01 17:30     ` Stefan Agner
2014-03-02  4:07       ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1393101695.git.stefan@agner.ch \
    --to=stefan@agner.ch \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox