From: Simon South <simon@simonsouth.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/2] Fix memory instability on ROCK64
Date: Sun, 6 Oct 2019 12:28:12 -0400 [thread overview]
Message-ID: <cover.1570376078.git.simon@simonsouth.net> (raw)
These two patches fix small issues with the Rockchip RK3328 SDRAM
driver that prevented my PINE64 ROCK64 from booting and running
normally using U-Boot's TPL [1].
The first patch updates the phy_dll_bypass_set() function to use the
correct units for its DDR-frequency parameter, which is already
specified in MHz and does not need converting. This issue caused the
DRAM controller to be misconfigured for all but the lowest memory
speeds.
The second patch fixes an apparent typo in phy_cfg() that caused the
DRAM controller's deskew registers to be loaded with incorrect values:
Instead of copying from the second 44-element portion of the
skew-value array the driver instead re-used a portion of the first.
This also produced instability.
With both these patches applied my ROCK64 boots and runs normally
using the U-Boot TPL and a memory frequency of either 800 or 933 MHz:
In both cases the "mtest" memory-test command runs indefinitely
without error, and I can boot into NetBSD successfully without the
kernel hanging or panicking.
[1] https://lists.denx.de/pipermail/u-boot/2019-September/384076.html
Simon South (2):
ram: rk3328: Use correct frequency units in function
ram: rk3328: Fix loading of skew values
drivers/ram/rockchip/sdram_rk3328.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--
2.23.0
next reply other threads:[~2019-10-06 16:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-06 16:28 Simon South [this message]
2019-10-06 16:28 ` [U-Boot] [PATCH 1/2] ram: rk3328: Use correct frequency units in function Simon South
2019-10-08 2:55 ` Kever Yang
2019-10-14 10:07 ` [U-Boot] [PATCH 1/2] ram: rk3328: Use correct frequency units in function【请注意,邮件由u-boot-bounces@lists.denx.de代发】 " Kever Yang
2019-10-06 16:28 ` [U-Boot] [PATCH 2/2] ram: rk3328: Fix loading of skew values Simon South
2019-10-08 2:55 ` Kever Yang
2019-10-14 10:06 ` [U-Boot] [PATCH 2/2] ram: rk3328: Fix loading of skew values【请注意,邮件由u-boot-bounces@lists.denx.de代发】 Kever Yang
2019-10-07 4:25 ` [U-Boot] [PATCH 0/2] Fix memory instability on ROCK64 Kurt Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1570376078.git.simon@simonsouth.net \
--to=simon@simonsouth.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox