Re: [PATCH 4/4] Kconfig: Make all Kconfig encoding ascii

Michal Simek
2024-04-16T10:09:45Z

On 4/16/24 08:59, Francesco Dolcini wrote:
> On Tue, Apr 16, 2024 at 02:36:12AM +0200, Tom Rini wrote:
>> On Mon, Apr 15, 2024 at 02:22:02PM +0200, Heinrich Schuchardt wrote:
>>> On 15.04.24 13:35, Michal Simek wrote:
>>>> Some of Kconfigs are using utf-8 encoding because of used chars. Convert
>>>> all of them to ascii enconging.
>>>>
>>>> Signed-off-by: Michal Simek <michal.simek@amd.com>
>> [snip]
>>>> diff --git a/arch/arm/mach-rockchip/rv1126/Kconfig b/arch/arm/mach-rockchip/rv1126/Kconfig
>>>> index ae323ee91235..64a70f61f894 100644
>>>> --- a/arch/arm/mach-rockchip/rv1126/Kconfig
>>>> +++ b/arch/arm/mach-rockchip/rv1126/Kconfig
>>>> @@ -6,8 +6,8 @@ config TARGET_RV1126_NEU2
>>>> Neu2:
>>>> Neural Compute Module 2(Neu2) is a 96boards SoM-CB compute module
>>>> based on Rockchip RV1126 from Edgeble AI.
>>>> - Neu2 powered with Consumer grade (0 to +80 °C) RV1126 SoC.
>>>> - Neu2k powered with Industrial grade (-40 °C to +85 °C) RV1126K SoC.
>>>> + Neu2 powered with Consumer grade (0 to +80 C) RV1126 SoC.
>>>> + Neu2k powered with Industrial grade (-40 C to +85 C) RV1126K SoC.
>>>
>>> C is the sign for coulomb which is the unit of electric charge. How
>>> about 'deg C'?
>>
>> I'll note that in Linux there's seemingly nothing consistent, and I'm
>> fine with any of "deg C" or "degrees C" or "temperature range (-40 C to
>> +85 C)" as all of those should be clear in context.
>
> My 2 cents ... while I agree with Tom that the context will make it
> clear, it is not making it correct nor nice. Using just "C" for Celsius
> degrees is horrible ...

I used deg C in v2 version.

Thanks,
Michal