Re: [PATCH 3/4] Kconfig: Add missing quotes around default string value

Heinrich Schuchardt
2024-04-15T12:41:33Z

On 15.04.24 13:35, Michal Simek wrote:
> All errors are generated by ./tools/qconfig.py -b -j8 -i whatever.
> Error look like this:
> warning: style: quotes recommended around default value for string symbol
> EFI_VAR_SEED_FILE (defined at lib/efi_loader/Kconfig:130)
>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> ---
>
> lib/efi_loader/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
> index e13a6f9f4c3a..a5ab7d1b262f 100644
> --- a/lib/efi_loader/Kconfig
> +++ b/lib/efi_loader/Kconfig
> @@ -129,7 +129,7 @@ if EFI_VARIABLES_PRESEED
>
> config EFI_VAR_SEED_FILE
> string "File with initial values of non-volatile UEFI variables"
> - default ubootefi.var
> + default "ubootefi.var"
> help
> File with initial values of non-volatile UEFI variables. The file must
> be in the same format as the storage in the EFI system partition. The

Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>