Re: [PATCH 2/4] Kconfig: Add missing quotes around source file

Heinrich Schuchardt
2024-04-15T12:45:18Z

On 15.04.24 13:35, Michal Simek wrote:
> All errors are generated by ./tools/qconfig.py -b -j8 -i whatever.
> Error look like this:
> drivers/crypto/Kconfig:9: warning: style: quotes recommended around
> 'drivers/crypto/nuvoton/Kconfig' in 'source drivers/crypto/nuvoton/Kconfig'

Should we add a qconfig.py test to our CI?

Best regards

Heinrich

>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> ---
>
> arch/arm/mach-rockchip/rk3588/Kconfig | 18 +++++++++---------
> arch/arm/mach-rockchip/rv1108/Kconfig | 4 ++--
> arch/arm/mach-rockchip/rv1126/Kconfig | 4 ++--
> cmd/Kconfig | 2 +-
> drivers/crypto/Kconfig | 8 ++++----
> lib/Kconfig | 18 +++++++++---------
> 6 files changed, 27 insertions(+), 27 deletions(-)
>
> diff --git a/arch/arm/mach-rockchip/rk3588/Kconfig b/arch/arm/mach-rockchip/rk3588/Kconfig
> index d7e4af31f24c..eb956b097c74 100644
> --- a/arch/arm/mach-rockchip/rk3588/Kconfig
> +++ b/arch/arm/mach-rockchip/rk3588/Kconfig
> @@ -221,14 +221,14 @@ config ROCKCHIP_COMMON_STACK_ADDR
> config TEXT_BASE
> default 0x00a00000
>
> -source board/edgeble/neural-compute-module-6/Kconfig
> -source board/friendlyelec/nanopc-t6-rk3588/Kconfig
> -source board/pine64/quartzpro64-rk3588/Kconfig
> -source board/turing/turing-rk1-rk3588/Kconfig
> -source board/radxa/rock5a-rk3588s/Kconfig
> -source board/radxa/rock5b-rk3588/Kconfig
> -source board/rockchip/evb_rk3588/Kconfig
> -source board/rockchip/toybrick_rk3588/Kconfig
> -source board/theobroma-systems/jaguar_rk3588/Kconfig
> +source "board/edgeble/neural-compute-module-6/Kconfig"
> +source "board/friendlyelec/nanopc-t6-rk3588/Kconfig"
> +source "board/pine64/quartzpro64-rk3588/Kconfig"
> +source "board/turing/turing-rk1-rk3588/Kconfig"
> +source "board/radxa/rock5a-rk3588s/Kconfig"
> +source "board/radxa/rock5b-rk3588/Kconfig"
> +source "board/rockchip/evb_rk3588/Kconfig"
> +source "board/rockchip/toybrick_rk3588/Kconfig"
> +source "board/theobroma-systems/jaguar_rk3588/Kconfig"
>
> endif
> diff --git a/arch/arm/mach-rockchip/rv1108/Kconfig b/arch/arm/mach-rockchip/rv1108/Kconfig
> index a12216dccf66..28ed0b245812 100644
> --- a/arch/arm/mach-rockchip/rv1108/Kconfig
> +++ b/arch/arm/mach-rockchip/rv1108/Kconfig
> @@ -36,7 +36,7 @@ config SYS_SOC
> config SYS_MALLOC_F_LEN
> default 0x400
>
> -source board/rockchip/evb_rv1108/Kconfig
> -source board/elgin/elgin_rv1108/Kconfig
> +source "board/rockchip/evb_rv1108/Kconfig"
> +source "board/elgin/elgin_rv1108/Kconfig"
>
> endif
> diff --git a/arch/arm/mach-rockchip/rv1126/Kconfig b/arch/arm/mach-rockchip/rv1126/Kconfig
> index 55b11121203b..ae323ee91235 100644
> --- a/arch/arm/mach-rockchip/rv1126/Kconfig
> +++ b/arch/arm/mach-rockchip/rv1126/Kconfig
> @@ -64,7 +64,7 @@ config SYS_MALLOC_F_LEN
> config TEXT_BASE
> default 0x600000
>
> -source board/edgeble/neural-compute-module-2/Kconfig
> -source board/itead/sonoff-ihost/Kconfig
> +source "board/edgeble/neural-compute-module-2/Kconfig"
> +source "board/itead/sonoff-ihost/Kconfig"
>
> endif
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index 8eeb99eea5ed..45c206369518 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -398,7 +398,7 @@ config CMD_BOOTEFI_HELLO
> for testing that EFI is working at a basic level, and for bringing
> up EFI support on a new architecture.
>
> -source lib/efi_selftest/Kconfig
> +source "lib/efi_selftest/Kconfig"
> endif
>
> config CMD_BOOTMENU
> diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
> index 12ef84ca05ca..8b49997030b4 100644
> --- a/drivers/crypto/Kconfig
> +++ b/drivers/crypto/Kconfig
> @@ -1,11 +1,11 @@
> menu "Hardware crypto devices"
>
> -source drivers/crypto/hash/Kconfig
> +source "drivers/crypto/hash/Kconfig"
>
> -source drivers/crypto/fsl/Kconfig
> +source "drivers/crypto/fsl/Kconfig"
>
> -source drivers/crypto/aspeed/Kconfig
> +source "drivers/crypto/aspeed/Kconfig"
>
> -source drivers/crypto/nuvoton/Kconfig
> +source "drivers/crypto/nuvoton/Kconfig"
>
> endmenu
> diff --git a/lib/Kconfig b/lib/Kconfig
> index efb77978a652..189e6eb31aa1 100644
> --- a/lib/Kconfig
> +++ b/lib/Kconfig
> @@ -416,7 +416,7 @@ config TRACE_EARLY_ADDR
> config CIRCBUF
> bool "Enable circular buffer support"
>
> -source lib/dhry/Kconfig
> +source "lib/dhry/Kconfig"
>
> menu "Security support"
>
> @@ -429,10 +429,10 @@ config AES
> supported by the algorithm but only a 128-bit key is supported at
> present.
>
> -source lib/ecdsa/Kconfig
> -source lib/rsa/Kconfig
> -source lib/crypto/Kconfig
> -source lib/crypt/Kconfig
> +source "lib/ecdsa/Kconfig"
> +source "lib/rsa/Kconfig"
> +source "lib/crypto/Kconfig"
> +source "lib/crypt/Kconfig"
>
> config TPM
> bool "Trusted Platform Module (TPM) Support"
> @@ -1081,9 +1081,9 @@ config SMBIOS_PARSER
> help
> A simple parser for SMBIOS data.
>
> -source lib/efi/Kconfig
> -source lib/efi_loader/Kconfig
> -source lib/optee/Kconfig
> +source "lib/efi/Kconfig"
> +source "lib/efi_loader/Kconfig"
> +source "lib/optee/Kconfig"
>
> config TEST_FDTDEC
> bool "enable fdtdec test"
> @@ -1148,4 +1148,4 @@ config PHANDLE_CHECK_SEQ
>
> endmenu
>
> -source lib/fwu_updates/Kconfig
> +source "lib/fwu_updates/Kconfig"