Re: [PATCH 4/4] Kconfig: Make all Kconfig encoding ascii

Michal Simek
2024-04-16T06:32:46Z

On 4/16/24 02:36, Tom Rini wrote:
> On Mon, Apr 15, 2024 at 02:49:13PM +0200, Michal Simek wrote:
>>
>>
>> On 4/15/24 14:22, Heinrich Schuchardt wrote:
>>> On 15.04.24 13:35, Michal Simek wrote:
>>>> Some of Kconfigs are using utf-8 encoding because of used chars. Convert
>>>> all of them to ascii enconging.
>>>>
>>>> Signed-off-by: Michal Simek <michal.simek@amd.com>
>>>> ---
>>>>
>>>> There are other files which are using utf-8 enconding and pretty much I
>>>> think we should convert all of them because there is no reason to use utf-8
>>>> encoding.
>>>
>>> Hello Michal,
>>>
>>> The commit message does not explain why we should refrain from using UTF-8.
>>
>> that's a good point. I was thinking about the reason for it and pretty much
>> wanted to get feedback from Tom about it.
>>
>> In doc/develop/sending_patches.rst is said that patches should be sent as
>> plain text but encoding is not specified. Traditionally this was ASCII and I
>> pretty much don't see the reason to use UTF encoding (even my name has
>> special czech char which I am not using, the same is for Marek Vasut).
>
> My point of view is that I think ASCII should be used in general, with
> the exception being names (I won't force people to ASCII-ize their
> names, modern systems handle UTF-8 just fine). I actually don't know if
> we should also exclude rST doc files from this rule as well as UTF-8
> should render fine and for example "°C" reads nicely in web/PDF/etc.
>

I think that people the most of time just simply don't know that they are using
non ASCII chars. Anyway let me send v2 with also patch for .c and .h when
appropriate.

Thanks,
Michal