Re: [PATCH 4/4] Kconfig: Make all Kconfig encoding ascii

Heinrich Schuchardt
2024-04-15T12:22:40Z

On 15.04.24 13:35, Michal Simek wrote:
> Some of Kconfigs are using utf-8 encoding because of used chars. Convert
> all of them to ascii enconging.
>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> ---
>
> There are other files which are using utf-8 enconding and pretty much I
> think we should convert all of them because there is no reason to use utf-8
> encoding.

Hello Michal,

The commit message does not explain why we should refrain from using UTF-8.

>
> ---
> arch/arm/mach-rockchip/px30/Kconfig | 4 ++--
> arch/arm/mach-rockchip/rk3588/Kconfig | 6 +++---
> arch/arm/mach-rockchip/rv1126/Kconfig | 4 ++--
> drivers/mtd/spi/Kconfig | 2 +-
> 4 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/mach-rockchip/px30/Kconfig b/arch/arm/mach-rockchip/px30/Kconfig
> index 41893920cb4d..23f8f430c4ae 100644
> --- a/arch/arm/mach-rockchip/px30/Kconfig
> +++ b/arch/arm/mach-rockchip/px30/Kconfig
> @@ -36,9 +36,9 @@ config TARGET_PX30_CORE
> 10.1" OF for creating complete PX30.Core C.TOUCH 2.0 10.1" Open Frame.
>
> config TARGET_RINGNECK_PX30
> - bool "Theobroma Systems PX30-µQ7 (Ringneck)"
> + bool "Theobroma Systems PX30-uQ7 (Ringneck)"
> help
> - The PX30-uQ7 (Ringneck) SoM is a µQseven-compatible (40mmx70mm,
> + The PX30-uQ7 (Ringneck) SoM is a uQseven-compatible (40mmx70mm,
> MXM-230 connector) system-on-module from Theobroma Systems[1],
> featuring the Rockchip PX30.
>
> diff --git a/arch/arm/mach-rockchip/rk3588/Kconfig b/arch/arm/mach-rockchip/rk3588/Kconfig
> index eb956b097c74..39049ab35a9c 100644
> --- a/arch/arm/mach-rockchip/rk3588/Kconfig
> +++ b/arch/arm/mach-rockchip/rk3588/Kconfig
> @@ -66,7 +66,7 @@ config TARGET_NANOPCT6_RK3588
> HDMI2.0, and HDMI1.4
> 2x 4-lane MIPI-DSI, compatible with MIPI DPHY 2.0 or CPHY 1.1
> USB-A: USB 3.0, Type A
> - USB-C: Full function USB Type‑C port, DP display up to 4Kp60, USB 3.0
> + USB-C: Full function USB Type-C port, DP display up to 4Kp60, USB 3.0
> 40-pin 2.54mm header connector: up to 2x SPIs, 6x UARTs, 1x I2Cs,
> 8x PWMs, 2x I2Ss, 28x GPIOs
> Debug UART: 3 Pin 2.54mm header, 3V level, 1500000bps
> @@ -117,7 +117,7 @@ config TARGET_ROCK5A_RK3588
> Mali G610MC4 GPU
> MIPI CSI 2 multiple lanes connector
> 4-lane MIPI DSI connector
> - Audio – 3.5mm earphone jack
> + Audio - 3.5mm earphone jack
> eMMC module connector
> uSD slot (up to 128GB)
> 2x USB 2.0, 2x USB 3.0
> @@ -197,7 +197,7 @@ config TARGET_TOYBRICK_RK3588
> 4x ARM Cortex-A76, 4x ARM Cortex-A55
> 8/16GB Memory LPDDR4x
> Mali G610MC4 GPU
> - 2× MIPI-CSI0 Connector
> + 2x MIPI-CSI0 Connector
> 1x 2Lanes PCIe3.0 Connector
> 1x SATA3.0 Connector
> 32GB eMMC Module
> diff --git a/arch/arm/mach-rockchip/rv1126/Kconfig b/arch/arm/mach-rockchip/rv1126/Kconfig
> index ae323ee91235..64a70f61f894 100644
> --- a/arch/arm/mach-rockchip/rv1126/Kconfig
> +++ b/arch/arm/mach-rockchip/rv1126/Kconfig
> @@ -6,8 +6,8 @@ config TARGET_RV1126_NEU2
> Neu2:
> Neural Compute Module 2(Neu2) is a 96boards SoM-CB compute module
> based on Rockchip RV1126 from Edgeble AI.
> - Neu2 powered with Consumer grade (0 to +80 °C) RV1126 SoC.
> - Neu2k powered with Industrial grade (-40 °C to +85 °C) RV1126K SoC.
> + Neu2 powered with Consumer grade (0 to +80 C) RV1126 SoC.
> + Neu2k powered with Industrial grade (-40 C to +85 C) RV1126K SoC.

C is the sign for coulomb which is the unit of electric charge. How
about 'deg C'?

Best regards

Heinrich

>
> Neu2-IO:
> Neural Compute Module 2(Neu2) IO board is an industrial form factor
> diff --git a/drivers/mtd/spi/Kconfig b/drivers/mtd/spi/Kconfig
> index d068b7860e1c..bedc4e970e43 100644
> --- a/drivers/mtd/spi/Kconfig
> +++ b/drivers/mtd/spi/Kconfig
> @@ -246,7 +246,7 @@ config SPI_FLASH_USE_4K_SECTORS
> to erasing whole blocks (32/64 KiB).
> Changing a small part of the flash's contents is usually faster with
> small sectors. On the other hand erasing should be faster when using
> - 64 KiB block instead of 16 × 4 KiB sectors.
> + 64 KiB block instead of 16 x 4 KiB sectors.
>
> Please note that some tools/drivers/filesystems may not work with
> 4096 B erase size (e.g. UBIFS requires 15 KiB as a minimum).