U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Golle <daniel@makrotopia.org>
To: Tom Rini <trini@konsulko.com>,
	Daniel Golle <daniel@makrotopia.org>,
	Kyungmin Park <kmpark@infradead.org>,
	Heiko Schocher <hs@nabladev.com>, Simon Glass <sjg@chromium.org>,
	Aristo Chen <aristo.chen@canonical.com>,
	Anton Ivanov <anton@binarly.io>,
	Weijie Gao <weijie.gao@mediatek.com>,
	u-boot@lists.u-boot-project.org, openwrt-devel@lists.openwrt.org
Subject: [PATCH 00/11] imagemap: fixes from the v1 review
Date: Tue, 29 Sep 2026 01:04:16 +0100	[thread overview]
Message-ID: <cover.1790626459.git.daniel@makrotopia.org> (raw)

Simon Glass reviewed the v1 posting of the imagemap series
(cover.1787272661.git.daniel@makrotopia.org) after v2 had already been
applied, so his comments arrive against code that is now in next. This
series carries the correctness half of them; a second series follows
with the structural and cosmetic half.

Tested on sandbox: every commit builds, "ut imagemap" passes 13/13 and
survives "ut -r3", and a full test.py run shows the same 11 failures and
20 errors as unmodified next, all of them EFI-secboot tooling, ext4 and
config-rebuild tests unrelated to this code. Also built with
CONFIG_IMAGEMAP=n.

Signed-off-by: Daniel Golle <daniel@makrotopia.org>

Daniel Golle (11):
  mtd: bind the block device without leaking on failure
  cmd: ubi: report a failed UBI block device bind
  cmd: ubi: unbind the block device when detaching UBI
  boot: imagemap: free the reservation a replaced record owned
  boot: imagemap: do not resize a region the caller owns
  boot: imagemap: read only the bytes an extend adds
  boot: fit: unmap the load address after a storage read
  boot: fit: keep the load message for RAM-backed images
  boot: bootm: release the imagemap on every failing exit
  test: boot: imagemap: detach UBI when the test is done
  test: boot: imagemap: reset driver-model state between tests

 boot/bootm.c            |  9 +++---
 boot/image-fit.c        |  7 +++--
 boot/imagemap.c         | 55 ++++++++++++++++++++++++---------
 cmd/ubi.c               | 67 +++++++++++++++++++++++++++--------------
 drivers/mtd/mtdcore.c   | 37 ++++++++++++++++-------
 drivers/mtd/ubi/block.c |  4 ++-
 include/ubi_uboot.h     |  4 +--
 test/boot/imagemap.c    | 36 ++++++++++++++--------
 8 files changed, 147 insertions(+), 72 deletions(-)


base-commit: 2b8902913c19eb581fb0d567201c09b8fa46ac74
-- 
2.55.0

             reply	other threads:[~2026-09-29  0:04 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-29  0:04 Daniel Golle [this message]
2026-09-29  0:04 ` [PATCH 01/11] mtd: bind the block device without leaking on failure Daniel Golle
2026-10-01 15:59   ` Simon Glass
2026-09-29  0:04 ` [PATCH 02/11] cmd: ubi: report a failed UBI block device bind Daniel Golle
2026-10-01 15:59   ` Simon Glass
2026-09-29  0:05 ` [PATCH 03/11] cmd: ubi: unbind the block device when detaching UBI Daniel Golle
2026-10-01 15:59   ` Simon Glass
2026-09-29  0:05 ` [PATCH 04/11] boot: imagemap: free the reservation a replaced record owned Daniel Golle
2026-10-01 15:59   ` Simon Glass
2026-09-29  0:05 ` [PATCH 05/11] boot: imagemap: do not resize a region the caller owns Daniel Golle
2026-10-01 15:59   ` Simon Glass
2026-09-29  0:05 ` [PATCH 06/11] boot: imagemap: read only the bytes an extend adds Daniel Golle
2026-10-01 16:00   ` Simon Glass
2026-09-29  0:05 ` [PATCH 07/11] boot: fit: unmap the load address after a storage read Daniel Golle
2026-10-01 16:02   ` Simon Glass
2026-09-29  0:05 ` [PATCH 08/11] boot: fit: keep the load message for RAM-backed images Daniel Golle
2026-10-01 16:02   ` Simon Glass
2026-09-29  0:05 ` [PATCH 09/11] boot: bootm: release the imagemap on every failing exit Daniel Golle
2026-10-01 16:02   ` Simon Glass
2026-09-29  0:05 ` [PATCH 10/11] test: boot: imagemap: detach UBI when the test is done Daniel Golle
2026-10-01 16:02   ` Simon Glass
2026-09-29  0:06 ` [PATCH 11/11] test: boot: imagemap: reset driver-model state between tests Daniel Golle
2026-10-01 16:00   ` Simon Glass
2026-10-01 16:04 ` [00/11] imagemap: fixes from the v1 review Simon Glass
2026-10-13 20:19 ` [PATCH 00/11] " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1790626459.git.daniel@makrotopia.org \
    --to=daniel@makrotopia.org \
    --cc=anton@binarly.io \
    --cc=aristo.chen@canonical.com \
    --cc=hs@nabladev.com \
    --cc=kmpark@infradead.org \
    --cc=openwrt-devel@lists.openwrt.org \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.u-boot-project.org \
    --cc=weijie.gao@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox