public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Philippe CORNU <philippe.cornu@st.com>
To: u-boot@lists.denx.de
Subject: [PATCH] video: check hardware version of DSI
Date: Fri, 26 Jun 2020 09:08:47 +0000	[thread overview]
Message-ID: <d01ef2cb-736f-bf4f-3f62-84facb47baa6@st.com> (raw)
In-Reply-To: <20200624084359.17949-1-yannick.fertre@st.com>

Hi Yannick,
Many thanks for your patch,

Reviewed-by: Philippe Cornu <philippe.cornu@st.com>

Philippe :-)

On 6/24/20 10:43 AM, Yannick Fertre wrote:
> Check the hardware version of DSI. Versions 1.30 & 1.31 are only
> supported.
> 
> Signed-off-by: Yannick Fertre <yannick.fertre@st.com>
> ---
>   drivers/video/stm32/stm32_dsi.c | 10 +++++++++-
>   1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/video/stm32/stm32_dsi.c b/drivers/video/stm32/stm32_dsi.c
> index 04796435f1..31ab8ebec7 100644
> --- a/drivers/video/stm32/stm32_dsi.c
> +++ b/drivers/video/stm32/stm32_dsi.c
> @@ -271,7 +271,6 @@ static int dsi_get_lane_mbps(void *priv_data, struct display_timing *timings,
>   	u32 val;
>   
>   	/* Update lane capabilities according to hw version */
> -	dsi->hw_version = dsi_read(dsi, DSI_VERSION) & VERSION;
>   	dsi->lane_min_kbps = LANE_MIN_KBPS;
>   	dsi->lane_max_kbps = LANE_MAX_KBPS;
>   	if (dsi->hw_version == HWVER_131) {
> @@ -475,6 +474,15 @@ static int stm32_dsi_probe(struct udevice *dev)
>   	/* Reset */
>   	reset_deassert(&rst);
>   
> +	/* check hardware version */
> +	priv->hw_version = dsi_read(priv, DSI_VERSION) & VERSION;
> +	if (priv->hw_version != HWVER_130 &&
> +	    priv->hw_version != HWVER_131) {
> +		dev_err(dev, "DSI version 0x%x not supported\n", priv->hw_version);
> +		ret = -ENODEV;
> +		goto err_clk;
> +	}
> +
>   	return 0;
>   err_clk:
>   	clk_disable(&clk);
> 

  parent reply	other threads:[~2020-06-26  9:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-24  8:43 [PATCH] video: check hardware version of DSI Yannick Fertre
2020-06-24 13:24 ` Patrick DELAUNAY
2020-06-26  9:08 ` Philippe CORNU [this message]
2020-06-29  7:01 ` Anatolij Gustschin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d01ef2cb-736f-bf4f-3f62-84facb47baa6@st.com \
    --to=philippe.cornu@st.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox