public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Patrick DELAUNAY <patrick.delaunay@foss.st.com>
To: Etienne Carriere <etienne.carriere@linaro.org>, <u-boot@lists.denx.de>
Cc: Jens Wiklander <jens.wiklander@linaro.org>
Subject: Re: [PATCH 1/2] tee: optee: don't fail probe because of optee-rng
Date: Tue, 3 Jan 2023 17:53:41 +0100	[thread overview]
Message-ID: <d034b20d-a3c6-366a-689c-e75afdffde8d@foss.st.com> (raw)
In-Reply-To: <20221207153000.534581-1-etienne.carriere@linaro.org>

Hi,

On 12/7/22 16:29, Etienne Carriere wrote:
> Fixes optee-rng driver bind sequence in optee driver to print a warning
> message but not report an error status when a optee-rng service driver
> fails to be bound as the optee driver itself is still fully functional.
>
> Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
> ---
>   drivers/tee/optee/core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c
> index 9240277579..604fd1414f 100644
> --- a/drivers/tee/optee/core.c
> +++ b/drivers/tee/optee/core.c
> @@ -834,7 +834,7 @@ static int optee_probe(struct udevice *dev)
>   		 */
>   		ret = device_bind_driver(dev, "optee-rng", "optee-rng", NULL);
>   		if (ret)
> -			return ret;
> +			dev_warn(dev, "ftpm_tee failed to bind: %d\n", ret);
>   	}
>   
>   	return 0;



Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>

Thanks
Patrick


      parent reply	other threads:[~2023-01-03 16:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-07 15:29 [PATCH 1/2] tee: optee: don't fail probe because of optee-rng Etienne Carriere
2022-12-07 15:30 ` [PATCH 2/2] tee: optee: discover services dependent on tee-supplicant Etienne Carriere
2022-12-22  9:31   ` Ilias Apalodimas
2022-12-22 10:56   ` Jens Wiklander
2023-01-03 17:03   ` Patrick DELAUNAY
2022-12-22  9:30 ` [PATCH 1/2] tee: optee: don't fail probe because of optee-rng Ilias Apalodimas
2022-12-22 10:57 ` Jens Wiklander
2023-01-03 16:53 ` Patrick DELAUNAY [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d034b20d-a3c6-366a-689c-e75afdffde8d@foss.st.com \
    --to=patrick.delaunay@foss.st.com \
    --cc=etienne.carriere@linaro.org \
    --cc=jens.wiklander@linaro.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox