From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3961FC433EF for ; Sun, 29 May 2022 16:31:38 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id ADB2A841A5; Sun, 29 May 2022 18:31:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="qgH7icyh"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 55089841F3; Sun, 29 May 2022 18:31:33 +0200 (CEST) Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BB68583F17 for ; Sun, 29 May 2022 18:31:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=alpernebiyasak@gmail.com Received: by mail-ed1-x52a.google.com with SMTP id h19so2706993edj.0 for ; Sun, 29 May 2022 09:31:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=hf4ykruGVJCfXJqureG2nJipoah+wvfmfQTBhnNXPvw=; b=qgH7icyhphUoIK5NUWL/qughsBO3fe/fmj2XKA7aGeuE7mIIY7/p8bZpg5ytf+ab+j p9klSKwisQADnQ3vnQw5Qd9Qvwb6RoY/aDaX6tfQNaZ8DuizPSXR27MJnQTG220Mxvez Xoxwg7VqGxV2pVAViyepyKqrR6GowprQV4hk6T+hOsStS8a4YYoLzLyNhUXJ3ZyEOQEd JTyL/Yqngr4Eh+qIUrFfc4aXVKwGmUKC1hG4wA2YXXF0m3AJ0gicVRRRDTA+S9jSQz9O 2eY6p7zS2/ZlyPCbfPpVPN2yHCYEfIduq9ZiUbNzbD20sPWBbLcS6j7Qx8e+UU/M04K1 pI+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=hf4ykruGVJCfXJqureG2nJipoah+wvfmfQTBhnNXPvw=; b=OAElaKo7EDplGd2PvqUIo9GnULSp23fE2N5yYIKvXFwA5DcfYrsa2lbHM6HdmhJuHD 45JnNtKl13t2YT4jhpbrRmQqVLt94znVFT2DPvFRhGPrB2auWWbmT5fFxDIke7aYGXuc 67czQxa8tdxyz7xSmHXv28vO2iv80It8qEjf5ZjRnz/dxN/FKruOeP3bIbC6VdUWVLGu Tdl0q3nvBnwdxRDHoU33HNJSxvOYdlr2oGBZw6TbbjDIWAVw3M8zJB8Sve3CiM3HilrH skWYkQEx7fNZg7km4cYtkXy9Ag6CS7IKoWSdryxIankjGMzWY23YsVkIM+oZaf2OIGFw S8gg== X-Gm-Message-State: AOAM5307RkF/sj+6937gM60vF97MEg5IMrKC/GLGS69Hzlrc1J/QAkdH CSqvDAPbKlJFtwiSLMKiWMQ= X-Google-Smtp-Source: ABdhPJzw6D0z02GkB25PqxHAFKSF0XLL++nn+ssZbSMwoAf1j5PzThmlkzYosMsLHijJqVGLqDorFA== X-Received: by 2002:a05:6402:354a:b0:42b:52ed:dde4 with SMTP id f10-20020a056402354a00b0042b52eddde4mr40314650edd.324.1653841890318; Sun, 29 May 2022 09:31:30 -0700 (PDT) Received: from [192.168.0.74] ([178.233.178.185]) by smtp.gmail.com with ESMTPSA id a9-20020a50c309000000b00428a42815aasm5142738edb.0.2022.05.29.09.31.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 29 May 2022 09:31:29 -0700 (PDT) Message-ID: Date: Sun, 29 May 2022 19:31:17 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [RFC PATCH v2 2/8] rockchip: Add binman definitions for final images Content-Language: en-US To: Andrew Abbott Cc: Jagan Teki , Johan Jonker , Simon Glass , Samuel Dionne-Riel , Peter Robinson , Kever Yang , Philipp Tomsich , U-Boot Mailing List References: <20220516110712.178958-1-andrew@mirx.dev> <20220516110712.178958-3-andrew@mirx.dev> <1524e013-99a7-5aa6-3d2f-c13dbb208605@gmail.com> From: Alper Nebi Yasak In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 22/05/2022 03:55, Andrew Abbott wrote: > On Thu May 19, 2022 at 9:36 PM AEST, Alper Nebi Yasak wrote: >> Do we need the 'idbloader.img' as a build output, assuming we have a >> working 'u-boot-rockchip.bin'? I'm asking because Simon was trying to >> drop it in a similar patch [1]. > > I was keeping it for backwards compatibility, mainly because it's > mentioned in 'rockchip.rst' and it implies that 'idbloader.img' goes > on a separate partition to 'u-boot.itb' for targets supporting Fastboot. > If we can drop it, then I'll gladly do so! Honestly, I don't know. I was hoping someone else would comment as well. I'm inclined to say we don't need it, as we would ideally be able to extract/replace the 'idbloader.img' from/in working images with binman commands when needed. >> With what I said above, I think you should rename this to 'u-boot.rom' >> and remove the definitions in {rk3288,rk3399}-u-boot.dtsi. > > Makes sense to me - I just wonder if the name 'u-boot.rom' is too > generic, since it will be an image specifically for Rockchip targets. > Then again, perhaps the original 'u-boot-rockchip.bin' name was > redundant, since you know what target you're building for by using a > specific defconfig in the first place. I think it's meant to be a step towards unifying the build artifacts and names across the board, which I'd like if it eventually happened. We would have different definitions of the 'u-boot.rom' image for different whatevers, but for every board "Build and write u-boot.rom to SPI flash if it exists" would be valid advice.