Re: [PATCH V2 02/12] board: ti: j721e: evm: Drop board check for ESM

Neha Malcom Francis
2023-11-07T07:06:37Z

Hi Nishanth,

On 04/11/23 12:51, Nishanth Menon wrote:
> When config is enabled, the esm dt probe makes sense. Simplify by
> dropping board specific checks.
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> board/ti/j721e/evm.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/board/ti/j721e/evm.c b/board/ti/j721e/evm.c
> index aa22f1653fec..8f0996c32ee6 100644
> --- a/board/ti/j721e/evm.c
> +++ b/board/ti/j721e/evm.c
> @@ -523,10 +523,8 @@ err_free_gpio:
>
> void spl_board_init(void)
> {
> -#if defined(CONFIG_ESM_K3) || defined(CONFIG_ESM_PMIC)
> struct udevice *dev;
> int ret;
> -#endif
>
> if ((IS_ENABLED(CONFIG_TARGET_J721E_A72_EVM) ||
> IS_ENABLED(CONFIG_TARGET_J7200_A72_EVM)) &&
> @@ -535,24 +533,20 @@ void spl_board_init(void)
> probe_daughtercards();
> }
>
> -#ifdef CONFIG_ESM_K3
> - if (board_ti_k3_is("J721EX-PM2-SOM")) {
> + if (IS_ENABLED(CONFIG_ESM_K3)) {
> ret = uclass_get_device_by_driver(UCLASS_MISC,
> DM_DRIVER_GET(k3_esm), &dev);
> if (ret)
> printf("ESM init failed: %d\n", ret);
> }
> -#endif
>
> -#ifdef CONFIG_ESM_PMIC
> - if (board_ti_k3_is("J721EX-PM2-SOM")) {
> + if (IS_ENABLED(CONFIG_ESM_PMIC)) {
> ret = uclass_get_device_by_driver(UCLASS_MISC,
> DM_DRIVER_GET(pmic_esm),
> &dev);
> if (ret)
> printf("ESM PMIC init failed: %d\n", ret);
> }
> -#endif

Add empty line here?

> if ((IS_ENABLED(CONFIG_TARGET_J7200_A72_EVM) || IS_ENABLED(CONFIG_TARGET_J721E_A72_EVM)) &&
> IS_ENABLED(CONFIG_HBMC_AM654)) {
> struct udevice *dev;

Reviewed-by: Neha Malcom Francis <n-francis@ti.com>

--
Thanking You
Neha Malcom Francis