Re: [PATCH 1/2] w1: w1-gpio: claim the gpio with correct initial flag

[<Eugen.Hristev@microchip.com>]

On 6/23/21 5:20 PM, Eugen Hristev wrote:
> gpio_request_by_name should be called with proper flags.
> The 0 value flag is invalid, and causes bad initialization of the gpio.
> 
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> ---
>   drivers/w1/w1-gpio.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/w1/w1-gpio.c b/drivers/w1/w1-gpio.c
> index 3b0ead6f6d..9346f810ce 100644
> --- a/drivers/w1/w1-gpio.c
> +++ b/drivers/w1/w1-gpio.c
> @@ -156,7 +156,7 @@ static int w1_gpio_of_to_plat(struct udevice *dev)
>   	struct w1_gpio_pdata *pdata = dev_get_plat(dev);
>   	int ret;
>   
> -	ret = gpio_request_by_name(dev, "gpios", 0, &pdata->gpio, 0);
> +	ret = gpio_request_by_name(dev, "gpios", 0, &pdata->gpio, GPIOD_IS_IN);
>   	if (ret < 0)
>   		printf("Error claiming GPIO %d\n", ret);
>   
> 

Applied both to u-boot-atmel/master