From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35955C433EF for ; Fri, 22 Apr 2022 12:04:12 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B33CE83AE6; Fri, 22 Apr 2022 14:04:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="T7T61uRo"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 08D0A83D5E; Fri, 22 Apr 2022 14:04:08 +0200 (CEST) Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E36D1831CA for ; Fri, 22 Apr 2022 14:04:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jh80.chung@gmail.com Received: by mail-pf1-x433.google.com with SMTP id x80so7837837pfc.1 for ; Fri, 22 Apr 2022 05:04:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=YeaUJE9BM8SY9ko5aatBc6ewGCBHT52RC90nYcKH3E8=; b=T7T61uRoAdUbzHEYMHmcCJsnfXosr9rFxpyxXprb+JujFy+VtX4/Gge89AowGJ1Uff PqQSNKkDKaZH/cDMWI43hkuiFIdCrUU5jrXG0gmV0oCHiMJ1miAIh1zQSyN4jVlUA/JY P8a5lYZFPn96r/g9td53jC3IF+CiBrQdSBLkACEstWT5MPwRwBFcTmIp3tg5t0H7fMPF Tw47DPz7SyktJkrlanFvgKqe+Bb1zcvx62sbT1ml9a78/+X3uuyVx/fFNCBq7Uu3bwL+ QuIvhyZDgJwQylLgk1kzDqyV04WVS5tlqNiaiDXXOBOnOEp1HZDwyUEEqz6sJNY5XmbV teww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=YeaUJE9BM8SY9ko5aatBc6ewGCBHT52RC90nYcKH3E8=; b=vwysfAgP9NCv64fgvZlY6SGKumvjA/gA+3W+1jnzM3qj+Sz3PuDL+Yfp6JPHbLhUZj ORBxJA75FOjhMluQt/wCNbwFAxkYh6HAABMD1h+gfoHrMdGFp19SuIk08uAc3uho+mpB 2nbxRo10Cga8/n3egaWIKSyJ9o4sarOhVjknIPb4qZcHGztELjQ673V2NIVf/j5RPQlU kTAz6nLGIllsn0i54zBBgzSBiQlrfQ23ItOSZdVz5fqXjc8ewt26GtGc2F/xdIZjU/ip u5tDLi+bY+7ezJavSryG7kI96xV8REmHsh/HhVvtbarpEVzb+Bv83XrIeNBVN0fPasA2 4Jdg== X-Gm-Message-State: AOAM531VPua/8qUSNAuP9mJccgcaw/pCWpxlEseRgDNihQNir0rs/EaH kdmk7G80i4RHzNwPOQN9/AA= X-Google-Smtp-Source: ABdhPJyktzoL8sOxNtPNyoqjffILBv3LnE5jPyFg3zD6jehG4YF+9lDNDttxCqH32eH6vJnzy79iiw== X-Received: by 2002:a63:f4e:0:b0:382:1e31:79e8 with SMTP id 14-20020a630f4e000000b003821e3179e8mr3724893pgp.167.1650629043374; Fri, 22 Apr 2022 05:04:03 -0700 (PDT) Received: from [192.168.0.19] ([183.99.112.216]) by smtp.gmail.com with ESMTPSA id k198-20020a633dcf000000b003aa9116ba17sm2124504pga.35.2022.04.22.05.04.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Apr 2022 05:04:02 -0700 (PDT) Message-ID: Date: Fri, 22 Apr 2022 21:03:59 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 4/4] mmc: sandbox: Set the response Content-Language: en-US To: Sean Anderson , u-boot@lists.denx.de Cc: Peng Fan , Simon Glass , Jaehoon Chung References: <20220330165446.438925-1-seanga2@gmail.com> <20220330165446.438925-5-seanga2@gmail.com> From: Jaehoon Chung In-Reply-To: <20220330165446.438925-5-seanga2@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 3/31/22 01:54, Sean Anderson wrote: > The mmc subsystem checks the response, but we (almost) never set it. Add a > bare-bones implementation. Technically, we are supposed to return our > current state in our responses, but I don't think the subsystem checks it. > > Signed-off-by: Sean Anderson Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > > drivers/mmc/sandbox_mmc.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/sandbox_mmc.c b/drivers/mmc/sandbox_mmc.c > index 60a6be0add..8922eeba2a 100644 > --- a/drivers/mmc/sandbox_mmc.c > +++ b/drivers/mmc/sandbox_mmc.c > @@ -44,6 +44,9 @@ static int sandbox_mmc_send_cmd(struct udevice *dev, struct mmc_cmd *cmd, > struct mmc *mmc = mmc_get_mmc_dev(dev); > static ulong erase_start, erase_end; > > + /* Default R1 response */ > + cmd->response[0] = R1_READY_FOR_DATA; > + > switch (cmd->cmdidx) { > case MMC_CMD_ALL_SEND_CID: > memset(cmd->response, '\0', sizeof(cmd->response)); > @@ -55,8 +58,8 @@ static int sandbox_mmc_send_cmd(struct udevice *dev, struct mmc_cmd *cmd, > case SD_CMD_SEND_IF_COND: > cmd->response[0] = 0xaa; > break; > - case MMC_CMD_SEND_STATUS: > - cmd->response[0] = MMC_STATUS_RDY_FOR_DATA; > + case SD_CMD_APP_SD_STATUS: > + cmd->response[0] |= R1_APP_CMD; > memset(data->dest, '\0', data->blocks * data->blocksize); > break; > case MMC_CMD_SELECT_CARD: > @@ -106,6 +109,7 @@ static int sandbox_mmc_send_cmd(struct udevice *dev, struct mmc_cmd *cmd, > cmd->response[2] = 0; > break; > case MMC_CMD_APP_CMD: > + cmd->response[0] |= R1_APP_CMD; > break; > case MMC_CMD_SET_BLOCKLEN: > debug("block len %d\n", cmd->cmdarg); > @@ -113,11 +117,13 @@ static int sandbox_mmc_send_cmd(struct udevice *dev, struct mmc_cmd *cmd, > case SD_CMD_APP_SEND_SCR: { > u32 *scr = (u32 *)data->dest; > > + cmd->response[0] |= R1_APP_CMD; > scr[0] = cpu_to_be32(2 << 24 | 1 << 15); /* SD version 3 */ > break; > } > default: > debug("%s: Unknown command %d\n", __func__, cmd->cmdidx); > + cmd->response[0] |= R1_ILLEGAL_COMMAND; > break; > } >