From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Sat, 18 Nov 2017 11:24:21 +0100 Subject: [U-Boot] [PATCH] usb: r8a66597: Add support for RZ/A series In-Reply-To: References: <20171113212118.10843-1-chris.brandt@renesas.com> <12919cb0-14cc-811e-6a4d-1495171f4b9a@gmail.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 11/17/2017 08:56 PM, Chris Brandt wrote: > Thanks for the review. > > On Friday, November 17, 2017, Marek Vasut wrote: >>> +#ifndef RZA_USB >> >> This should be turned into Kconfig entry, some CONFIG_... > > So you want RZA_USB in Kconfig, but is it OK if it is automatically > selected when an RZ/A device is selected? That's fine. I (well, the u-boot maintainers in general) want to move to Kconfig and drop the ad-hoc configuration with macros defined in include/configs/ at some point. > For example: > > config R7S72100 > bool > select CONFIG_RZA_USB > > Thanks, > Chris > -- Best regards, Marek Vasut