From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB1C1C433EF for ; Mon, 31 Jan 2022 22:02:59 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9608C82063; Mon, 31 Jan 2022 23:02:57 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=xs4all.nl Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 5597581DE9; Mon, 31 Jan 2022 23:02:56 +0100 (CET) Received: from sibelius.xs4all.nl (sibelius.xs4all.nl [83.163.83.176]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7216383559 for ; Mon, 31 Jan 2022 23:02:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=xs4all.nl Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=mark.kettenis@xs4all.nl Received: from localhost (bloch.sibelius.xs4all.nl [local]) by bloch.sibelius.xs4all.nl (OpenSMTPD) with ESMTPA id 2c9632b4; Mon, 31 Jan 2022 23:02:51 +0100 (CET) Date: Mon, 31 Jan 2022 23:02:51 +0100 (CET) From: Mark Kettenis To: Tom Rini Cc: sjg@chromium.org, u-boot@lists.denx.de, monstr@monstr.eu, hl@rock-chips.com, jeffy.chen@rock-chips.com, kever.yang@rock-chips.com, philipp.tomsich@theobroma-systems.com, uboot-imx@nxp.com, marek.behun@nic.cz, yamada.masahiro@socionext.com In-Reply-To: <20220131204039.GG7515@bill-the-cat> (message from Tom Rini on Mon, 31 Jan 2022 15:40:39 -0500) Subject: Re: [PATCH v2 2/2] Makefile: Don't allow new boards with SPL_FIT_GENERATOR References: <20220130155225.726890-1-sjg@chromium.org> <20220130155225.726890-2-sjg@chromium.org> <20220131142412.GH7515@bill-the-cat> <20220131161544.GZ7515@bill-the-cat> <20220131180001.GC7515@bill-the-cat> <20220131204039.GG7515@bill-the-cat> Message-ID: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean > Date: Mon, 31 Jan 2022 15:40:39 -0500 > From: Tom Rini > > On Mon, Jan 31, 2022 at 12:57:57PM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Mon, 31 Jan 2022 at 11:00, Tom Rini wrote: > > > > > > On Mon, Jan 31, 2022 at 10:27:41AM -0700, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Mon, 31 Jan 2022 at 09:15, Tom Rini wrote: > > > > > > > > > > On Mon, Jan 31, 2022 at 09:13:02AM -0700, Simon Glass wrote: > > > > > > Hi Tom, > > > > > > > > > > > > On Mon, 31 Jan 2022 at 07:24, Tom Rini wrote: > > > > > > > > > > > > > > On Sun, Jan 30, 2022 at 08:52:25AM -0700, Simon Glass wrote: > > > > > > > > > > > > > > > More than a year after this migration message appeared, we still have new > > > > > > > > boards being added with this option. Add a check against this. > > > > > > > > > > > > > > > > Signed-off-by: Simon Glass > > > > > > > > > > > > > > Please just make this an error in checkpatch.pl instead. > > > > > > > > > > > > I couldn't think of a way of doing that...do you have an idea? > > > > > > > > > > Yes, 2f3e8d6a86cb ("checkpatch: report ERROR only on disabling of fdt > > > > > and initrd relocation") updates the check I had for fdt_high/initrd_high > > > > > being in the file at all to only be for additions. And yes, I check > > > > > every PR for new checkpatch ERROR lines and only ignore the ones for > > > > > code imported from other projects. > > > > > > > > Yes, I understand that, but SPL_FIT_GENERATOR defaults to on for > > > > certain boards, so there is no need to mention it anywhere in the > > > > patch. Also someone could adjust the condition in the Kconfig to add > > > > other boards. > > > > > > Then you want something a bit more like the fdt|initrd_high check now, > > > along with updating the help around SPL_FIT_GENERATOR to note that this > > > option is deprecated, is the path forward then I think. > > > > I'm still a bit lost. > > > > What I want: break the build if someone adds a new board that uses > > SPL_FIT_GENERATOR > > > > What you are offering: checkpatch check for people adding that option > > > > But the patch doesn't generally include that option. > > > > I can certainly mention in the Kconfig help that the option is > > deprecated, but without checking if it is defined for a NEW board, I > > cannot prevent it from growing. > > > > What am I missing? Can you be more specific? > > How do you add a new board that enables SPL_FIT_GENERATOR without > "SPL_FIT_GENERATOR" being in the resulting patch, other than being > ARCH_ZYNQMP/ARCH_ROCKCHIP ? Well, that's a problem isn't it? Simon is basically saying no to any new rk3399 board, which doesn't make any sense since this isn't a board-specific issue but a SoC specific issue. Adding new boards doesn't make it more difficult to fix the issue. I guess he is hoping that saying no to a new rk3399 board will trick someone into actually doing the work of adding the necessary code to binman?