From: Johan Jonker <jbx6244@gmail.com>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: kever.yang@rock-chips.com, sjg@chromium.org,
philipp.tomsich@vrull.eu, u-boot@lists.denx.de
Subject: Re: [PATCH v3 1/6] rockchip: move ROCKCHIP_STIMER_BASE to Kconfig
Date: Sat, 12 Mar 2022 11:01:15 +0100 [thread overview]
Message-ID: <d3e29dba-ae8f-bd0e-73f1-0912f8b5c4da@gmail.com> (raw)
In-Reply-To: <CAMty3ZD67x5NEM3rgDfHYA3EztDC7f1ACpue1SKT_dFYTKYF3g@mail.gmail.com>
On 3/12/22 09:51, Jagan Teki wrote:
> On Thu, Dec 30, 2021 at 10:18 PM Johan Jonker <jbx6244@gmail.com> wrote:
>>
>> Move ROCKCHIP_STIMER_BASE to Kconfig.
>>
>> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
>> ---
>>
>> Changed V3:
>> add ROCKCHIP_STIMER
>> ---
>> arch/arm/mach-rockchip/Kconfig | 22 ++++++++++++++++++++++
>> arch/arm/mach-rockchip/px30/Kconfig | 3 +++
>> arch/arm/mach-rockchip/rk3036/Kconfig | 3 +++
>> arch/arm/mach-rockchip/rk3128/Kconfig | 3 +++
>> arch/arm/mach-rockchip/rk322x/Kconfig | 3 +++
>> arch/arm/mach-rockchip/rk3288/Kconfig | 3 +++
>> arch/arm/mach-rockchip/rk3308/Kconfig | 10 ++++++----
>> arch/arm/mach-rockchip/rk3328/Kconfig | 3 +++
>> arch/arm/mach-rockchip/rk3368/Kconfig | 3 +++
>> arch/arm/mach-rockchip/rk3399/Kconfig | 3 +++
>> arch/arm/mach-rockchip/rk3568/Kconfig | 3 +++
>> include/configs/px30_common.h | 1 -
>> include/configs/rk3036_common.h | 1 -
>> include/configs/rk3128_common.h | 1 -
>> include/configs/rk322x_common.h | 1 -
>> include/configs/rk3288_common.h | 1 -
>> include/configs/rk3308_common.h | 1 -
>> include/configs/rk3328_common.h | 1 -
>> include/configs/rk3368_common.h | 1 -
>> include/configs/rk3399_common.h | 1 -
>> include/configs/rk3568_common.h | 1 -
>> 21 files changed, 55 insertions(+), 14 deletions(-)
>>
>> diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
>> index da6871eb..7a624c64 100644
>> --- a/arch/arm/mach-rockchip/Kconfig
>> +++ b/arch/arm/mach-rockchip/Kconfig
>> @@ -343,6 +343,28 @@ config ROCKCHIP_BOOT_MODE_REG
>> The Soc will enter to different boot mode(defined in asm/arch-rockchip/boot_mode.h)
>> according to the value from this register.
>>
>> +config ROCKCHIP_STIMER
>> + bool "Rockchip STIMER support"
>> + default y
>> + depends on (ROCKCHIP_PX30|| \
>> + ROCKCHIP_RK3036|| \
>> + ROCKCHIP_RK3128|| \
>> + ROCKCHIP_RK322X|| \
>> + ROCKCHIP_RK3288|| \
>> + ROCKCHIP_RK3308|| \
>> + ROCKCHIP_RK3328|| \
>> + ROCKCHIP_RK3368|| \
>> + ROCKCHIP_RK3399|| \
>> + ROCKCHIP_RK3568)
>
> What if we select !(SOC-Which-don't-support-stimer). I believe the
> condition check here is much simpler.
The condition would be simpler that's correct, but this patch is made
with rk3066 in mind and there's no ROCKCHIP_RK3066 available yet.
The right approach is to only include SoC's that have a specific
property/functionality linked to there specific config tag.
U-boot should be generic. And we should not have to fix all dependencies
all over the place when a SoC doesn't have something.
Please advise how to support other SoC's like rk3066.
Johan
>
> Jagan.
next prev parent reply other threads:[~2022-03-12 10:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-30 16:48 [PATCH v3 1/6] rockchip: move ROCKCHIP_STIMER_BASE to Kconfig Johan Jonker
2021-12-30 16:48 ` [PATCH v3 2/6] rockchip: move CONFIG_SYS_ARCH_TIMER " Johan Jonker
2022-01-12 20:03 ` Simon Glass
2021-12-30 16:48 ` [PATCH v3 3/6] rockchip: spl: change call condition rockchip_stimer_init() Johan Jonker
2022-01-12 20:03 ` Simon Glass
2021-12-30 16:48 ` [PATCH v3 4/6] rockchip: tpl: " Johan Jonker
2022-01-12 20:03 ` Simon Glass
2021-12-30 16:48 ` [PATCH v3 5/6] rockchip: spl: replace ifdef by IS_ENABLED for timer_init() call condition Johan Jonker
2022-01-12 20:03 ` Simon Glass
2021-12-30 16:48 ` [PATCH v3 6/6] rockchip: tpl: use " Johan Jonker
2022-01-12 20:03 ` Simon Glass
2022-01-12 20:03 ` [PATCH v3 1/6] rockchip: move ROCKCHIP_STIMER_BASE to Kconfig Simon Glass
2022-03-12 8:51 ` Jagan Teki
2022-03-12 10:01 ` Johan Jonker [this message]
2022-03-12 14:39 ` Kever Yang
2022-03-13 12:41 ` Paweł Jarosz
2022-03-13 22:23 ` Simon Glass
2022-03-14 15:36 ` Johan Jonker
2022-03-16 7:06 ` Kever Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3e29dba-ae8f-bd0e-73f1-0912f8b5c4da@gmail.com \
--to=jbx6244@gmail.com \
--cc=jagan@amarulasolutions.com \
--cc=kever.yang@rock-chips.com \
--cc=philipp.tomsich@vrull.eu \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox