From: Vladimir Olovyannikov <vladimir.olovyannikov@broadcom.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/2] drivers: usb: host: Add BRCM xHCI driver
Date: Tue, 26 Nov 2019 10:36:59 -0800 [thread overview]
Message-ID: <d576aa2633e8070d261610d1346aa3a2@mail.gmail.com> (raw)
In-Reply-To: <e5942fba-3caf-83b6-3683-9ce1088329a1@denx.de>
> -----Original Message-----
> From: Marek Vasut <marex@denx.de>
> Sent: Tuesday, November 26, 2019 10:22 AM
[...]
> On 11/26/19 7:18 PM, Vladimir Olovyannikov wrote:
> [...]
> > + /* Enable AXI read and write attributes. */
> > + clrsetbits_le32((hc_base + DRD2U3H_XHC_REGS_AXIWRA),
>
> Here is another extra parenthesis ;-)
>
> > + (USBAXIWR_UA_MASK | USBAXIWR_SA_MASK),
> > + (USBAXIWR_UA_VAL | USBAXIWR_SA_VAL));
> > + clrsetbits_le32((hc_base + DRD2U3H_XHC_REGS_AXIRDA),
> > + (USBAXIRD_UA_MASK | USBAXIRD_SA_MASK),
> > + (USBAXIRD_UA_VAL | USBAXIRD_SA_VAL));
>
> There is a lot of them ^ Please fix those, otherwise it's good.
Thanks for the catch. Will be addressed in patch v3.
>
> [..]
prev parent reply other threads:[~2019-11-26 18:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 18:18 [U-Boot] [PATCH v2 0/2] Add Broadcom XHCI driver for iproc platforms Vladimir Olovyannikov
2019-11-26 18:18 ` [U-Boot] [PATCH v2 1/2] dt-bindings: Documentation on BRCM xHCI controller Vladimir Olovyannikov
2019-11-26 18:18 ` [U-Boot] [PATCH v2 2/2] drivers: usb: host: Add BRCM xHCI driver Vladimir Olovyannikov
2019-11-26 18:21 ` Marek Vasut
2019-11-26 18:36 ` Vladimir Olovyannikov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d576aa2633e8070d261610d1346aa3a2@mail.gmail.com \
--to=vladimir.olovyannikov@broadcom.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox