From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vladimir Olovyannikov <vladimir.olovyannikov@broadcom.com>
Date: Tue, 26 Nov 2019 10:36:59 -0800
Subject: [U-Boot] [PATCH v2 2/2] drivers: usb: host: Add BRCM xHCI driver
In-Reply-To: <e5942fba-3caf-83b6-3683-9ce1088329a1@denx.de>
References: <20191126181838.16438-1-vladimir.olovyannikov@broadcom.com>
 <20191126181838.16438-3-vladimir.olovyannikov@broadcom.com>
 <e5942fba-3caf-83b6-3683-9ce1088329a1@denx.de>
Message-ID: <d576aa2633e8070d261610d1346aa3a2@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

> -----Original Message-----
> From: Marek Vasut <marex@denx.de>
> Sent: Tuesday, November 26, 2019 10:22 AM
[...]
> On 11/26/19 7:18 PM, Vladimir Olovyannikov wrote:
> [...]
> > +	/* Enable AXI read and write attributes. */
> > +	clrsetbits_le32((hc_base + DRD2U3H_XHC_REGS_AXIWRA),
>
> Here is another extra parenthesis ;-)
>
> > +			(USBAXIWR_UA_MASK | USBAXIWR_SA_MASK),
> > +			(USBAXIWR_UA_VAL | USBAXIWR_SA_VAL));
> > +	clrsetbits_le32((hc_base + DRD2U3H_XHC_REGS_AXIRDA),
> > +			(USBAXIRD_UA_MASK | USBAXIRD_SA_MASK),
> > +			(USBAXIRD_UA_VAL | USBAXIRD_SA_VAL));
>
> There is a lot of them ^ Please fix those, otherwise it's good.
Thanks for the catch. Will be addressed in patch v3.
>
> [..]