From: Michal Simek <michal.simek@xilinx.com>
To: Wolfgang Denk <wd@denx.de>, Michal Simek <michal.simek@xilinx.com>
Cc: Michael Walle <michael@walle.cc>, Marek Vasut <marex@denx.de>,
<u-boot@lists.denx.de>,
Grygorii Strashko <grygorii.strashko@ti.com>,
<fried.dev@gmail.com>, <joe.hershberger@ni.com>,
<sjg@chromium.org>, Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH RFC] cmd: fix net list command
Date: Mon, 15 Nov 2021 17:12:02 +0100 [thread overview]
Message-ID: <d5ebea06-a896-a4ef-97ae-e9496605ff55@xilinx.com> (raw)
In-Reply-To: <1649664.1636989609@gemini.denx.de>
On 11/15/21 16:20, Wolfgang Denk wrote:
> Dear Michal,
>
> In message <2a51974b-41cf-56e4-c9c9-e6b699f27f5c@xilinx.com> you wrote:
>>
>> As we discussed in previous thread. I think there shouldn't be a problem
>> when u-boot passes random mac address (in whatever way) but if Linux
>> driver know how to get correct one it should be tried first.
>
> No, I strongly disagree here. If I set a MAC address in U-Boot and
> pass it to the kernel, I want that the kernel uses this address.
> there may be very good reasons to chose some other address - even if
> the "correct" one is known in U-Boot (say, by accident there are
> several boards using the same MAC address).
MAC addresses can be provided in OTP location of qspi. Or on eeprom
which is accessible only when PL is loaded. Also information on 1wire,
or PL gpio pins, etc.
It means mac address is on the board but at u-boot stage doesn't need to
be accessible (or it is not useful to waste time/money on writing driver
for it).
In perfect world u-boot will just get it and use. And if manufacturer
doesn't do it properly but want to enable ethernet in u-boot random
address could be a solution for them.
And then in Linux where drivers are available you will use the right one.
But back to this patch. I think it is good that net list will show all
mac addresses even they are not saved in environment.
And I will let you guys to discuss if makes sense to share random
address up which is what the whole discussion is about. And I have
created a patch which is exactly aligned what it is described above. If
u-boot starts to use random mac I want to see it in Linux too.
Thanks,
Michal
next prev parent reply other threads:[~2021-11-15 16:15 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 12:11 [PATCH RFC] cmd: fix net list command Michael Walle
2021-11-15 12:15 ` Marek Vasut
2021-11-15 12:24 ` Michael Walle
2021-11-15 13:17 ` Marek Vasut
2021-11-15 13:46 ` Michael Walle
2021-11-15 14:31 ` Wolfgang Denk
2021-11-15 14:52 ` Michael Walle
2021-11-15 14:57 ` Michal Simek
2021-11-15 15:07 ` Tom Rini
2021-11-15 15:22 ` Wolfgang Denk
2021-11-15 15:38 ` Tom Rini
2021-11-15 15:20 ` Wolfgang Denk
2021-11-15 16:12 ` Michal Simek [this message]
2021-11-16 13:29 ` Wolfgang Denk
2021-11-15 15:12 ` Tom Rini
2021-11-15 15:15 ` Michael Walle
2021-11-15 15:19 ` Tom Rini
2021-11-15 15:25 ` Wolfgang Denk
2021-11-15 15:45 ` Tom Rini
2021-11-16 13:23 ` Wolfgang Denk
2021-11-15 15:15 ` Wolfgang Denk
2021-11-15 15:21 ` Michael Walle
2021-11-15 16:45 ` Marek Vasut
2021-11-16 6:14 ` Ramon Fried
2021-11-16 13:33 ` Wolfgang Denk
2021-11-16 14:10 ` Tom Rini
2021-11-16 14:51 ` Wolfgang Denk
2021-11-15 13:57 ` Tom Rini
2021-11-15 14:53 ` Michael Walle
2021-11-15 14:53 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5ebea06-a896-a4ef-97ae-e9496605ff55@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=fried.dev@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=joe.hershberger@ni.com \
--cc=marex@denx.de \
--cc=michael@walle.cc \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=wd@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox