From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5EE48C433F5 for ; Thu, 3 Mar 2022 14:37:59 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CA2FE83BB0; Thu, 3 Mar 2022 15:37:56 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="CSKb0woP"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 07FFB83CEF; Thu, 3 Mar 2022 15:37:55 +0100 (CET) Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 080A7837E4 for ; Thu, 3 Mar 2022 15:37:52 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jbx6244@gmail.com Received: by mail-ed1-x533.google.com with SMTP id p4so6915042edi.1 for ; Thu, 03 Mar 2022 06:37:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=t2z3iNqawOyVJfmqVH3TLmDSnC60iRUAUU9+rEfrCYQ=; b=CSKb0woPZuJvkS3UR5Wer/ioRRHLHGnaFfkOm+vLD5MjF6j6TwioKx0VmHXh9bW5H3 S2Cq+K+KdqhwKd89Mg/TXd4afLL6Kz8yx05z/1u1JBwqu4mHLhuXj4cBZfISUks2h5do SvSbCqwhQDcduHvOdO7+BEoJY669kOlItNAwXocR2xzssfSE1Rf5uvrHgd1KibtNzqZF JtTdjsL8HjApI7jY8MuN2GfGt7NCI7jiBGs0ZLjEw/O+Ya6c7lempw2elzqPUu80RRf1 b3EoFLJTKaiEg0GtzC4G/JhxkN2Y7Ude0ByATrcBg1IfVQNmPWbb2at1z9Oaw1tGx8TG ECiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=t2z3iNqawOyVJfmqVH3TLmDSnC60iRUAUU9+rEfrCYQ=; b=Moum/NSKOuJLGPuB0uiBC4vdG1XO594s0GlJYq1YD+/D8eoNczEfQYtFFGQ7447p7K arEEwIi23gGGsqjWrAKwpyNgr6uShxB2YXjBm26zmRg21g8juy+fT0c3TTG/NAtiB9r+ 6qlf7k6sG5z1K+KZM5njAzx5WTtDtPLLrvS+d8mUaNec4IMbmmINNbiHTrVAI+dfDL0O HM0YHx6RuebMUJibmPxU6liTidErT7DWpIMBVTdCOyEmm09SxcVMt2QVFSvDkby2/M4E si07foxsBqqgEduosZkia6WYbK0HhfNPwLHvLcrbOzsXBuShPXm/VwGraxTlkuFolMGJ fyeQ== X-Gm-Message-State: AOAM530bPX6N4ggFV+zaOvBKZolocd3D187U340aAmrvn2fx41svBfFV bn5RiaBv8pTn20gThF9uUok= X-Google-Smtp-Source: ABdhPJweuJNkUqcNjKNz2lNrpe1bh9oxLuv72VsLYu6I/Q5D1yYoBGAk9vIkFd9r/bgWB6agd2T1xg== X-Received: by 2002:aa7:c948:0:b0:413:2bed:e82e with SMTP id h8-20020aa7c948000000b004132bede82emr35249059edt.394.1646318271544; Thu, 03 Mar 2022 06:37:51 -0800 (PST) Received: from [192.168.2.1] (81-204-249-205.fixed.kpn.net. [81.204.249.205]) by smtp.gmail.com with ESMTPSA id u5-20020aa7d985000000b004024027e7dasm908635eds.28.2022.03.03.06.37.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Mar 2022 06:37:50 -0800 (PST) Message-ID: Date: Thu, 3 Mar 2022 15:37:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 12/12] rockchip: fix boot_devices constants Content-Language: en-US To: Simon Glass Cc: kever.yang@rock-chips.com, philipp.tomsich@vrull.eu, u-boot@lists.denx.de, w.egorov@phytec.de, hl@rock-chips.com, jagan@amarulasolutions.com, heiko@sntech.de References: <20220301014749.6446-1-jbx6244@gmail.com> <20220301014749.6446-12-jbx6244@gmail.com> From: Johan Jonker In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Simon, Thank you for your test report. As I don't always have the hardware, could the board maintainers help me identify u-boot specific property differences with Linux that need to be moved to a dtsi file. Will send a new serie with fixes. Johan === After I sync rk3288.dtsi I get this warning. fdt64_t is generated by a script and is not something that I can update the regmap_init_mem_plat function for. Any advice here? ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- make chromebook_jerry_defconfig CC spl/drivers/ram/rockchip/sdram_rk3288.o drivers/ram/rockchip/sdram_rk3288.c: In function ‘conv_of_plat’: drivers/ram/rockchip/sdram_rk3288.c:1032:41: warning: passing argument 2 of ‘regmap_init_mem_plat’ from incompatible pointer type [-Wincompatible-pointer-types] ret = regmap_init_mem_plat(dev, of_plat->reg, ~~~~~~~^~~~~ In file included from drivers/ram/rockchip/sdram_rk3288.c:18: include/regmap.h:391:58: note: expected ‘fdt_val_t *’ {aka ‘unsigned int *’} but argument is of type ‘fdt64_t *’ {aka ‘long long unsigned int *’} int regmap_init_mem_plat(struct udevice *dev, fdt_val_t *reg, int count, On 3/3/22 04:37, Simon Glass wrote: > Hi Johan, > > On Mon, 28 Feb 2022 at 18:48, Johan Jonker wrote: >> >> The DT node name pattern in mmc-controller.yaml for mmc >> is "^mmc(@.*)?$". The Rockchip mmc nodes have been synced >> with Linux, so update the boot_devices constants as well. >> >> Signed-off-by: Johan Jonker >> Reviewed-by: Simon Glass >> --- >> arch/arm/mach-rockchip/rk3188/rk3188.c | 4 ++-- >> arch/arm/mach-rockchip/rk322x/rk322x.c | 4 ++-- >> arch/arm/mach-rockchip/rk3288/rk3288.c | 4 ++-- >> arch/arm/mach-rockchip/rk3328/rk3328.c | 4 ++-- >> arch/arm/mach-rockchip/rk3368/rk3368.c | 4 ++-- >> 5 files changed, 10 insertions(+), 10 deletions(-) > > I tested this series on snow and it seems fine. > > I tried it on jerry and got: > > DRAM init failed: -19 noc: syscon@ffac0000 { compatible = "rockchip,rk3288-noc", "syscon"; reg = <0x0 0xffac0000 0x0 0x2000>; Forgot something. Does that help or is there more that needs to be fixed? ==> u-boot,dm-pre-reloc; }; TODO: Must change/update dmc/noc reg size when I sync rk3288.dtsi. > > It also seemed fine on bob although my display is not coming up, for > different reasons. In SPL or full U-boot? rk3288-veyron-chromebook.dtsi: aliases { i2c20 = &i2c_tunnel; video0 = &vopl; video1 = &vopb; }; Is this video alias something U-boot specific? Fixing U-boot video is beyond my U-boot knowledge. > > Regards > > Simon