U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Ferass El Hafidi" <funderscore@postmarketos.org>
To: "Lucas Tanure" <tanure@linux.com>,
	u-boot-amlogic@groups.io, u-boot@lists.u-boot-project.org
Cc: neil.armstrong@linaro.org, trini@konsulko.com,
	ilias.apalodimas@linaro.org
Subject: Re: [PATCH 1/4] serial: meson: add Amlogic S4 UART support
Date: Sun, 16 Aug 2026 17:41:16 +0000	[thread overview]
Message-ID: <d7a85b8f6f65f7caabb45ebaff5380335030bb2f@postmarketos.org> (raw)
In-Reply-To: <e8d19994-1236-4984-be2a-058cc317d10b@linux.com>

(didn't mean for this to be off-list sorry about that)

On Sun, 16 Aug 2026 10:42, Lucas Tanure <tanure@linux.com mailto:tanure@l=
inux.com > wrote:
>On 10/08/2026 15:01, Ferass El Hafidi wrote:
>> On Thu, 06 Aug 2026 10:18, "Lucas Tanure via groups.io"=C2=A0
>> <tanure=3Dlinux.com@groups.io mailto:linux.com@groups.io > wrote:
>>> The S4-generation UART (S4, T7, ...) derives its baud rate from the
>>> 24 MHz crystal divided by 2, selected via the XTAL_DIV2 bit in the
>>> baud rate register, while older SoCs divide the crystal by 3. Add the
>>> "amlogic,meson-s4-uart" compatible with driver data selecting the
>>> div-by-2 scheme, matching the Linux driver (meson_s4_uart_data) and
>>> the configuration the vendor BL2 programs on T7 hardware.
>>>
>>> Older SoCs keep the existing div-by-3 behaviour: Linux also uses
>>> div-by-2 on G12A, but both modes work there and switching would risk
>>> regressing boards that have shipped with div-by-3 for years.
>>>
>>> Also drain the transmitter before changing the baud rate so in-flight
>>> characters are not garbled, as the Linux driver does.
>>>
>>> Assisted-by: Claude:claude-fable-5
>>=C2=A0
>> As I understand it, LLM-assisted patches are not welcome in U-Boot rig=
ht
>> now: https://lore.kernel.org/u-boot/20260515220758.GM1858239@bill-the-=
cat/
>>=C2=A0
>> AFAIK there isn't an official AI policy yet, but it seems the concensu=
s
>> on that matter is currently "please don't". Sorry.
>
>Ok, I will drop this line.
>

Please do not drop this line. I appreciate the transparency towards your
use of AI. I would wait for someone more knowlegable about AI use
discussions to reply.

Best regards,
Ferass

  reply	other threads:[~2026-08-16 17:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-06 10:18 [PATCH 0/4] Add Amlogic T7 (A311D2) and Khadas VIM4 support Lucas Tanure
2026-08-06 10:18 ` [PATCH 1/4] serial: meson: add Amlogic S4 UART support Lucas Tanure
2026-08-10 14:01   ` Ferass El Hafidi
2026-08-16 10:42     ` Lucas Tanure
2026-08-16 17:41       ` Ferass El Hafidi [this message]
2026-08-17 17:25         ` Lucas Tanure
2026-08-06 10:18 ` [PATCH 2/4] arm: meson: add Amlogic T7 SoC family support Lucas Tanure
2026-08-10 14:15   ` Ferass El Hafidi
2026-08-06 10:18 ` [PATCH 3/4] board: amlogic: add Khadas VIM4 support Lucas Tanure
2026-08-10 14:30   ` Ferass El Hafidi
2026-08-06 10:18 ` [PATCH 4/4] doc: board: amlogic: add Khadas VIM4 documentation Lucas Tanure
2026-08-10  8:13 ` [PATCH 0/4] Add Amlogic T7 (A311D2) and Khadas VIM4 support neil.armstrong
2026-08-10 14:12 ` Ferass El Hafidi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d7a85b8f6f65f7caabb45ebaff5380335030bb2f@postmarketos.org \
    --to=funderscore@postmarketos.org \
    --cc=ilias.apalodimas@linaro.org \
    --cc=neil.armstrong@linaro.org \
    --cc=tanure@linux.com \
    --cc=trini@konsulko.com \
    --cc=u-boot-amlogic@groups.io \
    --cc=u-boot@lists.u-boot-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox