Re: [PATCH 1/7] arm: at91: wdt: Remove unused at91_wdt struct

[Eugen Hristev <eugen.hristev@linaro.org>]

On 3/31/25 22:15, Zixun LI wrote:
> at91_wdt struct is not used by anyone, let's remove it.
> 
> Signed-off-by: Zixun LI <admin@hifiphile.com>
> ---
>  arch/arm/mach-at91/include/mach/at91_wdt.h | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/arch/arm/mach-at91/include/mach/at91_wdt.h b/arch/arm/mach-at91/include/mach/at91_wdt.h
> index 8ef8e007d77..78ad0453fd9 100644
> --- a/arch/arm/mach-at91/include/mach/at91_wdt.h
> +++ b/arch/arm/mach-at91/include/mach/at91_wdt.h
> @@ -19,12 +19,6 @@
>  
>  #else
>  
> -typedef struct at91_wdt {
> -	u32	cr;
> -	u32	mr;
> -	u32	sr;
> -} at91_wdt_t;
> -
>  struct at91_wdt_priv {
>  	void __iomem *regs;
>  	u32 regval;

This breaks sama5d2_xplained_mmc_defconfig for example.

In file included from arch/arm/mach-at91/spl.c:8:
arch/arm/mach-at91/spl.c: In function ‘at91_disable_wdt’:
arch/arm/mach-at91/spl.c:19:39: error: invalid use of undefined type
‘struct at91_wdt’
   19 |         writel(AT91_WDT_MR_WDDIS, &wdt->mr);
      |                                       ^~
./arch/arm/include/asm/io.h:31:69: note: in definition of macro
‘__arch_putl’
   31 | #define __arch_putl(v,a)                (*(volatile unsigned int
*)(a) = (v))
      |
   ^
arch/arm/mach-at91/spl.c:19:9: note: in expansion of macro ‘writel’
   19 |         writel(AT91_WDT_MR_WDDIS, &wdt->mr);
      |         ^~~~~~