public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [PATCH] xilinx: zynqmp: Add the missing function prototype
@ 2024-02-07  8:33 Venkatesh Yadav Abbarapu
  2024-02-07 11:30 ` Michal Simek
  0 siblings, 1 reply; 3+ messages in thread
From: Venkatesh Yadav Abbarapu @ 2024-02-07  8:33 UTC (permalink / raw)
  To: u-boot; +Cc: michal.simek, git

Add missing prototype to fix the below sparse warning
warning: no previous prototype for 'spl_spi_get_uboot_offs'
	 [-Wmissing-prototypes]

Signed-off-by: Venkatesh Yadav Abbarapu <venkatesh.abbarapu@amd.com>
---
 board/xilinx/zynqmp/zynqmp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/board/xilinx/zynqmp/zynqmp.c b/board/xilinx/zynqmp/zynqmp.c
index 9f50090720..ba49eb7be2 100644
--- a/board/xilinx/zynqmp/zynqmp.c
+++ b/board/xilinx/zynqmp/zynqmp.c
@@ -18,6 +18,7 @@
 #include <ahci.h>
 #include <scsi.h>
 #include <soc.h>
+#include <spl.h>
 #include <malloc.h>
 #include <memalign.h>
 #include <wdt.h>
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] xilinx: zynqmp: Add the missing function prototype
  2024-02-07  8:33 [PATCH] xilinx: zynqmp: Add the missing function prototype Venkatesh Yadav Abbarapu
@ 2024-02-07 11:30 ` Michal Simek
  2024-02-09  8:18   ` Michal Simek
  0 siblings, 1 reply; 3+ messages in thread
From: Michal Simek @ 2024-02-07 11:30 UTC (permalink / raw)
  To: Venkatesh Yadav Abbarapu, u-boot; +Cc: git



On 2/7/24 09:33, Venkatesh Yadav Abbarapu wrote:
> Add missing prototype to fix the below sparse warning
> warning: no previous prototype for 'spl_spi_get_uboot_offs'
> 	 [-Wmissing-prototypes]
> 
> Signed-off-by: Venkatesh Yadav Abbarapu <venkatesh.abbarapu@amd.com>
> ---
>   board/xilinx/zynqmp/zynqmp.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/board/xilinx/zynqmp/zynqmp.c b/board/xilinx/zynqmp/zynqmp.c
> index 9f50090720..ba49eb7be2 100644
> --- a/board/xilinx/zynqmp/zynqmp.c
> +++ b/board/xilinx/zynqmp/zynqmp.c
> @@ -18,6 +18,7 @@
>   #include <ahci.h>
>   #include <scsi.h>
>   #include <soc.h>
> +#include <spl.h>
>   #include <malloc.h>
>   #include <memalign.h>
>   #include <wdt.h>


good. Please send it to upstream.
M

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] xilinx: zynqmp: Add the missing function prototype
  2024-02-07 11:30 ` Michal Simek
@ 2024-02-09  8:18   ` Michal Simek
  0 siblings, 0 replies; 3+ messages in thread
From: Michal Simek @ 2024-02-09  8:18 UTC (permalink / raw)
  To: Venkatesh Yadav Abbarapu, u-boot; +Cc: git



On 2/7/24 12:30, Michal Simek wrote:
> 
> 
> On 2/7/24 09:33, Venkatesh Yadav Abbarapu wrote:
>> Add missing prototype to fix the below sparse warning
>> warning: no previous prototype for 'spl_spi_get_uboot_offs'
>>      [-Wmissing-prototypes]
>>
>> Signed-off-by: Venkatesh Yadav Abbarapu <venkatesh.abbarapu@amd.com>
>> ---
>>   board/xilinx/zynqmp/zynqmp.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/board/xilinx/zynqmp/zynqmp.c b/board/xilinx/zynqmp/zynqmp.c
>> index 9f50090720..ba49eb7be2 100644
>> --- a/board/xilinx/zynqmp/zynqmp.c
>> +++ b/board/xilinx/zynqmp/zynqmp.c
>> @@ -18,6 +18,7 @@
>>   #include <ahci.h>
>>   #include <scsi.h>
>>   #include <soc.h>
>> +#include <spl.h>
>>   #include <malloc.h>
>>   #include <memalign.h>
>>   #include <wdt.h>
> 
> 
> good. Please send it to upstream.

:-) this is already upstreamed.
Applied with also
Fixes: 2c8a09219cdb ("arm64: zynqmp: Add multiboot support for SPL/SPI offset 
calculation")

Thanks,
Michal


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-02-09  8:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-07  8:33 [PATCH] xilinx: zynqmp: Add the missing function prototype Venkatesh Yadav Abbarapu
2024-02-07 11:30 ` Michal Simek
2024-02-09  8:18   ` Michal Simek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox