From: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
To: u-boot@lists.denx.de
Subject: [PATCH] scripts/get_default_envs.sh: preserve order of multiple entries for same variable
Date: Wed, 29 Apr 2020 10:46:23 +0200 [thread overview]
Message-ID: <da4b2d08-d5fa-ee0a-edda-33aee8c90fea@prevas.dk> (raw)
In-Reply-To: <CAPnjgZ2JvXwr74Wm_FHeLBBWjMn7bJaX0f3s3hNddrr5q9eujg@mail.gmail.com>
On 30/01/2020 03.17, Simon Glass wrote:
> On Mon, 6 Jan 2020 at 05:17, Lukasz Majewski <lukma@denx.de> wrote:
>>
>> Hi Rasmus,
>>
>>> It's possible that the default_environment[] array contains multiple
>>> entries for the same variable, e.g. a setting from env_default.h based
>>> on some CONFIG_* variable, and another from
>>> CONFIG_EXTRA_ENV_SETTINGS. In such a case, the last setting takes
>>> effect.
>>>
>>> Hence, in order to be able to use the output from this script as an
>>> CONFIG_DEFAULT_ENV_FILE and get the same default environment as one
>>> currently has, we need to preserve the order. So only sort by the
>>> variable name, and disable the last-resort comparison.
>>>
>>> We could pipe the result through uniq to remove duplicate lines, but I
>>> think there's some value in seeing that certain variables are defined
>>> multiple times.
>>>
>>> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
>>> ---
>>> scripts/get_default_envs.sh | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> Reviewed-by: Lukasz Majewski <lukma@denx.de>
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
>
Hi Tom,
This has two R-Bs, perhaps I can get you to pick it up?
Thanks,
Rasmus
next prev parent reply other threads:[~2020-04-29 8:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 12:01 [PATCH] scripts/get_default_envs.sh: preserve order of multiple entries for same variable Rasmus Villemoes
2020-01-06 12:16 ` Lukasz Majewski
2020-01-30 2:17 ` Simon Glass
2020-04-29 8:46 ` Rasmus Villemoes [this message]
2020-05-07 13:03 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da4b2d08-d5fa-ee0a-edda-33aee8c90fea@prevas.dk \
--to=rasmus.villemoes@prevas.dk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox