public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: Ashok Reddy Soma <ashok.reddy.soma@xilinx.com>, <u-boot@lists.denx.de>
Cc: <lukma@denx.de>, <michal.simek@xilinx.com>, <git@xilinx.com>,
	<somaashokreddy@gmail.com>,
	T Karthik Reddy <t.karthik.reddy@xilinx.com>
Subject: Re: [PATCH] clk: versal: Enable only GATE type clocks
Date: Mon, 27 Sep 2021 10:22:26 +0200	[thread overview]
Message-ID: <db2c91ed-6829-e2bf-b644-06722eca6aad@xilinx.com> (raw)
In-Reply-To: <20210927081110.10528-1-ashok.reddy.soma@xilinx.com>



On 9/27/21 10:11 AM, Ashok Reddy Soma wrote:
> From: T Karthik Reddy <t.karthik.reddy@xilinx.com>
> 
> Clocks should be enabled or disabled only if they are of GATE type
> clocks. If they are not of GATE type clocks, don't touch them.
> 
> Signed-off-by: T Karthik Reddy <t.karthik.reddy@xilinx.com>
> Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma@xilinx.com>
> ---
> 
>  drivers/clk/clk_versal.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/clk_versal.c b/drivers/clk/clk_versal.c
> index 62523d2909..a9dd57b098 100644
> --- a/drivers/clk/clk_versal.c
> +++ b/drivers/clk/clk_versal.c
> @@ -725,7 +725,10 @@ static int versal_clk_enable(struct clk *clk)
>  
>  	clk_id = priv->clk[clk->id].clk_id;
>  
> -	return xilinx_pm_request(PM_CLOCK_ENABLE, clk_id, 0, 0, 0, NULL);
> +	if (versal_clock_gate(clk_id))
> +		return xilinx_pm_request(PM_CLOCK_ENABLE, clk_id, 0, 0, 0, NULL);
> +
> +	return 0;
>  }
>  
>  static struct clk_ops versal_clk_ops = {
> 

CR?
M

       reply	other threads:[~2021-09-27  8:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210927081110.10528-1-ashok.reddy.soma@xilinx.com>
2021-09-27  8:22 ` Michal Simek [this message]
2021-09-28  6:00 [PATCH] clk: versal: Enable only GATE type clocks Ashok Reddy Soma
2021-09-29 13:28 ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db2c91ed-6829-e2bf-b644-06722eca6aad@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=ashok.reddy.soma@xilinx.com \
    --cc=git@xilinx.com \
    --cc=lukma@denx.de \
    --cc=somaashokreddy@gmail.com \
    --cc=t.karthik.reddy@xilinx.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox