From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BE19C433EF for ; Mon, 27 Sep 2021 08:23:01 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1FFD360F70 for ; Mon, 27 Sep 2021 08:22:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1FFD360F70 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=xilinx.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 26B2D8326F; Mon, 27 Sep 2021 10:22:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=xilinx.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="rbtGr3z8"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E13918326F; Mon, 27 Sep 2021 10:22:54 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on20609.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe5a::609]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2C6B38323F for ; Mon, 27 Sep 2021 10:22:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=xilinx.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=michals@xilinx.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XjynRZIRooI3GMad86ChgI37bSLRSG2so+zU8RYfhn2CLpdEZQUBaZ9b3Pwp5htUFBWKAUYXOwv71v/ISox/vmI4VHsVnM42YyEM/CHW7w8bvWIAuaqxD+hG0uKEk3F30HfP5dR5w9KaePod2XDXKB1KIfk+6C9riO8QRu6tm+q46F51lrha927xnqOL7cydvhYT05dXDjK5goJmIwaMM1n4ZiajndheT90qW0qGzJH6razxUixrDolNO8fqqgJwvwE0KnhAZqjtMh555zYYZYmDAzIafhs+eWuh2hU01uzXv9m3grZJGUePA65ZvAiRz9sxd820KcaShLZXKA+ywg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=iWZJkulvLFq5vDTz0ICuv7AzKRxeDOUUh92jYwhi8KU=; b=LcRLNZqPoJZ/upvIJ2+YAGQAgyI3BF06Nh7KCuQE09kZF+SzY7Ge8cyp7Ym91/McNLW8Z1rywuLL5SNOCti0FRhOTimOBZfc5sFsnDRzGFqWzGkxa3wmdrRwv6wsFbk8QBZ1o71pkQ2yLg36XeXO9GOU5aaMiNj742YnDKEiFkKqV2gL6N92HKFRbjCre/Ns48Hk0F9OG4sYQEZVPdTPDtamHgCH60UvjPMu5TRR3wRqHEUrFCuyEh5Img6iAY6VAJMwEIpLk/aBJ0YYiapEaZc2/+dmzjmp+NBYQUqWF4eA+0WtAi43SJQiiflrhpF3MlqqIj1GtlJM8AGRyqxP3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=gmail.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iWZJkulvLFq5vDTz0ICuv7AzKRxeDOUUh92jYwhi8KU=; b=rbtGr3z8T0lL1otSiJ6b1Y2nTz3DYEkNdS+xYqV+rpck0rICsA/AOMbOs/sS616G1FqPmrxakRixaFupX10cSfGRju6GiMil+MNmvWqCpCpRAZXLiXyzXNy9sUuCn03L64gGvAO9Dbopka8vUQn8dj0fZLISERhdEAMqRWhNUJw= Received: from BN8PR15CA0060.namprd15.prod.outlook.com (2603:10b6:408:80::37) by DM6PR02MB6427.namprd02.prod.outlook.com (2603:10b6:5:1f7::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13; Mon, 27 Sep 2021 08:22:47 +0000 Received: from BN1NAM02FT063.eop-nam02.prod.protection.outlook.com (2603:10b6:408:80:cafe::42) by BN8PR15CA0060.outlook.office365.com (2603:10b6:408:80::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.15 via Frontend Transport; Mon, 27 Sep 2021 08:22:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by BN1NAM02FT063.mail.protection.outlook.com (10.13.2.169) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4544.13 via Frontend Transport; Mon, 27 Sep 2021 08:22:46 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Mon, 27 Sep 2021 01:22:29 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Mon, 27 Sep 2021 01:22:29 -0700 Envelope-to: git@xilinx.com, somaashokreddy@gmail.com, lukma@denx.de, u-boot@lists.denx.de Received: from [10.254.241.49] (port=45634) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1mUlu8-00032D-8n; Mon, 27 Sep 2021 01:22:28 -0700 Subject: Re: [PATCH] clk: versal: Enable only GATE type clocks To: Ashok Reddy Soma , CC: , , , , T Karthik Reddy References: <20210927081110.10528-1-ashok.reddy.soma@xilinx.com> From: Michal Simek Message-ID: Date: Mon, 27 Sep 2021 10:22:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20210927081110.10528-1-ashok.reddy.soma@xilinx.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0b221dfe-946c-4f5a-bc41-08d9818ffcbf X-MS-TrafficTypeDiagnostic: DM6PR02MB6427: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:229; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ksb0J8jPLnlv8qG+IzV7nl6LSOddJYT9QOEaRTW8RcNh95hhvifS7PNczw+/fi/IKFQx6kq17Bv3d6HD4T8W+DAxS0E8LqVgkPTqsND/Hnrlk4GSxNoJEkGz5AE/4Lwi/WZ0H4NkVdSAym8MKX9hwS7vKd8bhi0zVvdiPLcSGf0WBkSsjGI+Xz9AVyze/ayyNdGVcjWtHTPBBkEQTkeR6YfV1z1bGwdp7ChRe1pU7NcKKPLJ7O9lYhUbQ2BcJS0fU/mDqXT4+jQck3O9rnC4cFWQp2lnIOXwrfy9m/63adjH91bc6t+nEusxw9MOKIDBQZpDoE9NtoHJ8+QXqH0D8FvChSIhfdHg2f3tzyh+Fr17qnIZj3eyzzA+NwSZtmvJizDHqDgj9oH2unQB9YQPn276O3mew7tn/66HgKkqAcO3R3wTGLFBh+pP/l7HhsYuUsWB+iueF5XHVJdmAcbPS56BwzTF9je7tzk7rq3sAw4aVf7EQes6CkuiMA2OO5UqT/FvSbW74cQKAwB3dqgsTi3Jo53DHo9+UnYfFleLgi75sR7GmzA38Yh/a5ywcgZ91/XsnI/o9HMlbjUE/xE6P6m/tcnE+9EV8PyLYm5FlDmbe1mkLNGmr0NIn1J8xJAFLjsbK0ukg2/VcFTtkARP++pKm87lTO9MCw8/qdBJAM+u860ET2sBGgVaBzRQ5fXxEvDY9smVNXw/EYaIyWp6+l7WwDF5bN+IHkOHZqydMQC1WR5IUe3nsme+/bBjaXJNq/cOQHmPDLTivZojdETagg== X-Forefront-Antispam-Report: CIP:149.199.62.198; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:xsj-pvapexch02.xlnx.xilinx.com; PTR:unknown-62-198.xilinx.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(107886003)(336012)(36906005)(4744005)(8676002)(426003)(53546011)(9786002)(4326008)(186003)(8936002)(2616005)(26005)(110136005)(54906003)(44832011)(508600001)(316002)(5660300002)(70586007)(70206006)(36756003)(2906002)(31696002)(82310400003)(356005)(31686004)(36860700001)(47076005)(83380400001)(7636003)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2021 08:22:46.8956 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0b221dfe-946c-4f5a-bc41-08d9818ffcbf X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.62.198]; Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT063.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB6427 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 9/27/21 10:11 AM, Ashok Reddy Soma wrote: > From: T Karthik Reddy > > Clocks should be enabled or disabled only if they are of GATE type > clocks. If they are not of GATE type clocks, don't touch them. > > Signed-off-by: T Karthik Reddy > Signed-off-by: Ashok Reddy Soma > --- > > drivers/clk/clk_versal.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/clk_versal.c b/drivers/clk/clk_versal.c > index 62523d2909..a9dd57b098 100644 > --- a/drivers/clk/clk_versal.c > +++ b/drivers/clk/clk_versal.c > @@ -725,7 +725,10 @@ static int versal_clk_enable(struct clk *clk) > > clk_id = priv->clk[clk->id].clk_id; > > - return xilinx_pm_request(PM_CLOCK_ENABLE, clk_id, 0, 0, 0, NULL); > + if (versal_clock_gate(clk_id)) > + return xilinx_pm_request(PM_CLOCK_ENABLE, clk_id, 0, 0, 0, NULL); > + > + return 0; > } > > static struct clk_ops versal_clk_ops = { > CR? M