public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Christoph Niedermaier <cniedermaier@dh-electronics.com>
To: Francesco Dolcini <francesco@dolcini.it>,
	Fabio Estevam <festevam@gmail.com>, Marek Vasut <marex@denx.de>
Cc: Adam Ford <aford173@gmail.com>, Fabio Estevam <festevam@denx.de>,
	"u-boot@lists.denx.de" <u-boot@lists.denx.de>,
	Dong Aisheng <aisheng.dong@nxp.com>,
	Hou Zhiqiang <Zhiqiang.Hou@nxp.com>,
	"Michael Trimarchi" <michael@amarulasolutions.com>,
	Peng Fan <peng.fan@nxp.com>, "Tim Harvey" <tharvey@gateworks.com>,
	Tom Rini <trini@konsulko.com>,
	"uboot-imx@nxp.com" <uboot-imx@nxp.com>
Subject: RE: [REGRESSION] Re: [PATCH v2 16/24] clk: imx: Convert clock-osc-* back to osc_*
Date: Wed, 16 Apr 2025 14:18:49 +0000	[thread overview]
Message-ID: <db2d623afd944df2bca6d1e4657d4031@dh-electronics.com> (raw)
In-Reply-To: <20250416092639.GA24345@francesco-nb>

From: Francesco Dolcini <francesco@dolcini.it>
Sent: Wednesday, April 16, 2025 11:27 AM
> On Tue, Apr 15, 2025 at 02:13:30PM -0300, Fabio Estevam wrote:
>> On Tue, Apr 15, 2025 at 1:55 PM Marek Vasut <marex@denx.de> wrote:
>>> Do you have af9cdd1ccd2d ("Revert "arm64: dts: imx8mn: Include 32kHz
>>> oscillator clock in SPL DTs"") in place ? If so, try and revert it, does
>>> it help ?
>>
>> It seems I have not pushed the "Revert "arm64: dts: imx8mn: Include 32kHz
>> oscillator clock in SPL DTs" fix. Sorry about that.
>>
>> As Francesco is using imx8mp, then I guess we also need to do the same
>> for imx8mp:
>>
>> diff --git a/arch/arm/dts/imx8mp-u-boot.dtsi b/arch/arm/dts/imx8mp-u-boot.dtsi
>> index 6de9ab5d37cf..35af412f01b0 100644
>> --- a/arch/arm/dts/imx8mp-u-boot.dtsi
>> +++ b/arch/arm/dts/imx8mp-u-boot.dtsi
>> @@ -37,11 +37,6 @@
>>         /delete-property/ assigned-clock-rates;
>>  };
>>
>> -&osc_32k {
>> -       bootph-pre-ram;
>> -       bootph-all;
>> -};
>> -
>>  &osc_24m {
>>         bootph-pre-ram;
>>         bootph-all;
>>
>> Does this fix the boot problem?
> 
> My issue is not the boot. The issue is that USB is not working.
> 
> With this patch applied nothing changes, the issue is not solved.
> 
> Francesco

Hello,

I don't know if it is related or not, I noticed that Adam Ford's patches
commit 6d33ca36e3b ("clk: imx8mm: register UART clocks") and
commit 8999b76f238 ("clk: imx8mn: register UART clocks")
use the former name "clock-osc-24m". But Marek's patch
commit b4734c9c333 ("clk: imx: Convert clock-osc-* back to osc_*")
converted clock-osc-* to osc_*. So I think the UART clocks should also
use the current name osc_*.

Regards
Christoph

  reply	other threads:[~2025-04-16 14:19 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-23 15:58 [PATCH v2 00/24] clk: Add clk_resolve_parent_clk() and fix up iMX clock drivers Marek Vasut
2025-03-23 15:58 ` [PATCH v2 01/24] clk: Add clk_resolve_parent_clk() Marek Vasut
2025-03-23 15:58 ` [PATCH v2 02/24] clk: clk-mux: Fold clk_register_mux() Marek Vasut
2025-03-23 15:58 ` [PATCH v2 03/24] clk: clk-mux: Use struct udevice instead of struct device Marek Vasut
2025-03-23 15:58 ` [PATCH v2 04/24] clk: clk-mux: Resolve parent clock by name Marek Vasut
2025-03-23 15:58 ` [PATCH v2 05/24] clk: imx: Pass struct udevice into imx_clk_mux*() Marek Vasut
2025-03-23 15:58 ` [PATCH v2 06/24] clk: imx: Pass struct udevice to clk_register_mux() Marek Vasut
2025-03-23 15:58 ` [PATCH v2 07/24] clk: clk-gate: Use struct udevice instead of struct device Marek Vasut
2025-03-23 15:58 ` [PATCH v2 08/24] clk: clk-gate: Resolve parent clock by name Marek Vasut
2025-03-23 15:58 ` [PATCH v2 09/24] clk: imx: gate2: Use struct udevice instead of struct device Marek Vasut
2025-03-23 15:58 ` [PATCH v2 10/24] clk: imx: gate2: Resolve parent clock by name Marek Vasut
2025-03-23 15:58 ` [PATCH v2 11/24] clk: imx: Pass struct udevice into imx_clk_gate*() Marek Vasut
2025-03-23 15:58 ` [PATCH v2 12/24] clk: imx: Pass struct udevice to clk_register_gate*() Marek Vasut
2025-03-23 15:58 ` [PATCH v2 13/24] clk: clk-composite: Use struct udevice instead of struct device Marek Vasut
2025-03-23 15:58 ` [PATCH v2 14/24] clk: clk-composite: Resolve parent clock by name Marek Vasut
2025-03-30 15:15   ` Heinrich Schuchardt
2025-03-30 16:14     ` Heinrich Schuchardt
2026-01-27  2:55       ` Simon Glass
2026-01-27  4:36         ` E Shattow
2026-02-04  0:23           ` Simon Glass
2026-02-05  3:14             ` E Shattow
2026-02-04  1:26           ` Heinrich Schuchardt
2025-03-23 15:58 ` [PATCH v2 15/24] clk: imx: Pass struct udevice into imx_clk_composite*() Marek Vasut
2025-03-23 15:58 ` [PATCH v2 16/24] clk: imx: Convert clock-osc-* back to osc_* Marek Vasut
2025-04-15 14:28   ` [REGRESSION] " Francesco Dolcini
2025-04-15 14:43     ` Adam Ford
2025-04-15 15:03       ` Francesco Dolcini
2025-04-15 16:50         ` Marek Vasut
2025-04-15 17:13           ` Fabio Estevam
2025-04-16  4:38             ` Adam Ford
2025-04-16  9:26             ` Francesco Dolcini
2025-04-16 14:18               ` Christoph Niedermaier [this message]
2025-04-16 22:34                 ` Adam Ford
2025-04-16 23:35                   ` Adam Ford
2025-04-16 23:47                     ` Marek Vasut
2025-04-16 23:58                       ` Fabio Estevam
2025-04-17  0:40                         ` Fabio Estevam
2025-04-17  7:24                         ` Marek Vasut
2025-04-17 10:51                           ` Adam Ford
2025-04-17 11:30                             ` Marek Vasut
2025-04-17 12:34                               ` Adam Ford
2025-04-18 14:49                                 ` Marek Vasut
2025-04-17 12:33                           ` Fabio Estevam
2025-03-23 15:58 ` [PATCH v2 17/24] clk: imx: Pass struct udevice into imx_clk_pllv3*() Marek Vasut
2025-03-23 15:58 ` [PATCH v2 18/24] clk: imx: pllv3: Resolve parent clock by name Marek Vasut
2025-03-23 15:58 ` [PATCH v2 19/24] clk: clk-divider: Use struct udevice instead of struct device Marek Vasut
2025-03-23 15:58 ` [PATCH v2 20/24] clk: imx: Pass struct udevice into imx_clk_divider*() Marek Vasut
2025-03-23 15:58 ` [PATCH v2 21/24] clk: clk-divider: Resolve parent clock by name Marek Vasut
2025-03-23 15:58 ` [PATCH v2 22/24] clk: clk-fixed-factor: Use struct udevice instead of struct device Marek Vasut
2025-03-23 15:58 ` [PATCH v2 23/24] clk: clk-fixed-factor: Resolve parent clock by name Marek Vasut
2025-03-23 15:58 ` [PATCH v2 24/24] clk: imx: Pass struct udevice into imx_clk_fixed_factor*() Marek Vasut
2025-03-24 23:33 ` [PATCH v2 00/24] clk: Add clk_resolve_parent_clk() and fix up iMX clock drivers Adam Ford
2025-03-24 23:41   ` Marek Vasut
2025-03-25  7:50 ` Peng Fan
2025-03-25 12:55 ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db2d623afd944df2bca6d1e4657d4031@dh-electronics.com \
    --to=cniedermaier@dh-electronics.com \
    --cc=Zhiqiang.Hou@nxp.com \
    --cc=aford173@gmail.com \
    --cc=aisheng.dong@nxp.com \
    --cc=festevam@denx.de \
    --cc=festevam@gmail.com \
    --cc=francesco@dolcini.it \
    --cc=marex@denx.de \
    --cc=michael@amarulasolutions.com \
    --cc=peng.fan@nxp.com \
    --cc=tharvey@gateworks.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=uboot-imx@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox