public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/5] net: sh_eth: Fix unused variable warnings
Date: Mon, 19 Feb 2018 21:16:27 +0100	[thread overview]
Message-ID: <dbea7568-e049-61aa-ea1a-53314bc5bdb6@gmail.com> (raw)
In-Reply-To: <CANr=Z=ZTEu3ux_jAu-YqqS_03jbj5d592iqmFM5WV4pghm7DUw@mail.gmail.com>

On 02/19/2018 07:13 PM, Joe Hershberger wrote:
> On Sun, Feb 18, 2018 at 10:42 PM, Marek Vasut <marek.vasut@gmail.com> wrote:
>> On 02/17/2018 11:30 PM, Tom Rini wrote:
>>> With a newer toolchain we can see that in both sh_eth_phy_config_legacy
>>> and sh_eth_recv_common the variable port is never referenced as
>>> eth->port is always used instead.
>>>
>>> Cc: Joe Hershberger <joe.hershberger@ni.com>
>>> Signed-off-by: Tom Rini <trini@konsulko.com>
>>> ---
>>>  drivers/net/sh_eth.c | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/net/sh_eth.c b/drivers/net/sh_eth.c
>>> index 850fe1587f59..6f48e93ab53d 100644
>>> --- a/drivers/net/sh_eth.c
>>> +++ b/drivers/net/sh_eth.c
>>> @@ -517,7 +517,7 @@ static int sh_eth_start_common(struct sh_eth_dev *eth)
>>>  #ifndef CONFIG_DM_ETH
>>>  static int sh_eth_phy_config_legacy(struct sh_eth_dev *eth)
>>>  {
>>> -     int port = eth->port, ret = 0;
>>> +     int ret = 0;
>>>       struct sh_eth_info *port_info = &eth->port_info[eth->port];
>>>       struct eth_device *dev = port_info->dev;
>>>       struct phy_device *phydev;
>>> @@ -540,7 +540,7 @@ static int sh_eth_send_legacy(struct eth_device *dev, void *packet, int len)
>>>
>>>  static int sh_eth_recv_common(struct sh_eth_dev *eth)
>>>  {
>>> -     int port = eth->port, len = 0;
>>> +     int len = 0;
>>>       struct sh_eth_info *port_info = &eth->port_info[eth->port];
>>>       uchar *packet = (uchar *)ADDR_TO_P2(port_info->rx_desc_cur->rd2);
>>>
>>>
>> This should be fixed in the PR I sent too.
> 
> PR or the series?

PR, I wrapped this patch into mine.

-- 
Best regards,
Marek Vasut

  reply	other threads:[~2018-02-19 20:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-17 22:30 [U-Boot] [PATCH 1/5] sh: Use -m2a-nofpu only Tom Rini
2018-02-17 22:30 ` [U-Boot] [PATCH 2/5] travis-ci: Enable more SH to be tested Tom Rini
2018-02-19  4:43   ` Marek Vasut
2018-02-19 12:23     ` Tom Rini
2018-02-17 22:30 ` [U-Boot] [PATCH 3/5] net: sh_eth: Fix unused variable warnings Tom Rini
2018-02-19  4:42   ` Marek Vasut
2018-02-19 18:13     ` Joe Hershberger
2018-02-19 20:16       ` Marek Vasut [this message]
2018-02-17 22:30 ` [U-Boot] [PATCH 4/5] sh: Do not provide strncmp Tom Rini
2018-02-19  4:43   ` Marek Vasut
2018-02-17 22:30 ` [U-Boot] [PATCH 5/5] sh7763rdp: Add correct MTDIDS/MTDPARTS Tom Rini
2018-02-19  4:43 ` [U-Boot] [PATCH 1/5] sh: Use -m2a-nofpu only Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dbea7568-e049-61aa-ea1a-53314bc5bdb6@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox