public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ye Li <ye.li@oss.nxp.com>
To: "Sébastien Szymanski" <sebastien.szymanski@armadeus.com>,
	u-boot@lists.denx.de
Cc: Tom Rini <trini@konsulko.com>, Peng Fan <peng.fan@nxp.com>,
	Andrew Goodbody <andrew.goodbody@linaro.org>,
	Kory Maincent <kory.maincent@bootlin.com>,
	Julien Boibessot <julien.boibessot@armadeus.com>
Subject: Re: [PATCH 1/2] serial: lpuart: fix RXFE filed offset for i.MX9
Date: Wed, 25 Feb 2026 11:32:29 +0800	[thread overview]
Message-ID: <dc163ea7-9063-4dfb-a39a-e643c0bcccf1@oss.nxp.com> (raw)
In-Reply-To: <20260218-lpuart-fix-rxfe-offset-v1-1-86a78b224f13@armadeus.com>



On 2/18/2026 10:59 PM, Sébastien Szymanski wrote:
> Like i.MX8 and i.MXRT, on i.MX9, the Receive RX FIFO Enable (RXFE) field
> in LPUART FIFO register is bit 3, so set FIFO_RXFE to 0x08 on i.MX9 too.
> 
> Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
> ---
>   drivers/serial/serial_lpuart.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/serial/serial_lpuart.c b/drivers/serial/serial_lpuart.c
> index 9fdb6503085d..bbce59443388 100644
> --- a/drivers/serial/serial_lpuart.c
> +++ b/drivers/serial/serial_lpuart.c
> @@ -53,7 +53,8 @@
>   #define FIFO_RXSIZE_MASK	0x7
>   #define FIFO_RXSIZE_OFF	0
>   #define FIFO_TXFE		0x80
> -#if defined(CONFIG_ARCH_IMX8) || defined(CONFIG_ARCH_IMXRT)
> +#if defined(CONFIG_ARCH_IMX8) || defined (CONFIG_ARCH_IMX9) || \
> +    defined(CONFIG_ARCH_IMXRT)
>   #define FIFO_RXFE		0x08
>   #else
>   #define FIFO_RXFE		0x40

Previous value 0x40 is wrong for all platforms. You can directly change 
it to 0x08 and remove all ARCH marcos.

Best regards,
Ye Li
> 


  parent reply	other threads:[~2026-02-25  3:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-18 14:59 [PATCH 0/2] serial: lpuart: fix RXFE filed offset and handle Overrun flag Sébastien Szymanski
2026-02-18 14:59 ` [PATCH 1/2] serial: lpuart: fix RXFE filed offset for i.MX9 Sébastien Szymanski
2026-02-25  2:24   ` Peng Fan (OSS)
2026-02-25  3:32   ` Ye Li [this message]
2026-02-18 14:59 ` [PATCH 2/2] serial: lpuart: handle Overrun flag Sébastien Szymanski
2026-02-25  2:24   ` Peng Fan (OSS)
2026-02-19 13:28 ` [PATCH 0/2] serial: lpuart: fix RXFE filed offset and " Kory Maincent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc163ea7-9063-4dfb-a39a-e643c0bcccf1@oss.nxp.com \
    --to=ye.li@oss.nxp.com \
    --cc=andrew.goodbody@linaro.org \
    --cc=julien.boibessot@armadeus.com \
    --cc=kory.maincent@bootlin.com \
    --cc=peng.fan@nxp.com \
    --cc=sebastien.szymanski@armadeus.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox