Re: [PATCH 2/2] board: phytec: common: k3: Expose product infos to Linux

[Wadim Egorov <w.egorov@phytec.de>]

Am 08.11.24 um 19:19 schrieb Daniel Schultz:
> Call 'phytec_ft_board_fixup' in the common K3 board code
> to expose the product name and part number to Linux.
> 
> Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
> ---
>   board/phytec/common/k3/board.c | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
> 
> diff --git a/board/phytec/common/k3/board.c b/board/phytec/common/k3/board.c
> index 3d7e090ccaa..14a10f34e53 100644
> --- a/board/phytec/common/k3/board.c
> +++ b/board/phytec/common/k3/board.c
> @@ -99,8 +99,22 @@ int board_late_init(void)
>   #if IS_ENABLED(CONFIG_OF_LIBFDT) && IS_ENABLED(CONFIG_OF_BOARD_SETUP)
>   int ft_board_setup(void *blob, struct bd_info *bd)
>   {
> +	struct phytec_eeprom_data data;
> +	int ret;
> +
>   	fdt_copy_fixed_partitions(blob);
>   
> +	ret = phytec_eeprom_data_setup(&data, 0, EEPROM_ADDR);
> +	if (ret || !data.valid)
> +		return 0;
> +
> +	ret = phytec_ft_board_fixup(&data, blob, bd);
> +	if (ret) {
> +		pr_err("%s: Failed to add PHYTEC information to fdt.\n",
> +		       __func__);
> +		return 0;

This return is not needed. Other than that, the patch looks good to me.

Reviewed-by: Wadim Egorov <w.egorov@phytec.de>

> +	}
> +
>   	return 0;
>   }
>   #endif