From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 08CC8C04A95 for ; Wed, 28 Sep 2022 16:41:35 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D00CF80444; Wed, 28 Sep 2022 18:41:33 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="oEm/lpKJ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 16BA880429; Wed, 28 Sep 2022 18:41:32 +0200 (CEST) Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 581578493F for ; Wed, 28 Sep 2022 18:41:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qt1-x82a.google.com with SMTP id g12so8307905qts.1 for ; Wed, 28 Sep 2022 09:41:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=fcUXPsuhdwrewoDkqAO2xHVnRXO5/vauo02S9AAqwQs=; b=oEm/lpKJtsmN4UEodp1yNUYAKMau4HW9D4CGoH3eqsXBqab5nwqVq88PqlnG8nFPDd 7Hjpe+oL7ClMy6615ZPWts1ctHfKDzbn6Of2LZ2mi/ypSw9/zEo4jfCqsIlk7Is6UTVi vrNEgk5k6LdKlWZarKpuBRaOCJqbBVVyTWvUB5CtpfijxGYu6KFEtS9ZlGpqzJ9E1QlC bIM2NY7Dm+PpHxfmFPwWcLjaZHH8Hw3Dhp3FLngCeZYTPKjJpuHMkKvLBMGgNs8Yq2Jb Z8v9SDOoodAdPJZa+TRRn6dDE8c3v/tX62k2e0A3uQpAK7xJP63VCGSdVMeAreC3jea4 ebiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=fcUXPsuhdwrewoDkqAO2xHVnRXO5/vauo02S9AAqwQs=; b=LjoaxYHztOCgseLIwYEtG4Jw4eJYhdgGFdGniHMpLJiEHWW26ZD8hdtOGsDhr+/Uta cp869Sy3jhMtVwHGcbCrmZuA2lMrFWc/6W+QqYr8oqkO0gqrMLuErKYJOWRqn8SGNg15 ze2CpJ0bKf4ILZ1+xFr3Fo2VGt1ykCtcjfB98+KGwT7MsvD+1CyVSjUEzBEjlWIODLVS ThfrJfq4EzPfWq/tVgafZPwIdywlWzmAjKKl7B3CUU62pG098hlVqdPGaSJEPtlm3XA0 kwTpfU8VA/UK32A3SS5/JjITOehrqhdf2IBVdRkCd3XNFBNEWjmTEgbc3qfYFkiOEumw gAHQ== X-Gm-Message-State: ACrzQf1YhriduJUNl5SFZyaE9GBkV/uL12pc3je9Hnr3Jwn+lYTmjKxv F0Grst8Xvzk4b4tE5rgJwMA= X-Google-Smtp-Source: AMsMyM7YD6WSGYIOVtbG2eki9RXlMpAXzDFH1iMpDKa3VjJozLOKj0BWREVRxHveqfmlCCMqEJxOzg== X-Received: by 2002:a05:622a:2d5:b0:35d:113a:ea77 with SMTP id a21-20020a05622a02d500b0035d113aea77mr27444315qtx.633.1664383288125; Wed, 28 Sep 2022 09:41:28 -0700 (PDT) Received: from [192.168.1.201] (pool-173-73-95-180.washdc.fios.verizon.net. [173.73.95.180]) by smtp.gmail.com with ESMTPSA id j13-20020a05620a288d00b006cfaee39ccesm3400815qkp.114.2022.09.28.09.41.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Sep 2022 09:41:27 -0700 (PDT) Message-ID: Date: Wed, 28 Sep 2022 12:41:26 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 1/7] dm: clk: add missing stub when CONFIG_CLK is deactivated Content-Language: en-US To: Dario Binacchi , u-boot@lists.denx.de Cc: Amarula patchwork , michael@amarulasolutions.com, Giulio Benetti , Heinrich Schuchardt , Neil Armstrong , Simon Glass References: <20220928084509.2758974-1-dario.binacchi@amarulasolutions.com> <20220928084509.2758974-2-dario.binacchi@amarulasolutions.com> From: Sean Anderson In-Reply-To: <20220928084509.2758974-2-dario.binacchi@amarulasolutions.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 9/28/22 04:45, Dario Binacchi wrote: > Add missing stub for functions [devm_]clk_...() when CONFIG_CLK is > deactivated. > > Signed-off-by: Dario Binacchi > --- > > include/clk.h | 32 +++++++++++++++++++++++++++++++- > 1 file changed, 31 insertions(+), 1 deletion(-) > > diff --git a/include/clk.h b/include/clk.h > index 76bb64bb5ee0..407513e0fa29 100644 > --- a/include/clk.h > +++ b/include/clk.h > @@ -88,8 +88,9 @@ struct clk_bulk { > unsigned int count; > }; > > -#if CONFIG_IS_ENABLED(OF_CONTROL) && CONFIG_IS_ENABLED(CLK) > struct phandle_1_arg; > + > +#if CONFIG_IS_ENABLED(OF_CONTROL) && CONFIG_IS_ENABLED(CLK) > /** > * clk_get_by_phandle() - Get a clock by its phandle information (of-platadata) > * @dev: Device containing the phandle > @@ -258,12 +259,26 @@ int clk_release_all(struct clk *clk, int count); > void devm_clk_put(struct udevice *dev, struct clk *clk); > > #else > + > +static inline int clk_get_by_phandle(struct udevice *dev, const > + struct phandle_1_arg *cells, > + struct clk *clk) > +{ > + return -ENOSYS; > +} > + > static inline int clk_get_by_index(struct udevice *dev, int index, > struct clk *clk) > { > return -ENOSYS; > } > > +static inline int clk_get_by_index_nodev(ofnode node, int index, > + struct clk *clk) > +{ > + return -ENOSYS; > +} > + > static inline int clk_get_bulk(struct udevice *dev, struct clk_bulk *bulk) > { > return -ENOSYS; > @@ -275,6 +290,17 @@ static inline int clk_get_by_name(struct udevice *dev, const char *name, > return -ENOSYS; > } > > +static inline struct clk *devm_clk_get(struct udevice *dev, const char *id) > +{ > + return ERR_PTR(-ENOSYS); > +} > + > +static inline struct clk *devm_clk_get_optional(struct udevice *dev, > + const char *id) > +{ > + return ERR_PTR(-ENOSYS); > +} > + > static inline int > clk_get_by_name_nodev(ofnode node, const char *name, struct clk *clk) > { > @@ -285,6 +311,10 @@ static inline int clk_release_all(struct clk *clk, int count) > { > return -ENOSYS; > } > + > +static inline void devm_clk_put(struct udevice *dev, struct clk *clk) > +{ > +} > #endif > > /** Reviewed-by: Sean Anderson