From: Matthias Brugger <mbrugger@suse.com>
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>,
Hal Feng <hal.feng@starfivetech.com>,
Minda Chen <minda.chen@starfivetech.com>
Cc: Rick Chen <rick@andestech.com>, Leo <ycliang@andestech.com>,
E Shattow <e@freeshell.de>, Sumit Garg <sumit.garg@kernel.org>,
H Bell <dmoo_dv@protonmail.com>, Simon Glass <sjg@chromium.org>,
Andreas Schwab <schwab@suse.de>,
u-boot@lists.denx.de
Subject: Re: [PATCH v3 3/8] board: starfive: DeepComputing FML13V01 fdt selection
Date: Wed, 9 Apr 2025 12:28:07 +0200 [thread overview]
Message-ID: <de6de8da-f7ad-4880-a0da-48ccdd30066a@suse.com> (raw)
In-Reply-To: <20250409071836.26629-4-heinrich.schuchardt@canonical.com>
On 09/04/2025 09:18, Heinrich Schuchardt wrote:
> We support all JH7110 boards with starfive_visionfive2_defconfig.
> The relevant device-tree is selected at runtime based on EEPROM data.
>
> Support setting $fdtfile to the file name of the DeepComputing Framework
> motherboard (FML13V01) device-tree.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> Reviewed-by: Hal Feng <hal.feng@starfivetech.com>
Reviewed-by: Matthias Brugger <mbrugger@suse.com>
> ---
> v3:
> rebased upon Mars CM removal patch
> v2:
> no change
> ---
> board/starfive/visionfive2/starfive_visionfive2.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/board/starfive/visionfive2/starfive_visionfive2.c b/board/starfive/visionfive2/starfive_visionfive2.c
> index b8cd509bc89..5fe888d4072 100644
> --- a/board/starfive/visionfive2/starfive_visionfive2.c
> +++ b/board/starfive/visionfive2/starfive_visionfive2.c
> @@ -17,6 +17,8 @@
> DECLARE_GLOBAL_DATA_PTR;
> #define JH7110_L2_PREFETCHER_BASE_ADDR 0x2030000
> #define JH7110_L2_PREFETCHER_HART_OFFSET 0x2000
> +#define FDTFILE_FML13V01 \
> + "starfive/jh7110-deepcomputing-fml13v01.dtb"
> #define FDTFILE_MILK_V_MARS \
> "starfive/jh7110-milkv-mars.dtb"
> #define FDTFILE_VISIONFIVE2_1_2A \
> @@ -63,7 +65,9 @@ static void set_fdtfile(void)
> log_err("Can't read EEPROM\n");
> return;
> }
> - if (!strncmp(product_id, "MARS", 4)) {
> + if (!strncmp(product_id, "FML13V01", 8)) {
> + fdtfile = FDTFILE_FML13V01;
> + } else if (!strncmp(product_id, "MARS", 4)) {
> fdtfile = FDTFILE_MILK_V_MARS;
> } else if (!strncmp(product_id, "VF7110", 6)) {
> version = get_pcb_revision_from_eeprom();
next prev parent reply other threads:[~2025-04-09 10:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 7:18 [PATCH v3 0/8] board: starfive: DeepComputing FML13V01 Heinrich Schuchardt
2025-04-09 7:18 ` [PATCH v3 1/8] configs: add jh7110-deepcomputing-fml13v01 to VF2 defconfig Heinrich Schuchardt
2025-04-09 10:27 ` Matthias Brugger
2025-04-09 7:18 ` [PATCH v3 2/8] riscv: dts: jh7110: add DeepComputing FML13V01 device-tree Heinrich Schuchardt
2025-04-09 10:27 ` Matthias Brugger
2025-04-09 7:18 ` [PATCH v3 3/8] board: starfive: DeepComputing FML13V01 fdt selection Heinrich Schuchardt
2025-04-09 10:28 ` Matthias Brugger [this message]
2025-04-09 7:18 ` [PATCH v3 4/8] board: starfive: spl: support DeepComputing FML13V01 Heinrich Schuchardt
2025-04-09 7:51 ` Hal Feng
2025-04-09 10:28 ` Matthias Brugger
2025-04-09 7:18 ` [PATCH v3 5/8] doc: add DeepComputing FML13V01 documentation Heinrich Schuchardt
2025-04-09 7:18 ` [PATCH v3 6/8] doc: starfive: use consistent formatting Heinrich Schuchardt
2025-04-09 7:18 ` [PATCH v3 7/8] doc: starfive: use jh7110_common.rst Heinrich Schuchardt
2025-04-09 7:18 ` [PATCH v3 8/8] doc: jh7110: describe debug UART Heinrich Schuchardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de6de8da-f7ad-4880-a0da-48ccdd30066a@suse.com \
--to=mbrugger@suse.com \
--cc=dmoo_dv@protonmail.com \
--cc=e@freeshell.de \
--cc=hal.feng@starfivetech.com \
--cc=heinrich.schuchardt@canonical.com \
--cc=minda.chen@starfivetech.com \
--cc=rick@andestech.com \
--cc=schwab@suse.de \
--cc=sjg@chromium.org \
--cc=sumit.garg@kernel.org \
--cc=u-boot@lists.denx.de \
--cc=ycliang@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox