U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Marginean <alexm.osslist@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [EXT] Re: [PATCH 2/4] configs: ls1028aqds: Enable DM support for pcf2127 rtc
Date: Mon, 15 Jul 2019 11:09:04 +0300	[thread overview]
Message-ID: <decff53a-dcb3-d57d-d4bb-9f5e55803a91@gmail.com> (raw)
In-Reply-To: <AM6PR04MB435778C87D94C08D7F5A02E897CF0@AM6PR04MB4357.eurprd04.prod.outlook.com>

On 7/15/2019 10:20 AM, Chuanhua Han wrote:
> 
>> -----Original Message-----
>> From: Alex Marginean<alexm.osslist@gmail.com>
>> Sent: 2019年7月15日 15:16
[...]
>>
>> On 7/10/2019 10:48 AM, Chuanhua Han wrote:
>>> Enable related configs on all ls1028aqds boards to support pcf2127 rtc
>>> DM function.
>>>
>>> Signed-off-by: Chuanhua Han<chuanhua.han@nxp.com>
>>> ---
[...]
>>>    configs/ls1028aqds_tfa_SECURE_BOOT_defconfig | 11 ++++++++++-
>>>    configs/ls1028aqds_tfa_defconfig             | 11 ++++++++++-
>>>    2 files changed, 20 insertions(+), 2 deletions(-)
>>>
>> date command doesn't seem to work at my end:
>> => date
>> wait_for_sr_state: Arbitration lost sr=92 cr=0 state=2020
>> i2c_init_transfer: failed for chip 0x51 retry=0
>> wait_for_sr_state: Arbitration lost sr=92 cr=0 state=2020
>> i2c_init_transfer: failed for chip 0x51 retry=1
>> wait_for_sr_state: Arbitration lost sr=92 cr=0 state=2020
>> i2c_init_transfer: failed for chip 0x51 retry=2
>> i2c_init_transfer: give up i2c_regs=0x2010000 ## Get date failed
> No, You need to apply the fix pcf2127-rtc patch first.
> http://patchwork.ozlabs.org/patch/1128859/

I do have it applied:
$ git log | grep "rtc: pcf2127:"
     rtc: pcf2127: Fixed bug with rtc settings and getting error time

In fact the fix was merged:
https://gitlab.denx.de/u-boot/u-boot/commit/ef6c26d338a168110b7688b07e319ff46c73748d

Anyway, it could be an issue on my side, I just noticed it and thought I
should let you know.

Thanks!
Alex

> 
>> other than that it looks OK.
>>
>> Reviewed-by: Alex Marginean<alexm.osslist@gmail.com>
>> Tested-by: Alex Marginean<alexm.osslist@gmail.com>

  reply	other threads:[~2019-07-15  8:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-10  7:48 [U-Boot] [PATCH 1/4] armv8: ls1028aqds: Remove the definition of CONFIG_SYS_I2C_EARLY_INIT Chuanhua Han
2019-07-10  7:48 ` [U-Boot] [PATCH 2/4] configs: ls1028aqds: Enable DM support for pcf2127 rtc Chuanhua Han
2019-07-15  7:15   ` Alex Marginean
2019-07-15  7:20     ` [U-Boot] [EXT] " Chuanhua Han
2019-07-15  8:09       ` Alex Marginean [this message]
2019-07-15  8:13         ` Chuanhua Han
2019-07-10  7:48 ` [U-Boot] [PATCH 3/4] armv8: dts: ls1028aqds: Add pca9547 node under the i2c0 controller Chuanhua Han
2019-07-15  7:16   ` Alex Marginean
2019-08-22  8:33     ` Prabhakar Kushwaha
2019-07-10  7:48 ` [U-Boot] [PATCH 4/4] armv8: dts: ls1028aqds: Add pcf2127 node under i2c1 Chuanhua Han
2019-07-15  7:17   ` Alex Marginean
2019-08-22  8:33     ` Prabhakar Kushwaha
2019-07-15  7:13 ` [U-Boot] [PATCH 1/4] armv8: ls1028aqds: Remove the definition of CONFIG_SYS_I2C_EARLY_INIT Alex Marginean
2019-08-22  8:33   ` Prabhakar Kushwaha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=decff53a-dcb3-d57d-d4bb-9f5e55803a91@gmail.com \
    --to=alexm.osslist@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox